From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 947C4C021A9 for ; Mon, 17 Feb 2025 13:53:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tmA8rYpdIvb3NvxXuSSG9N+JD3/0hvHrzucT4jfzO8M=; b=pxm2GqjaP3lQESg7DqPaoV242F CfJoxF4gWNxqO358+fN9Ax6IJcyWoF9p605i+JS1r4nS665iBW1iQMlzkQYCxoOyKSY1T4c4CPYyk 5+15PVtuODq0rmr+GW3BFtegcJSlDYQx9KXVtYKy64CobxxhimDNaXlLK/KJxqTkRQvKgFxKhWM4T Ers/3V8n1zNxnoAsC7BFp4bOpCQ+LIiPDTAX3jxpXq0IZt8itFqOxTG7PmKPHqL+9qFSRTUz0P4r0 Y9NZNFyxVB9z4mLd3c6RcsdNYW2ARf2FKIXKKGLHU0vLZIk7pR/jC43BriNoinEIymfl5+GQEHVYS JSZs+KyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tk1ZC-00000004jts-3nNK; Mon, 17 Feb 2025 13:53:46 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tk1Xl-00000004jmb-0HWD for linux-arm-kernel@bombadil.infradead.org; Mon, 17 Feb 2025 13:52:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=tmA8rYpdIvb3NvxXuSSG9N+JD3/0hvHrzucT4jfzO8M=; b=BdBOSsbP8bdf1fiUvTml8BN6iD lELUqnqYP7gIPlO/dZG4YsnFIE2H7SV7KGBiqVFGlnwAylF4i1D7Iov8lrJbLYcg3kv5EhA2gWOMW KoK/j0yHO5SNfQwXTzi1sXYnB5xjvP5SSdHmkcIc6fGEaNbR/5z8kNN0PeWXb4NBGtpDPzEqXBFe0 jq1k4CJx8LWMa+xEsVIot+ePnxz4jsnS9C/Zwx/nsyOM9mAb8hZ8kdeaOjtlk8j/agsf59/VdhGpg lBcohi+JxkGZw6YSYawWtcyWCl1JwuskaauRFCzOHv8FLLqXA3l7ZBhBsHBriEo/O9vXVZxQyKiYe DDl1wjmg==; Received: from nyc.source.kernel.org ([147.75.193.91]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tk1Xh-00000001pzB-0Lej for linux-arm-kernel@lists.infradead.org; Mon, 17 Feb 2025 13:52:15 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6F865A412F9; Mon, 17 Feb 2025 13:50:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B486CC4CED1; Mon, 17 Feb 2025 13:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1739800329; bh=dk+4Bdm4TSj5u/V4NiBQIblx2mw2lCSFWo0dOUa0rtU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E60OH1gXA5aQjK3LZFBT5xHF1BW8IaBO/NZ38rAQhAaCuA9wvab4WMNy4RSw003hk QkDmRmuM33eqveAL3Uf6z6RWfz94tEmfB+EgISN9ytSGXCkHWe4ZEzDJIzRNWf/p/2 Ve/m9zlPvSPXngIKI2vrpL4EA9T5WwE9iUfyIhoI= Date: Mon, 17 Feb 2025 14:52:05 +0100 From: Greg Kroah-Hartman To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: Patrice Chotard , Thinh Nguyen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] usb: core: Don't use %pK through printk Message-ID: <2025021733-strudel-curator-bfaf@gregkh> References: <20250217-restricted-pointers-usb-v1-0-78da55158832@linutronix.de> <20250217-restricted-pointers-usb-v1-1-78da55158832@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250217-restricted-pointers-usb-v1-1-78da55158832@linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250217_135213_713837_9DA176EC X-CRM114-Status: UNSURE ( 8.31 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 17, 2025 at 02:20:51PM +0100, Thomas Weißschuh wrote: > Restricted pointers ("%pK") are not meant to be used through printk(). > It can unintentionally expose security sensitive, raw pointer values. > > Use regular pointer formatting instead. > > Link: https://lore.kernel.org/lkml/20250113171731-dc10e3c1-da64-4af0-b767-7c7070468023@linutronix.de/ > Signed-off-by: Thomas Weißschuh So really this is just a revert of 2f964780c03b ("USB: core: replace %p with %pK"), right? Why not express it that way, and explain _why_ it's somehow now ok to use %p when previously it wasn't? thanks, greg k-h