From: Peng Fan <peng.fan@oss.nxp.com>
To: Daniel Baluta <daniel.baluta@nxp.com>
Cc: p.zabel@pengutronix.de, shawnguo@kernel.org,
mathieu.poirier@linaro.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, andersson@kernel.org,
linux-remoteproc@vger.kernel.org, iuliana.prodan@nxp.com,
laurentiu.mihalcea@nxp.com, shengjiu.wang@nxp.com,
Frank.Li@nxp.com, krzk@kernel.org
Subject: Re: [PATCH 4/5] reset: imx8mp-audiomix: Add support for DSP run/stall
Date: Tue, 18 Feb 2025 23:12:43 +0800 [thread overview]
Message-ID: <20250218151242.GC6537@nxa18884-linux> (raw)
In-Reply-To: <20250218085712.66690-5-daniel.baluta@nxp.com>
On Tue, Feb 18, 2025 at 10:57:11AM +0200, Daniel Baluta wrote:
>We can Run/Stall the DSP via audio block control bits found in audiomix.
>Implement this functionality using the reset controller and use assert
>for Stall and deassert for Run.
>
>Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
>---
> drivers/reset/reset-imx8mp-audiomix.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/reset/reset-imx8mp-audiomix.c b/drivers/reset/reset-imx8mp-audiomix.c
>index 8cc0a6b58cbc..ee56d52a7278 100644
>--- a/drivers/reset/reset-imx8mp-audiomix.c
>+++ b/drivers/reset/reset-imx8mp-audiomix.c
>@@ -15,10 +15,14 @@
> #define IMX8MP_AUDIOMIX_EARC_RESET_MASK 0x1
> #define IMX8MP_AUDIOMIX_EARC_PHY_RESET_MASK 0x2
>
>+#define IMX8MP_AUDIOMIX_DSP_OFFSET 0x108
>+#define IMX8MP_AUDIOMIX_DSP_RUNSTALL_MASK 0x20
>+
> #define IMX8MP_AUDIOMIX_EARC 0
> #define IMX8MP_AUDIOMIX_EARC_PHY 1
>+#define IMX8MP_AUDIOMIX_DSP 2
Move this to dt-binding?
Regards,
Peng
next prev parent reply other threads:[~2025-02-18 14:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 8:57 [PATCH 0/5] imx8mp: Add support to Run/Stall DSP via reset API Daniel Baluta
2025-02-18 8:57 ` [PATCH 1/5] reset: imx8mp-audiomix: Add prefix for internal macro Daniel Baluta
2025-02-18 9:23 ` Philipp Zabel
2025-02-18 15:51 ` Frank Li
2025-02-19 3:09 ` Peng Fan
2025-02-18 8:57 ` [PATCH 2/5] reset: imx8mp-audiomix: Prepare the code for more reset bits Daniel Baluta
2025-02-18 9:26 ` Philipp Zabel
2025-02-18 15:08 ` Peng Fan
2025-02-18 15:55 ` Frank Li
2025-02-19 8:21 ` Daniel Baluta
2025-02-18 8:57 ` [PATCH 3/5] reset: imx8mp-audiomix: Introduce active_low configuration option Daniel Baluta
2025-02-18 9:30 ` Philipp Zabel
2025-02-18 15:58 ` Frank Li
2025-02-18 15:11 ` Peng Fan
2025-02-18 15:59 ` Frank Li
2025-02-18 8:57 ` [PATCH 4/5] reset: imx8mp-audiomix: Add support for DSP run/stall Daniel Baluta
2025-02-18 9:31 ` Philipp Zabel
2025-02-18 15:12 ` Peng Fan [this message]
2025-02-18 16:00 ` Frank Li
2025-02-18 8:57 ` [PATCH 5/5] imx_dsp_rproc: Use reset controller API to control the DSP Daniel Baluta
2025-02-18 9:35 ` Philipp Zabel
2025-02-19 8:46 ` Daniel Baluta
2025-02-19 3:08 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218151242.GC6537@nxa18884-linux \
--to=peng.fan@oss.nxp.com \
--cc=Frank.Li@nxp.com \
--cc=andersson@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=iuliana.prodan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=laurentiu.mihalcea@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).