From: Manivannan Sadhasivam <mani@kernel.org>
To: Fedor Pchelkin <pchelkin@ispras.ru>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Vitalii Mordan" <mordan@ispras.ru>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Andreas Färber" <afaerber@suse.de>,
"Jeff Johnson" <quic_jjohnson@quicinc.com>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Amit Singh Tomar" <amittomer25@gmail.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-actions@lists.infradead.org,
"Alexey Khoroshilov" <khoroshilov@ispras.ru>,
"Vadim Mutilin" <mutilin@ispras.ru>,
lvc-project@linuxtesting.org, stable@vger.kernel.org
Subject: Re: [PATCH] tty: owl-uart: fix call balance of owl_port->clk handling routines
Date: Wed, 19 Feb 2025 23:18:46 +0530 [thread overview]
Message-ID: <20250219174846.t4eso3o2aug6rb47@thinkpad> (raw)
In-Reply-To: <ci23nalbgrgi5o7zbze4adc54mupn6nymu25konthvtbhyjb7u@z4bteiubsiy6>
On Fri, Feb 14, 2025 at 09:39:09PM +0300, Fedor Pchelkin wrote:
> On Fri, 14. Feb 22:44, Manivannan Sadhasivam wrote:
> > On Thu, Feb 13, 2025 at 02:24:16PM +0300, Vitalii Mordan wrote:
> > > If owl_port->clk was enabled in owl_uart_probe(), it must be disabled in
> > > all error paths to ensure proper cleanup. However, if uart_add_one_port()
> > > returns an error in owl_uart_probe(), the owl_port->clk clock will not be
> > > disabled.
> > >
> > > Use the devm_clk_get_enabled() helper function to ensure proper call
> > > balance for owl_port->clk.
> > >
> >
> > Do not use newly introduced APIs to fix old bugs. The bug should be fixed
> > separately to allow backporting and the conversion should be done on top.
>
> These relatively new helpers are already available in all currently
> supported stable kernels including 5.4.y.
>
> Commit 7ef9651e9792 ("clk: Provide new devm_clk helpers for prepared and
> enabled clocks") was conveniently backported there as a dependency for
> the similar bug fixes.
Ah, then fine with me.
- Mani
--
மணிவண்ணன் சதாசிவம்
next prev parent reply other threads:[~2025-02-19 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 11:24 [PATCH] tty: owl-uart: fix call balance of owl_port->clk handling routines Vitalii Mordan
2025-02-14 17:14 ` Manivannan Sadhasivam
2025-02-14 18:39 ` Fedor Pchelkin
2025-02-19 17:48 ` Manivannan Sadhasivam [this message]
2025-02-19 17:49 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250219174846.t4eso3o2aug6rb47@thinkpad \
--to=mani@kernel.org \
--cc=afaerber@suse.de \
--cc=amittomer25@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-actions@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mordan@ispras.ru \
--cc=mutilin@ispras.ru \
--cc=pchelkin@ispras.ru \
--cc=quic_jjohnson@quicinc.com \
--cc=stable@vger.kernel.org \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox