From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 369C1C021B2 for ; Thu, 20 Feb 2025 11:30:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NCl1V7FHlwI89Tz88V462vnUiFw8XziSIICPk+68cKE=; b=aRNt8gw8SRO2aOqlk02ZyOsVCZ WTKdRHPzgpXl/1BE4G7A8KRtuiTXsFfarPuqiKe6wRLOvLx7PVeYyfbCL9xZLFX2vmrnyosvdzC+M klXsSyo5ffe6TGNUlYlKYyqnkpq/pG3kahMKr3AP1ttzVS00VqgDLuTBEY8ansZEvNFbtUYTZZrt/ G0GdJJedhRGxl4WqSMvteIRMElpVImT/KoYepR/i5NvvkD/s3F24NLidS6Lm/0oeJYosJXrsmTDik sqLV41tSS+9CljSPmM27OHVIatDNorjmylwR6+D9i/o26k7bC9xoGSBuPXLK8OJGMP3PU026AONMA UxLar/5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tl4lB-00000000Z3v-1OGS; Thu, 20 Feb 2025 11:30:29 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tl4jg-00000000YaG-3Lq0 for linux-arm-kernel@lists.infradead.org; Thu, 20 Feb 2025 11:28:57 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KG0E7MXSTXcMpWaygS0RL1234fkrpwXf+NP1cnV5onV+7MX4ALHmziTjob4TKWG0tQ7Rnk4tdwBdAsAwWbz9hDtVu+H8mWLRpsNskIOffoGbDYslMZUzJLdw/yxZS6gZpE3gXHF89Bri0pRyQ15XfguI4OQUiPTTZ5T22MlwYO8rPVrqRf03Z2ijnPxFpxh3423CwbAqY21nya8gxMQX/FK9+seMvy6TSUSCSZh+NVPy77we95WQjwvOQFzj4VTqMzFFMzbCkyOnpLV/2wp9KwF9hENd8mgp0meEdSzUrKzKlcoaFcd+K2ubusYaEbY3IDG0m9Qtw/ukvvV8MD9nNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NCl1V7FHlwI89Tz88V462vnUiFw8XziSIICPk+68cKE=; b=Du62QqX3uxE1hgW/9xn+TPao2woyZWw87BWhxQBuc5T69QEbj3WXNTgm6P16UuuVxATIuk4brbIr6sFaa6M77ToO9J6ch9k9AK1pxjlzCFVPpB0fsAWYzepUk3kM4BStj0hGqPodSiej851M3ycjs5KXJkhphEhJVemk9YWwIuZlh7pFpUpiYz3Z7OVfiTcw06onOADgduPV3eP6sb2Etw6lC49I9OBQVsVfdIMKHkpyAgAZ70x1FqZqSk5VKVWPUqvltW+eTiAivcqRzQpukmxkuUgexs1t869S2PGa3jY9KTQ7LzrNEaQ17zpqiRZiYz4qf7yzqPCutnU09sbSnA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NCl1V7FHlwI89Tz88V462vnUiFw8XziSIICPk+68cKE=; b=TNkPws/klFMhzz/AUQ7RUAHqNeQTxTK5BIlZJ9eYkHG8LsJE2Fl2slcLnBvKKpraOAOQgvPjhqQJLvC/vWRqQllkgKXWjI8GnOqPqYdckvTdi+0zzFmZTYlGZ+v+3IzqWqA1Pq4fqDHvax9Vhz3Kjs/gHJkOSVC39QEtXajMpAQEvaImni1QiFAFTtU9cqpMvzAuoWfsg8Wf3yJugzvZ5c82N/8UPnrB+tcYNRW2nc6Xw8wUztHwyYRr4V+Rip7gqaTMRJLVrvMu46+qiIqBzCzfqjpDs9H+VyffZRXkjk/+zo01/M5H0tLwX4mHQg9Gk9NBDHa3+KVVZJIYgxBz3Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM8PR04MB7779.eurprd04.prod.outlook.com (2603:10a6:20b:24b::14) by VI2PR04MB11076.eurprd04.prod.outlook.com (2603:10a6:800:279::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8466.14; Thu, 20 Feb 2025 11:28:53 +0000 Received: from AM8PR04MB7779.eurprd04.prod.outlook.com ([fe80::7417:d17f:8d97:44d2]) by AM8PR04MB7779.eurprd04.prod.outlook.com ([fe80::7417:d17f:8d97:44d2%6]) with mapi id 15.20.8466.015; Thu, 20 Feb 2025 11:28:53 +0000 Date: Thu, 20 Feb 2025 13:28:48 +0200 From: Vladimir Oltean To: Faizal Rahim Cc: Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Simon Horman , Russell King , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Furong Xu <0x1207@gmail.com>, Russell King , Serge Semin , Xiaolei Wang , Suraj Jaiswal , Kory Maincent , Gal Pressman , Jesper Nilsson , Andrew Halaney , Choong Yong Liang , Kunihiko Hayashi , Vinicius Costa Gomes , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [PATCH iwl-next v5 9/9] igc: Block setting preemptible traffic class in taprio Message-ID: <20250220112848.wpoeqp5bplgkyg73@skbuf> References: <20250220025349.3007793-1-faizal.abdul.rahim@linux.intel.com> <20250220025349.3007793-10-faizal.abdul.rahim@linux.intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250220025349.3007793-10-faizal.abdul.rahim@linux.intel.com> X-ClientProxiedBy: VI1PR07CA0298.eurprd07.prod.outlook.com (2603:10a6:800:130::26) To AM8PR04MB7779.eurprd04.prod.outlook.com (2603:10a6:20b:24b::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM8PR04MB7779:EE_|VI2PR04MB11076:EE_ X-MS-Office365-Filtering-Correlation-Id: d504b53c-0ecb-4d74-76de-08dd51a1c117 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|7416014|376014|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?T5VDvMJOBulePjHi8p0vuZYhgepB3M+YzLFbbdMpDkRNvblDyZFQN5f73omW?= =?us-ascii?Q?ULb73Ic7+yCBES/8j62gNVtLoNTTrN1Lf9SIgsSydS+gQuSWEv13kMlbIRLN?= =?us-ascii?Q?26MBRbmGCNHGjwksQTlzN1TWl7HRSgSe6DcEonRBCef8Fl8/MXVTgr8TelAs?= =?us-ascii?Q?KfvyNW4HXk44+BhQZ+Sywr9//hiBzUzwZw+JU2XVT4lLI1KBdPQm/c7mVmnE?= =?us-ascii?Q?w2HgEoz5AmAPoGSiqps1G4Mqtw+k10I2LCL9TSxtLD1GpjEwznX6LWBI6jm/?= =?us-ascii?Q?TYryoFEao1VZIGzm1xyGZVeU/sHj9ZRONEiZjqAxe6JBLtwW/L6LbhfJl+t2?= =?us-ascii?Q?7xycS0XUkArZVvI3Ww85XSETfEVnmlYX5hhMxITo40hwMPmdrtZcdEo4YYSS?= =?us-ascii?Q?suXjgOaZvcP+T3evvruFpk9LYSEt2oJ8ucSVUSOoJ0SOx9aprp1y2YXOZvx5?= =?us-ascii?Q?ubDKYiip9en+EmaScgGTFvG5H2eer39cwQX9a6+ZTvMLEryuGzlhQ6dEaI6r?= =?us-ascii?Q?v0cDkcM2z/YiDjG2VYuCdkC8ML9+O0JxJIrtWpPWlwtoHr54S5Lf2tCyw+Wg?= =?us-ascii?Q?00sFy+gcDUuo9Hd0WJl63NYlLHjFlZce9OtF3a67I7hUQXxySOZS3A7y7fhL?= =?us-ascii?Q?qi+Ufoo26YAY+HyXt5pKRV1ZBvDjuLDv7LSigjQuTZlhEY+i9P5yTkB5cacS?= =?us-ascii?Q?J6tSPIMO4jNfkqR6/R3dqytXvghfUSG8/zWRo8rQXNupoQBcojYwGdlKN68m?= =?us-ascii?Q?ZCldnAnYX4/DlgwlS/3kY0Qtg6w+Z4LdX/6DZrAmAevQ4D2T96Gtq2cfxK45?= =?us-ascii?Q?X0GnPp+DKhf60L6gmbSc1BEv6l4qCjlZhGqn2Q3IRDXkFLl734YzVKaQvzwt?= =?us-ascii?Q?oEs9HLjqma+jEhag9SO6Q8xgSCYq/Sb6ahhPzAfiWqrEgmj6clvoQ0tC4UU2?= =?us-ascii?Q?sXMVf91UgQmZy3IJAmEIAq1I4LtRP/cQ9+Q/T4r7IrbEyey173NsaSDhzkrv?= =?us-ascii?Q?tWD8y+ISXon7W2j3DZ9jS744UmEWSSFG6G4f+JgxksGUHSyL9P7jIupuWO4S?= =?us-ascii?Q?Suhzx2fyTQWEFdu9CwchoP7pG9ucsBrvTAC6mcJVZwjCw1N5n4Xza43whGNy?= =?us-ascii?Q?iQqqQFmnE0XcStlKVVJsDS1gSw1N2Hmseys0lTp/sgzVYwXpFgr6Sv+fsiVO?= =?us-ascii?Q?4gzLZYuknLja9A3Dl3KNJASIxX5VVZvPha7jnGnIY+oMqtKxzvjoLsqwEJmY?= =?us-ascii?Q?jolR1Edgzdjw0JudeSeH8YUQs7LUqDg1j7vaUdbYBEzFKUnj3Rrt2O5GmD2V?= =?us-ascii?Q?snB6NsKWkYBeqHqjbI7aydoU0i4DPaMiQcy6kAdPX9IAzPOV19OA7lbpIUPQ?= =?us-ascii?Q?w1EEPGKoKA7ATZ8UtyRBMTwfX7UE?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM8PR04MB7779.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(7416014)(376014)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?8bx1aAyO5aBnzRUDnJnNvyjkhhSEnShnA5Qqw3+tphx8/4+jofN+styK6f0K?= =?us-ascii?Q?HJJX2uw+Pux56j+/ZRiHSDdlqJAaCx4bsSF9JgV+DQushRAd02+Gg+PsWkjv?= =?us-ascii?Q?j8tjaZ24oDfnKoqOXQxHKK1mNfcgpPQaidUvwb24BUN0XUONMuGShlKWWxMz?= =?us-ascii?Q?d9JC3NxcOajscVLU/lLhe3+QOYZVpkDaODRxEN/bKiFdgTj8qiYOja7yWyWK?= =?us-ascii?Q?cYC3F+qx/wUt6d9SWGe8CEU8K9w1clWoHVo57NykGRcyfbRnKHEavbDRXLQ+?= =?us-ascii?Q?S4sD9PDoUp74j62SEsIDGE7k6CJH/sCYAK0HwDdFM5mxGO0SpOZ8BRYwgJgJ?= =?us-ascii?Q?3U5n9mIdLrjy+GfKg5itTrthz3tyYdOLnMD4lnU2wR1ZuJ9LYp1BkwYrEJ+k?= =?us-ascii?Q?8VDuNDR14nbcWHz0QWwetz/d4SrTqXMlAZpaTcSh8+oWelY/ox4eDoO+jlR1?= =?us-ascii?Q?QiSeaj0Qg5AQbjq96WfjkrmGrplE9Kl+Sxs34fYVxKU2QOyXLxriPfvXSX0i?= =?us-ascii?Q?w99GVowYQMzo8a7DM+q8Iog1IiALfoReeERJwy/G+Z+Ki33zoVUuevSyPBgT?= =?us-ascii?Q?6qzqC4ZScrjSIaeFkKZUQcJQySZf7/CA8mAa0d515/Ae78I4Lc8TZsi80P5K?= =?us-ascii?Q?mi8b5huDrgq7gKoZKkmMwJk2ob/VuKVVpaf2R8RWTcbZHZN5hvnLFrXFqg7v?= =?us-ascii?Q?4GElynBt0iopo4HBh9axR16bY9kyd04AFkYr2ZSmScMtFUyztn9QNWYsI2Ol?= =?us-ascii?Q?aT+WM4fIzOKf/MQ8yHdRsgX776ELG0GRAnxyz0josF0vwvffTldiNOZyViVU?= =?us-ascii?Q?IJtSdPEJp1Y5VtrseXeqz84DLevH/wyjuwBge9fEgSqKkY21ZCE4uMPUOCyX?= =?us-ascii?Q?RZA+1awf1BwfbhKoQ7T3sqkStrAZTX8WbCW42918jjALsNyQRv+ctwQ0C930?= =?us-ascii?Q?HNuiQ2sHWVIyEtXgBSBEcIT2+Le/By4tm2RpSRKUhVR2IRMZDELRq20nQvho?= =?us-ascii?Q?X0W5YWRoUsUVtzXjk5/5i8Gc6qYuO321hAI/wnvKxKyhYblhd1ophjJtBwMj?= =?us-ascii?Q?0p2ryR9wdpyyGwyQjeRBBgqCuZI38/e5G/eIiXDcga0R8QBNblR7+ofOmJK8?= =?us-ascii?Q?VDjmyXWAxl+iZoc3In/xEmQOJpFMxiyKUVYQAvCc5lSmg5jVOqgwBRXcIsJJ?= =?us-ascii?Q?LmnImUIwzQXcOpmyVKaRRYcs5swLaM7h672n1RbeeMj+FTeRoSGExL36k11u?= =?us-ascii?Q?OP7PV6qqoaVM4ZuZkeltaSLZBz9mof11PVihr1ZqQYfP8RKe3ep5zG2lg+hv?= =?us-ascii?Q?Xidb4z87xPpdavHhG59VEXmLipWdFVTQxLM7EOtSLxUtHZeZopvMtEe9U2n/?= =?us-ascii?Q?nonJhAhwtPNfBVp+jVcGrJNHSJt6NB7rl+Vj86Af8ZVG9GDaNFddI5fdA3Lx?= =?us-ascii?Q?LH5ST2YPKYIEmo+d9w1X0ch7EwjOCmxhgHqbJ3pT8NFCHiWbpt8OanTyfqZP?= =?us-ascii?Q?1FIwmiOTtXcyFn9uhwR6/lfSOdO9qoWXHzmUakvKX7HO2/0t/c3ON5FrDRS4?= =?us-ascii?Q?MeTFOFbhJmwUE1rn67gsMiApIjyZpJiqgHd5tDmu2W57n0Wgip5zpNWqk2je?= =?us-ascii?Q?2w=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d504b53c-0ecb-4d74-76de-08dd51a1c117 X-MS-Exchange-CrossTenant-AuthSource: AM8PR04MB7779.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Feb 2025 11:28:53.0547 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +pyzi/z8y/YJK4dhoRwhbliA484u75v5tgkPGy2v+JBtoiKQE2FPOvayYUo+QOmV34JYoZTmmJYIXu8J2CfuiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB11076 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250220_032856_844102_782D7DAD X-CRM114-Status: GOOD ( 20.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 19, 2025 at 09:53:49PM -0500, Faizal Rahim wrote: > Since preemptible tc implementation is not ready yet, block it from being > set in taprio. The existing code already blocks it in mqprio. > > Signed-off-by: Faizal Rahim > --- > drivers/net/ethernet/intel/igc/igc_main.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c > index 5a6648a12a53..e6a398dbf09b 100644 > --- a/drivers/net/ethernet/intel/igc/igc_main.c > +++ b/drivers/net/ethernet/intel/igc/igc_main.c > @@ -6408,6 +6408,10 @@ static int igc_save_qbv_schedule(struct igc_adapter *adapter, > if (!validate_schedule(adapter, qopt)) > return -EINVAL; > > + /* preemptible isn't supported yet */ > + if (qopt->mqprio.preemptible_tcs) > + return -EOPNOTSUPP; > + > igc_ptp_read(adapter, &now); > > if (igc_tsn_is_taprio_activated_by_user(adapter) && > -- > 2.34.1 > This patch should be before the patch that makes ethtool_dev_mm_supported() return true for igc, i.e. 7/9 "igc: Add support to get MAC Merge data via ethtool". You don't want the kernel to be in a state at all where it accepts a configuration it doesn't support, even if it's temporary and you're fixing it up within the same patch set, because it may be visible during e.g. a git bisect.