[PATCH] ASoC: atmel: atmel-classd: Use str_enabled_disabled() helper

[PATCH] ASoC: atmel: atmel-classd: Use str_enabled_disabled() helper

[Thorsten Blum]

Remove hard-coded strings by using the str_enabled_disabled() helper
function.

Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
 sound/soc/atmel/atmel-classd.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
index ba314b279919..1f8c60d2de82 100644
--- a/sound/soc/atmel/atmel-classd.c
+++ b/sound/soc/atmel/atmel-classd.c
@@ -11,6 +11,7 @@
 #include <linux/module.h>
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
+#include <linux/string_choices.h>
 #include <sound/core.h>
 #include <sound/dmaengine_pcm.h>
 #include <sound/pcm_params.h>
@@ -275,7 +276,7 @@ static int atmel_classd_component_probe(struct snd_soc_component *component)
 	dev_info(component->dev,
 		"PWM modulation type is %s, non-overlapping is %s\n",
 		pwm_type[pdata->pwm_type],
-		pdata->non_overlap_enable?"enabled":"disabled");
+		str_enabled_disabled(pdata->non_overlap_enable));
 
 	return 0;
 }
-- 
2.48.1

Re: [PATCH] ASoC: atmel: atmel-classd: Use str_enabled_disabled() helper

[Andrei Simion]

Hi,

On 23.02.2025 00:59, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>

Reviewed-by: Andrei Simion <andrei.simion@microchip.com>

> ---
>  sound/soc/atmel/atmel-classd.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/atmel/atmel-classd.c b/sound/soc/atmel/atmel-classd.c
> index ba314b279919..1f8c60d2de82 100644
> --- a/sound/soc/atmel/atmel-classd.c
> +++ b/sound/soc/atmel/atmel-classd.c
> @@ -11,6 +11,7 @@
>  #include <linux/module.h>
>  #include <linux/platform_device.h>
>  #include <linux/regmap.h>
> +#include <linux/string_choices.h>
>  #include <sound/core.h>
>  #include <sound/dmaengine_pcm.h>
>  #include <sound/pcm_params.h>
> @@ -275,7 +276,7 @@ static int atmel_classd_component_probe(struct snd_soc_component *component)
>  	dev_info(component->dev,
>  		"PWM modulation type is %s, non-overlapping is %s\n",
>  		pwm_type[pdata->pwm_type],
> -		pdata->non_overlap_enable?"enabled":"disabled");
> +		str_enabled_disabled(pdata->non_overlap_enable));
>
>  	return 0;
>  }

Best Regards,
Andrei Simion

Re: [PATCH] ASoC: atmel: atmel-classd: Use str_enabled_disabled() helper

[Mark Brown]

On Sat, 22 Feb 2025 23:59:25 +0100, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: atmel: atmel-classd: Use str_enabled_disabled() helper
      commit: 88e09306b7e0f8a9e9f9c729ac13ccd11ed9679d

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark