From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A30FC021B2 for ; Sun, 23 Feb 2025 08:56:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qhtfFGtrm/r/EdIHI4NWAw5GAp/ALVl3MX5Mqx7Mu6w=; b=ThILGKpE2evUFJXoe0os7pZeOo icmI6pWc/tRPDX5IjfMXJKYvQ2E4UOHD7pB3hijdI6sNGwBv8cql7FvoxlyJdqEmE5C2LQj3mYui1 EM2tc5yQ3N5wLUyeV2e/TtF6crz6N+t7YhQxVaf8Q7/hiySzowwKoFImSlOG3XO/rLzThDmVEw6NV Xbqt5YIbS1M16Ki9A8UYc68lRWXvC0X1pvYLz4LsBbOyYP26afkxyD6XQu3Wthrw0Y9sPOwisuTIE 8OYgPxFtExF11QasbQXqgABhk7SAjxn1+oKlWFJ4xNxL/BR6KzoExyiZuXHCBgKEAGkOapdQcr5A9 q2dxqoow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tm7n2-0000000AiPp-45NV; Sun, 23 Feb 2025 08:56:45 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tm7l9-0000000AiDL-3ZIp for linux-arm-kernel@lists.infradead.org; Sun, 23 Feb 2025 08:54:49 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-22101839807so73769885ad.3 for ; Sun, 23 Feb 2025 00:54:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740300887; x=1740905687; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=qhtfFGtrm/r/EdIHI4NWAw5GAp/ALVl3MX5Mqx7Mu6w=; b=PIUNqyekKgkXiR3gtTYst0vGy4lnZh0daWEioI7oO2iYRPY3q9CwtlQxwGmSl/9rFH QqdbjdS6UAz+mguGXGsJw1qTDwPkvlvCWHBJh7ksKXAe8grUsup3VbMiFcXLcd92GJQ+ f0L+m2fVKSynt2Uvnz8q3ogZ3ezPNs78iXdooDKHbEhx8dY77mrAbjh1Bkw9+01pzcif 6vCcCwmyvc13Ck/qyoToE0X503g2DofM5t+W+1+89yx6S/Vl8JyLxAom8Bp7Z4qZ2rPS k2EQcOqri+3cxr9iU4n+4QSReIh6i3zDxr1ZAgNCkbsswKfUp8N4Yk/gakC0jSO0lqUP 7TcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740300887; x=1740905687; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qhtfFGtrm/r/EdIHI4NWAw5GAp/ALVl3MX5Mqx7Mu6w=; b=Ot1h5aVC+frOZAaI8WiUinHUjgC66N8siweDbl18v5JhyWZ9ArB3hWH29GfAFtEf9i Qqex1x4ll/iOXO0bqVMyBOwvswQxiD9AOYMfbx4zBf4JeuuN0zxbvyCi0W8PNCFcDP0H hOb4uE9ivqnI/gjzGKoe6hY/Vf6waWlWIsVmgRHZ95H92Uug70D4Vrav8EB7Aw4sEUsv LL1XbSavAZId7Yjej57KVsgvM8drN+BrQAIgGOadrIdvXJIAEyb57OXlOiVeKNuWE/zZ BnQY8EHaC50MEk5JuM5YA5JO+8O7Fc/J4JOTzawtzWVuTNFDwnGXK7NZC6dzvTasnllx T96Q== X-Forwarded-Encrypted: i=1; AJvYcCXieBMJR+zfmhA+t3UovkZEAjtTL54UB3CGh9oswnCfO79bdOTEetM3gSppsuMIgRNbr3Lncq38aGnXtUexBDut@lists.infradead.org X-Gm-Message-State: AOJu0YwyC1wIHX1z6e9gfwSA31AHURgBP2qW2nKdcOLq35Al1EnDqxq4 4+exHXj8H/1mxTyM6X/JTPYd7H+s9h4cukyKLZNuEZ4P3/ZRuRnzpxjChIuIVg== X-Gm-Gg: ASbGncsyhboz0eC4/vVbIvs9XTJc0hAaOl8DlLGu35Io67yeecbqPUFlxD9O6wq0iOd mmuFynAD3qt2XncSlXPlypRh+heY1HRMYNgTVUC0Azr3Xdu59OGh4OW+3ceqbTkaKNCey/+DI9J 1cllRKFN2AEQMcccOovcPL9uJ12I4wtZTUR5goIkiV/VxWflbMNG7VCnAvfWaWdKm9M+kQr3soB G5l3pN3hytp5qAJyuCNe+9+Jgv9PklsMTWz3RHEuDbhKu1k3r4w1rYhzvP8WnS3vNhYJuLfCDlV /nlr4U6B4AkyQIyoWFHvjNn3bFyjH8XrPDHzE+U= X-Google-Smtp-Source: AGHT+IEccR+ch+6Bpf4ueioZ0PgXfplXUF7AWlKJxIQS4x0ObG/yscvNDoElJGtPW6a87MTyMeTVtQ== X-Received: by 2002:a17:90b:5106:b0:2f9:9ddd:68b9 with SMTP id 98e67ed59e1d1-2fce7b1da4amr13812767a91.26.1740300887190; Sun, 23 Feb 2025 00:54:47 -0800 (PST) Received: from thinkpad ([220.158.156.216]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2fcbaaf9785sm6461472a91.1.2025.02.23.00.54.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Feb 2025 00:54:46 -0800 (PST) Date: Sun, 23 Feb 2025 14:24:39 +0530 From: Manivannan Sadhasivam To: Shradha Todi Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, jingoohan1@gmail.com, Jonathan.Cameron@Huawei.com, fan.ni@samsung.com, nifan.cxl@gmail.com, a.manzanares@samsung.com, pankaj.dubey@samsung.com, cassel@kernel.org, 18255117159@163.com, xueshuai@linux.alibaba.com, renyu.zj@linux.alibaba.com, will@kernel.org, mark.rutland@arm.com Subject: Re: [PATCH v7 5/5] Add debugfs based statistical counter support in DWC Message-ID: <20250223085439.esnpificf3xxih56@thinkpad> References: <20250221131548.59616-1-shradha.t@samsung.com> <20250221131548.59616-6-shradha.t@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250221131548.59616-6-shradha.t@samsung.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250223_005447_894743_6BF2D650 X-CRM114-Status: GOOD ( 30.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 21, 2025 at 06:45:48PM +0530, Shradha Todi wrote: > Add support to provide statistical counter interface to userspace. This set > of debug registers are part of the RASDES feature present in DesignWare > PCIe controllers. > > Signed-off-by: Shradha Todi Reviewed-by: Manivannan Sadhasivam - Mani > --- > Documentation/ABI/testing/debugfs-dwc-pcie | 61 +++++ > .../controller/dwc/pcie-designware-debugfs.c | 229 +++++++++++++++++- > 2 files changed, 289 insertions(+), 1 deletion(-) > > diff --git a/Documentation/ABI/testing/debugfs-dwc-pcie b/Documentation/ABI/testing/debugfs-dwc-pcie > index 6ee0897fe753..650a89b0511e 100644 > --- a/Documentation/ABI/testing/debugfs-dwc-pcie > +++ b/Documentation/ABI/testing/debugfs-dwc-pcie > @@ -81,3 +81,64 @@ Description: rasdes_err_inj is the directory which can be used to inject errors > > > Number of errors to be injected > + > +What: /sys/kernel/debug/dwc_pcie_/rasdes_event_counters//counter_enable > +Date: Feburary 2025 > +Contact: Shradha Todi > +Description: rasdes_event_counters is the directory which can be used to collect > + statistical data about the number of times a certain event has occurred > + in the controller. The list of possible events are: > + > + 1) EBUF Overflow > + 2) EBUF Underrun > + 3) Decode Error > + 4) Running Disparity Error > + 5) SKP OS Parity Error > + 6) SYNC Header Error > + 7) Rx Valid De-assertion > + 8) CTL SKP OS Parity Error > + 9) 1st Retimer Parity Error > + 10) 2nd Retimer Parity Error > + 11) Margin CRC and Parity Error > + 12) Detect EI Infer > + 13) Receiver Error > + 14) RX Recovery Req > + 15) N_FTS Timeout > + 16) Framing Error > + 17) Deskew Error > + 18) Framing Error In L0 > + 19) Deskew Uncompleted Error > + 20) Bad TLP > + 21) LCRC Error > + 22) Bad DLLP > + 23) Replay Number Rollover > + 24) Replay Timeout > + 25) Rx Nak DLLP > + 26) Tx Nak DLLP > + 27) Retry TLP > + 28) FC Timeout > + 29) Poisoned TLP > + 30) ECRC Error > + 31) Unsupported Request > + 32) Completer Abort > + 33) Completion Timeout > + 34) EBUF SKP Add > + 35) EBUF SKP Del > + > + (RW) Write 1 to enable the event counter and write 0 to disable the event counter. > + Read will return whether the counter is currently enabled or disabled. Counter is > + disabled by default. > + > +What: /sys/kernel/debug/dwc_pcie_/rasdes_event_counters//counter_value > +Date: Feburary 2025 > +Contact: Shradha Todi > +Description: (RO) Read will return the current value of the event counter. To reset the counter, > + counter should be disabled and enabled back using the 'counter_enable' attribute. > + > +What: /sys/kernel/debug/dwc_pcie_/rasdes_event_counters//lane_select > +Date: Feburary 2025 > +Contact: Shradha Todi > +Description: (RW) Some lanes in the event list are lane specific events. These include > + events 1) - 11) and 34) - 35). > + Write lane number for which counter needs to be enabled/disabled/dumped. > + Read will return the current selected lane number. Lane0 is selected by default. > diff --git a/drivers/pci/controller/dwc/pcie-designware-debugfs.c b/drivers/pci/controller/dwc/pcie-designware-debugfs.c > index b7260edd2336..dca1e9999113 100644 > --- a/drivers/pci/controller/dwc/pcie-designware-debugfs.c > +++ b/drivers/pci/controller/dwc/pcie-designware-debugfs.c > @@ -31,6 +31,17 @@ > > #define ERR_INJ_ENABLE_REG 0x30 > > +#define RAS_DES_EVENT_COUNTER_DATA_REG 0xc > + > +#define RAS_DES_EVENT_COUNTER_CTRL_REG 0x8 > +#define EVENT_COUNTER_GROUP_SELECT GENMASK(27, 24) > +#define EVENT_COUNTER_EVENT_SELECT GENMASK(23, 16) > +#define EVENT_COUNTER_LANE_SELECT GENMASK(11, 8) > +#define EVENT_COUNTER_STATUS BIT(7) > +#define EVENT_COUNTER_ENABLE GENMASK(4, 2) > +#define PER_EVENT_ON 0x3 > +#define PER_EVENT_OFF 0x1 > + > #define DWC_DEBUGFS_BUF_MAX 128 > > /** > @@ -113,6 +124,61 @@ static const u32 err_inj_type_mask[] = { > EINJ5_TYPE, > }; > > +/** > + * struct dwc_pcie_event_counter - Store details about each event counter supported in DWC RASDES > + * @name: Name of the error counter > + * @group_no: Group number that the event belongs to. Value ranges from 0 - 4 > + * @event_no: Event number of the particular event. Value ranges from - > + * Group 0: 0 - 10 > + * Group 1: 5 - 13 > + * Group 2: 0 - 7 > + * Group 3: 0 - 5 > + * Group 4: 0 - 1 > + */ > +struct dwc_pcie_event_counter { > + const char *name; > + u32 group_no; > + u32 event_no; > +}; > + > +static const struct dwc_pcie_event_counter event_list[] = { > + {"ebuf_overflow", 0x0, 0x0}, > + {"ebuf_underrun", 0x0, 0x1}, > + {"decode_err", 0x0, 0x2}, > + {"running_disparity_err", 0x0, 0x3}, > + {"skp_os_parity_err", 0x0, 0x4}, > + {"sync_header_err", 0x0, 0x5}, > + {"rx_valid_deassertion", 0x0, 0x6}, > + {"ctl_skp_os_parity_err", 0x0, 0x7}, > + {"retimer_parity_err_1st", 0x0, 0x8}, > + {"retimer_parity_err_2nd", 0x0, 0x9}, > + {"margin_crc_parity_err", 0x0, 0xA}, > + {"detect_ei_infer", 0x1, 0x5}, > + {"receiver_err", 0x1, 0x6}, > + {"rx_recovery_req", 0x1, 0x7}, > + {"n_fts_timeout", 0x1, 0x8}, > + {"framing_err", 0x1, 0x9}, > + {"deskew_err", 0x1, 0xa}, > + {"framing_err_in_l0", 0x1, 0xc}, > + {"deskew_uncompleted_err", 0x1, 0xd}, > + {"bad_tlp", 0x2, 0x0}, > + {"lcrc_err", 0x2, 0x1}, > + {"bad_dllp", 0x2, 0x2}, > + {"replay_num_rollover", 0x2, 0x3}, > + {"replay_timeout", 0x2, 0x4}, > + {"rx_nak_dllp", 0x2, 0x5}, > + {"tx_nak_dllp", 0x2, 0x6}, > + {"retry_tlp", 0x2, 0x7}, > + {"fc_timeout", 0x3, 0x0}, > + {"poisoned_tlp", 0x3, 0x1}, > + {"ecrc_error", 0x3, 0x2}, > + {"unsupported_request", 0x3, 0x3}, > + {"completer_abort", 0x3, 0x4}, > + {"completion_timeout", 0x3, 0x5}, > + {"ebuf_skp_add", 0x4, 0x0}, > + {"ebuf_skp_del", 0x4, 0x1}, > +}; > + > static ssize_t lane_detect_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) > { > struct dw_pcie *pci = file->private_data; > @@ -230,6 +296,127 @@ static ssize_t err_inj_write(struct file *file, const char __user *buf, size_t c > return count; > } > > +static void set_event_number(struct dwc_pcie_rasdes_priv *pdata, struct dw_pcie *pci, > + struct dwc_pcie_rasdes_info *rinfo) > +{ > + u32 val; > + > + val = dw_pcie_readl_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_CTRL_REG); > + val &= ~EVENT_COUNTER_ENABLE; > + val &= ~(EVENT_COUNTER_GROUP_SELECT | EVENT_COUNTER_EVENT_SELECT); > + val |= FIELD_PREP(EVENT_COUNTER_GROUP_SELECT, event_list[pdata->idx].group_no); > + val |= FIELD_PREP(EVENT_COUNTER_EVENT_SELECT, event_list[pdata->idx].event_no); > + dw_pcie_writel_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_CTRL_REG, val); > +} > + > +static ssize_t counter_enable_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) > +{ > + struct dwc_pcie_rasdes_priv *pdata = file->private_data; > + struct dw_pcie *pci = pdata->pci; > + struct dwc_pcie_rasdes_info *rinfo = pci->debugfs->rasdes_info; > + char debugfs_buf[DWC_DEBUGFS_BUF_MAX]; > + ssize_t pos; > + u32 val; > + > + mutex_lock(&rinfo->reg_event_lock); > + set_event_number(pdata, pci, rinfo); > + val = dw_pcie_readl_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_CTRL_REG); > + mutex_unlock(&rinfo->reg_event_lock); > + val = FIELD_GET(EVENT_COUNTER_STATUS, val); > + if (val) > + pos = scnprintf(debugfs_buf, DWC_DEBUGFS_BUF_MAX, "Counter Enabled\n"); > + else > + pos = scnprintf(debugfs_buf, DWC_DEBUGFS_BUF_MAX, "Counter Disabled\n"); > + > + return simple_read_from_buffer(buf, count, ppos, debugfs_buf, pos); > +} > + > +static ssize_t counter_enable_write(struct file *file, const char __user *buf, > + size_t count, loff_t *ppos) > +{ > + struct dwc_pcie_rasdes_priv *pdata = file->private_data; > + struct dw_pcie *pci = pdata->pci; > + struct dwc_pcie_rasdes_info *rinfo = pci->debugfs->rasdes_info; > + u32 val, enable; > + > + val = kstrtou32_from_user(buf, count, 0, &enable); > + if (val) > + return val; > + > + mutex_lock(&rinfo->reg_event_lock); > + set_event_number(pdata, pci, rinfo); > + val = dw_pcie_readl_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_CTRL_REG); > + if (enable) > + val |= FIELD_PREP(EVENT_COUNTER_ENABLE, PER_EVENT_ON); > + else > + val |= FIELD_PREP(EVENT_COUNTER_ENABLE, PER_EVENT_OFF); > + > + dw_pcie_writel_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_CTRL_REG, val); > + mutex_unlock(&rinfo->reg_event_lock); > + > + return count; > +} > + > +static ssize_t counter_lane_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) > +{ > + struct dwc_pcie_rasdes_priv *pdata = file->private_data; > + struct dw_pcie *pci = pdata->pci; > + struct dwc_pcie_rasdes_info *rinfo = pci->debugfs->rasdes_info; > + char debugfs_buf[DWC_DEBUGFS_BUF_MAX]; > + ssize_t pos; > + u32 val; > + > + mutex_lock(&rinfo->reg_event_lock); > + set_event_number(pdata, pci, rinfo); > + val = dw_pcie_readl_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_CTRL_REG); > + mutex_unlock(&rinfo->reg_event_lock); > + val = FIELD_GET(EVENT_COUNTER_LANE_SELECT, val); > + pos = scnprintf(debugfs_buf, DWC_DEBUGFS_BUF_MAX, "Lane: %d\n", val); > + > + return simple_read_from_buffer(buf, count, ppos, debugfs_buf, pos); > +} > + > +static ssize_t counter_lane_write(struct file *file, const char __user *buf, > + size_t count, loff_t *ppos) > +{ > + struct dwc_pcie_rasdes_priv *pdata = file->private_data; > + struct dw_pcie *pci = pdata->pci; > + struct dwc_pcie_rasdes_info *rinfo = pci->debugfs->rasdes_info; > + u32 val, lane; > + > + val = kstrtou32_from_user(buf, count, 0, &lane); > + if (val) > + return val; > + > + mutex_lock(&rinfo->reg_event_lock); > + set_event_number(pdata, pci, rinfo); > + val = dw_pcie_readl_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_CTRL_REG); > + val &= ~(EVENT_COUNTER_LANE_SELECT); > + val |= FIELD_PREP(EVENT_COUNTER_LANE_SELECT, lane); > + dw_pcie_writel_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_CTRL_REG, val); > + mutex_unlock(&rinfo->reg_event_lock); > + > + return count; > +} > + > +static ssize_t counter_value_read(struct file *file, char __user *buf, size_t count, loff_t *ppos) > +{ > + struct dwc_pcie_rasdes_priv *pdata = file->private_data; > + struct dw_pcie *pci = pdata->pci; > + struct dwc_pcie_rasdes_info *rinfo = pci->debugfs->rasdes_info; > + char debugfs_buf[DWC_DEBUGFS_BUF_MAX]; > + ssize_t pos; > + u32 val; > + > + mutex_lock(&rinfo->reg_event_lock); > + set_event_number(pdata, pci, rinfo); > + val = dw_pcie_readl_dbi(pci, rinfo->ras_cap_offset + RAS_DES_EVENT_COUNTER_DATA_REG); > + mutex_unlock(&rinfo->reg_event_lock); > + pos = scnprintf(debugfs_buf, DWC_DEBUGFS_BUF_MAX, "Counter value: %d\n", val); > + > + return simple_read_from_buffer(buf, count, ppos, debugfs_buf, pos); > +} > + > #define dwc_debugfs_create(name) \ > debugfs_create_file(#name, 0644, rasdes_debug, pci, \ > &dbg_ ## name ## _fops) > @@ -249,6 +436,23 @@ static const struct file_operations dwc_pcie_err_inj_ops = { > .write = err_inj_write, > }; > > +static const struct file_operations dwc_pcie_counter_enable_ops = { > + .open = simple_open, > + .read = counter_enable_read, > + .write = counter_enable_write, > +}; > + > +static const struct file_operations dwc_pcie_counter_lane_ops = { > + .open = simple_open, > + .read = counter_lane_read, > + .write = counter_lane_write, > +}; > + > +static const struct file_operations dwc_pcie_counter_value_ops = { > + .open = simple_open, > + .read = counter_value_read, > +}; > + > static void dwc_pcie_rasdes_debugfs_deinit(struct dw_pcie *pci) > { > struct dwc_pcie_rasdes_info *rinfo = pci->debugfs->rasdes_info; > @@ -258,7 +462,7 @@ static void dwc_pcie_rasdes_debugfs_deinit(struct dw_pcie *pci) > > static int dwc_pcie_rasdes_debugfs_init(struct dw_pcie *pci, struct dentry *dir) > { > - struct dentry *rasdes_debug, *rasdes_err_inj; > + struct dentry *rasdes_debug, *rasdes_err_inj, *rasdes_event_counter, *rasdes_events; > struct dwc_pcie_rasdes_info *rasdes_info; > struct dwc_pcie_rasdes_priv *priv_tmp; > struct device *dev = pci->dev; > @@ -277,6 +481,7 @@ static int dwc_pcie_rasdes_debugfs_init(struct dw_pcie *pci, struct dentry *dir) > /* Create subdirectories for Debug, Error injection, Statistics */ > rasdes_debug = debugfs_create_dir("rasdes_debug", dir); > rasdes_err_inj = debugfs_create_dir("rasdes_err_inj", dir); > + rasdes_event_counter = debugfs_create_dir("rasdes_event_counter", dir); > > mutex_init(&rasdes_info->reg_event_lock); > rasdes_info->ras_cap_offset = ras_cap; > @@ -299,6 +504,28 @@ static int dwc_pcie_rasdes_debugfs_init(struct dw_pcie *pci, struct dentry *dir) > debugfs_create_file(err_inj_list[i].name, 0200, rasdes_err_inj, priv_tmp, > &dwc_pcie_err_inj_ops); > } > + > + /* Create debugfs files for Statistical counter subdirectory */ > + for (i = 0; i < ARRAY_SIZE(event_list); i++) { > + priv_tmp = devm_kzalloc(dev, sizeof(*priv_tmp), GFP_KERNEL); > + if (!priv_tmp) { > + ret = -ENOMEM; > + goto err_deinit; > + } > + > + priv_tmp->idx = i; > + priv_tmp->pci = pci; > + rasdes_events = debugfs_create_dir(event_list[i].name, rasdes_event_counter); > + if (event_list[i].group_no == 0 || event_list[i].group_no == 4) { > + debugfs_create_file("lane_select", 0644, rasdes_events, > + priv_tmp, &dwc_pcie_counter_lane_ops); > + } > + debugfs_create_file("counter_value", 0444, rasdes_events, priv_tmp, > + &dwc_pcie_counter_value_ops); > + debugfs_create_file("counter_enable", 0644, rasdes_events, priv_tmp, > + &dwc_pcie_counter_enable_ops); > + } > + > return 0; > > err_deinit: > -- > 2.17.1 > -- மணிவண்ணன் சதாசிவம்