From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9F66C021A4 for ; Mon, 24 Feb 2025 18:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pC6o0YRw4Cq9mwJe3XI9Hc69xoJLRhFW95eup2iayaI=; b=m2zbbavz2t6WIYpui+oMuQ3XDl R/NGwh5DYbj2CPOr4UJu9yKG2KfRa1gmmX7HMKSrAO7brvkz/Qt+Vw5+YfwWysws59aCVhOwV1w6E cP+C0w/LWIlHg+AhAYamVIHQfKa+aH/ISlYnI2DZKfOGqVV6zHSnssPj7EIk1UMuTI0Pbfu7txMRN nMJ32G8UaDGK6tugKU/kwfxe91dkpudZFnixa3jpXikFA4dBy2PggrQyeOdHmH1frfO5dfMM1RRL2 ramxEDy3tkkkibaY0A4X8cVvWHFNz/2op7gv0i5e8JRSa3J9OmQ3AjyXtQAthjjrHa2vvCX8ckwno FB5vKkBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tmcka-0000000EiUH-1kqD; Mon, 24 Feb 2025 18:00:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tmchJ-0000000EhwO-371l for linux-arm-kernel@lists.infradead.org; Mon, 24 Feb 2025 17:56:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7991B152B; Mon, 24 Feb 2025 09:57:06 -0800 (PST) Received: from donnerap.manchester.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4D9C63F5A1; Mon, 24 Feb 2025 09:56:46 -0800 (PST) Date: Mon, 24 Feb 2025 17:56:42 +0000 From: Andre Przywara To: Ryan Walklin Cc: Maxime Ripard , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Chris Morgan , Hironori KIKUCHI , Philippe Simons , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, Conor Dooley Subject: Re: [PATCH v7 22/27] dt-bindings: allwinner: add H616 DE33 mixer binding Message-ID: <20250224175642.170c124e@donnerap.manchester.arm.com> In-Reply-To: <20250216183710.8443-23-ryan@testtoast.com> References: <20250216183710.8443-3-ryan@testtoast.com> <20250216183710.8443-23-ryan@testtoast.com> Organization: ARM X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250224_095653_871167_840ACEF6 X-CRM114-Status: GOOD ( 19.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 17 Feb 2025 07:36:22 +1300 Ryan Walklin wrote: Hi, > The Allwinner H616 and variants have a new display engine revision > (DE33). > > The mixer configuration registers are significantly different to the DE3 > and DE2 revisions, being split into separate top and display blocks, > therefore a fallback for the mixer compatible is not provided. > > Add a display engine mixer binding for the DE33. > > Signed-off-by: Ryan Walklin > Acked-by: Conor Dooley > Reviewed-by: Chen-Yu Tsai > > --- > Changelog v2..v3: > - Separate content into three patches for three separate subsystems > > Changelog v5..v6: > - increase reg maxItems to 3 and add conditional for h616-de33 > --- > .../allwinner,sun8i-a83t-de2-mixer.yaml | 21 ++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > index b75c1ec686ad2..274f5e6327333 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > @@ -24,9 +24,11 @@ properties: > - allwinner,sun50i-a64-de2-mixer-0 > - allwinner,sun50i-a64-de2-mixer-1 > - allwinner,sun50i-h6-de3-mixer-0 > + - allwinner,sun50i-h616-de33-mixer-0 > > reg: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 What are those three regions? I wonder if we should have reg-names here, to fix the order, and to document them on the way? > > clocks: > items: > @@ -61,6 +63,23 @@ properties: > required: > - port@1 > > +allOf: > + - if: > + properties: > + compatible: > + enum: > + - allwinner,sun50i-h616-de33-mixer-0 > + > + then: > + properties: > + reg: > + maxItems: 3 Should we override minItems here as well? I guess any driver would need all three region to work? Cheers, Andre > + > + else: > + properties: > + reg: > + maxItems: 1 > + > required: > - compatible > - reg