From: Cosmin Tanislav <demonsingur@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>,
Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Naushir Patuck <naush@raspberrypi.com>,
Benjamin Mugnier <benjamin.mugnier@foss.st.com>,
linux-media@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Cosmin Tanislav <demonsingur@gmail.com>
Subject: [PATCH] media: platform: rpi1-cfe: fix pad in call to get_mbus_config()
Date: Tue, 25 Feb 2025 23:20:30 +0200 [thread overview]
Message-ID: <20250225212031.188987-1-demonsingur@gmail.com> (raw)
The source subdevice might be using a source pad not equal to 0.
Use the already existing source_pad field of cfe.
Fixes: e7bad98c205d ("media: v4l: Convert the users of v4l2_get_link_freq to call it on a pad")
Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
---
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
index 69a5f23e7954..7db4fe5e0fd4 100644
--- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
+++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
@@ -1206,8 +1206,8 @@ static int cfe_start_streaming(struct vb2_queue *vq, unsigned int count)
cfg_reg_write(cfe, MIPICFG_INTE,
MIPICFG_INT_CSI_DMA | MIPICFG_INT_PISP_FE);
- ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config, 0,
- &mbus_config);
+ ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config,
+ cfe->source_pad, &mbus_config);
if (ret < 0 && ret != -ENOIOCTLCMD) {
cfe_err(cfe, "g_mbus_config failed\n");
goto err_clear_inte;
--
2.48.1
next reply other threads:[~2025-02-25 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 21:20 Cosmin Tanislav [this message]
2025-02-25 21:25 ` [PATCH] media: platform: rpi1-cfe: fix pad in call to get_mbus_config() Cosmin Tanislav
2025-04-03 11:07 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250225212031.188987-1-demonsingur@gmail.com \
--to=demonsingur@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=benjamin.mugnier@foss.st.com \
--cc=florian.fainelli@broadcom.com \
--cc=hverkuil@xs4all.nl \
--cc=kernel-list@raspberrypi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=naush@raspberrypi.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox