* [PATCH] media: platform: rpi1-cfe: fix pad in call to get_mbus_config()
@ 2025-02-25 21:20 Cosmin Tanislav
2025-02-25 21:25 ` Cosmin Tanislav
0 siblings, 1 reply; 3+ messages in thread
From: Cosmin Tanislav @ 2025-02-25 21:20 UTC (permalink / raw)
Cc: Tomi Valkeinen, Raspberry Pi Kernel Maintenance,
Mauro Carvalho Chehab, Florian Fainelli,
Broadcom internal kernel review list, Hans Verkuil, Sakari Ailus,
Naushir Patuck, Benjamin Mugnier, linux-media, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, Cosmin Tanislav
The source subdevice might be using a source pad not equal to 0.
Use the already existing source_pad field of cfe.
Fixes: e7bad98c205d ("media: v4l: Convert the users of v4l2_get_link_freq to call it on a pad")
Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
---
drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
index 69a5f23e7954..7db4fe5e0fd4 100644
--- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
+++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
@@ -1206,8 +1206,8 @@ static int cfe_start_streaming(struct vb2_queue *vq, unsigned int count)
cfg_reg_write(cfe, MIPICFG_INTE,
MIPICFG_INT_CSI_DMA | MIPICFG_INT_PISP_FE);
- ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config, 0,
- &mbus_config);
+ ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config,
+ cfe->source_pad, &mbus_config);
if (ret < 0 && ret != -ENOIOCTLCMD) {
cfe_err(cfe, "g_mbus_config failed\n");
goto err_clear_inte;
--
2.48.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] media: platform: rpi1-cfe: fix pad in call to get_mbus_config()
2025-02-25 21:20 [PATCH] media: platform: rpi1-cfe: fix pad in call to get_mbus_config() Cosmin Tanislav
@ 2025-02-25 21:25 ` Cosmin Tanislav
2025-04-03 11:07 ` Tomi Valkeinen
0 siblings, 1 reply; 3+ messages in thread
From: Cosmin Tanislav @ 2025-02-25 21:25 UTC (permalink / raw)
Cc: Tomi Valkeinen, Raspberry Pi Kernel Maintenance,
Mauro Carvalho Chehab, Florian Fainelli,
Broadcom internal kernel review list, Hans Verkuil, Sakari Ailus,
Naushir Patuck, Benjamin Mugnier, linux-media, linux-rpi-kernel,
linux-arm-kernel, linux-kernel
On 2/25/25 11:20 PM, Cosmin Tanislav wrote:
> The source subdevice might be using a source pad not equal to 0.
>
> Use the already existing source_pad field of cfe.
>
> Fixes: e7bad98c205d ("media: v4l: Convert the users of v4l2_get_link_freq to call it on a pad")
I used the wrong Fixes tag, this is the correct one:
Fixes: 6edb685abb2a ("media: raspberrypi: Add support for RP1-CFE")
> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
> ---
> drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> index 69a5f23e7954..7db4fe5e0fd4 100644
> --- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> +++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
> @@ -1206,8 +1206,8 @@ static int cfe_start_streaming(struct vb2_queue *vq, unsigned int count)
> cfg_reg_write(cfe, MIPICFG_INTE,
> MIPICFG_INT_CSI_DMA | MIPICFG_INT_PISP_FE);
>
> - ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config, 0,
> - &mbus_config);
> + ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config,
> + cfe->source_pad, &mbus_config);
> if (ret < 0 && ret != -ENOIOCTLCMD) {
> cfe_err(cfe, "g_mbus_config failed\n");
> goto err_clear_inte;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] media: platform: rpi1-cfe: fix pad in call to get_mbus_config()
2025-02-25 21:25 ` Cosmin Tanislav
@ 2025-04-03 11:07 ` Tomi Valkeinen
0 siblings, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2025-04-03 11:07 UTC (permalink / raw)
To: Cosmin Tanislav
Cc: Raspberry Pi Kernel Maintenance, Mauro Carvalho Chehab,
Florian Fainelli, Broadcom internal kernel review list,
Hans Verkuil, Sakari Ailus, Naushir Patuck, Benjamin Mugnier,
linux-media, linux-rpi-kernel, linux-arm-kernel, linux-kernel
Hi,
On 25/02/2025 23:25, Cosmin Tanislav wrote:
>
>
> On 2/25/25 11:20 PM, Cosmin Tanislav wrote:
>> The source subdevice might be using a source pad not equal to 0.
>>
>> Use the already existing source_pad field of cfe.
>>
>> Fixes: e7bad98c205d ("media: v4l: Convert the users of
>> v4l2_get_link_freq to call it on a pad")
>
> I used the wrong Fixes tag, this is the correct one:
> Fixes: 6edb685abb2a ("media: raspberrypi: Add support for RP1-CFE")
>
>> Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
>> ---
>> drivers/media/platform/raspberrypi/rp1-cfe/cfe.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c b/
>> drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
>> index 69a5f23e7954..7db4fe5e0fd4 100644
>> --- a/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
>> +++ b/drivers/media/platform/raspberrypi/rp1-cfe/cfe.c
>> @@ -1206,8 +1206,8 @@ static int cfe_start_streaming(struct vb2_queue
>> *vq, unsigned int count)
>> cfg_reg_write(cfe, MIPICFG_INTE,
>> MIPICFG_INT_CSI_DMA | MIPICFG_INT_PISP_FE);
>> - ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config, 0,
>> - &mbus_config);
>> + ret = v4l2_subdev_call(cfe->source_sd, pad, get_mbus_config,
>> + cfe->source_pad, &mbus_config);
>> if (ret < 0 && ret != -ENOIOCTLCMD) {
>> cfe_err(cfe, "g_mbus_config failed\n");
>> goto err_clear_inte;
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Please send a v2 with corrected description.
Tomi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-04-03 11:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-25 21:20 [PATCH] media: platform: rpi1-cfe: fix pad in call to get_mbus_config() Cosmin Tanislav
2025-02-25 21:25 ` Cosmin Tanislav
2025-04-03 11:07 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox