From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF104C021B2 for ; Wed, 26 Feb 2025 01:55:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=WEgQbAyN812Od1PLDKL03NyhRQA8kQhgcIrLRcSGxlQ=; b=UhnenxUQTG27PF ypHfXl+T9Ldy8AP5VJfwFT/JqSSA27hn+GqN+rF4iNfmXG5BU/aut7/wN7uqd/oVtauZNOGKesKYS vradp9Ic3R7tW9x8kaUIw6qvgTCa2UpvCBggmSSczk8tD7JCz1W3TaTkxa6pBbdv8VbqR5ceOj+iD mwfdCyE4aOTQk6uV59bpjqgVbi9sXiA3Fu0jq68OUxFO+DtQXOOSzaWn8PuxW0xjMdM0vnObvazIV orp3eh9pVAp3Nl7JbvURCdxC8H68u/pBQcuER7L1eqAjgmu5A+GHjHVzIzPfuLxKGT/3KRgPdd+pI NLzk5pdJoCX8hkGbW76A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tn6e8-000000023Rt-2Gj9; Wed, 26 Feb 2025 01:55:36 +0000 Received: from mail-pl1-x649.google.com ([2607:f8b0:4864:20::649]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tn6cb-000000023F9-2Rb9 for linux-arm-kernel@lists.infradead.org; Wed, 26 Feb 2025 01:54:02 +0000 Received: by mail-pl1-x649.google.com with SMTP id d9443c01a7336-220d8599659so115989405ad.0 for ; Tue, 25 Feb 2025 17:54:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1740534840; x=1741139640; darn=lists.infradead.org; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date:from:to :cc:subject:date:message-id:reply-to; bh=WEgQbAyN812Od1PLDKL03NyhRQA8kQhgcIrLRcSGxlQ=; b=byxFdDOxZwJWNimAgp5tisBHznaFweaX2B+5Sc2jD8pn/2a9DHyoF3Y6W5+YZcG9Z9 RPQ52/Px9K/1NTDIWFcMQ9Yvea4T1zC32l0lxDBONVpMRLFJoS3hmRTHdA4BdaDJipwp 8mUG7rKP5+N9Xjs+NHC/A0dVcApKBemIol7++C7oA3KFWDYZmANPxkuQjR6sk4tOJ5hM yxcKUD/Skl2HMWW96NDrQF5PYorO/HrUzY7Z2uCsXy4KeXQrTYv+8XFywQXvlzL5njBo l/QQ4WR30n7SWdl8rYXv9zo8HXdsxvjLvz+O6Pa+CuPYx0hskEBH45Rx7sdAhrVCFeNH RxaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740534840; x=1741139640; h=cc:to:from:subject:message-id:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WEgQbAyN812Od1PLDKL03NyhRQA8kQhgcIrLRcSGxlQ=; b=XfpVRHKc7+dRsTzfpif8hz4/lQbBsYcO+2xpqZomDbfhAPVRrwgIYEQPp0WhwlW4r8 2c98jY9I/FNjxDoOkco5N4RZKx7oHOCIb6UEDdHG3tKv/9Eugv+NUjHHbD2YYdeMZyJP TcX4Kk+OvgacWrLjqyEIW6r6vvjgmBkBrBaJDORSBKVNPAJ37PmpuZr0MOiFKCD+/MZT LmSJJ59i0Z1yYSSe/NiO02LRYD+N4aelLbW74YJCFGIxIFp4S2RnXEr7txG6ZgmDLK2k JcGWXeESe5JfQpalqGEbxIgGC+6ExN5k2f1V/da/IwQLW/BpLbQJwJ7hbdeUMydq5GRL 1w0g== X-Forwarded-Encrypted: i=1; AJvYcCUl9llSyxEv7KLuceszvXcOAAPkJqU9eQjxIA8zaa7T9gXVmE4j+umk8xxJ/iw3kHorUiG1Nxuxb1i3WNzP5Yfr@lists.infradead.org X-Gm-Message-State: AOJu0YxLh1LPzsQ3mHkqYOT3PTSjDkVq2pLlY93iEScmVuEzRW9zcPc9 TTqR8C+9zXOElce5dBWRPhNjWMwm+Ep9XpVQO/tMT6WjFgBCHXZt7/l9eeLeLqIpKHwliMdHKUG tg3lqK+5ueBDYcdn1BQ== X-Google-Smtp-Source: AGHT+IFkznZMkNBk5de2vOfANCIGfGmFUq4ZoIai/G7n3JkeCyYN8XDtQ2NLIWeTlmgvn0M2N7vBP6JVrlIIeeRX X-Received: from pfbna17.prod.google.com ([2002:a05:6a00:3e11:b0:732:502c:4a0f]) (user=changyuanl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:2e1e:b0:725:df1a:285 with SMTP id d2e1a72fcca58-7348bdd003bmr2703166b3a.12.1740534840070; Tue, 25 Feb 2025 17:54:00 -0800 (PST) Date: Tue, 25 Feb 2025 17:53:39 -0800 In-Reply-To: <20250206132754.2596694-3-rppt@kernel.org> Mime-Version: 1.0 X-Mailer: git-send-email 2.48.1.711.g2feabab25a-goog Message-ID: <20250226015342.2136669-1-changyuanl@google.com> Subject: Re: [PATCH v4 02/14] memblock: add MEMBLOCK_RSRV_KERN flag From: Changyuan Lyu To: Mike Rapoport Cc: Changyuan Lyu , Alexander Graf , Andrew Morton , Andy Lutomirski , Anthony Yznaga , Arnd Bergmann , Ashish Kalra , Benjamin Herrenschmidt , Borislav Petkov , Catalin Marinas , Dave Hansen , David Woodhouse , Eric Biederman , Ingo Molnar , James Gowans , Jonathan Corbet , Krzysztof Kozlowski , Mark Rutland , Paolo Bonzini , Pasha Tatashin , "H. Peter Anvin" , Peter Zijlstra , Pratyush Yadav , Rob Herring , Rob Herring , Saravana Kannan , Stanislav Kinsburskii , Steven Rostedt , Thomas Gleixner , Tom Lendacky , Usama Arif , Will Deacon , devicetree@vger.kernel.org, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250225_175401_619585_8898FBE4 X-CRM114-Status: GOOD ( 18.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mike, On Thu, 6 Feb 2025 15:27:42 +0200, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > to denote areas that were reserved for kernel use either directly with > memblock_reserve_kern() or via memblock allocations. > > Signed-off-by: Mike Rapoport (Microsoft) > --- > include/linux/memblock.h | 16 +++++++++++++++- > mm/memblock.c | 32 ++++++++++++++++++++++++-------- > 2 files changed, 39 insertions(+), 9 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index e79eb6ac516f..65e274550f5d 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > ...... > @@ -116,7 +117,19 @@ int memblock_add_node(phys_addr_t base, phys_addr_t size, int nid, > int memblock_add(phys_addr_t base, phys_addr_t size); > int memblock_remove(phys_addr_t base, phys_addr_t size); > int memblock_phys_free(phys_addr_t base, phys_addr_t size); > -int memblock_reserve(phys_addr_t base, phys_addr_t size); > +int __memblock_reserve(phys_addr_t base, phys_addr_t size, int nid, > + enum memblock_flags flags); > + > +static __always_inline int memblock_reserve(phys_addr_t base, phys_addr_t size) > +{ > + return __memblock_reserve(base, size, NUMA_NO_NODE, 0); Without this patch `memblock_reserve` eventually calls `memblock_add_range` with `MAX_NUMNODES`, but with this patch, `memblock_reserve` calls `memblock_add_range` with `NUMA_NO_NODE`. Is it intended or an accidental typo? Thanks! > ...... > > -int __init_memblock memblock_reserve(phys_addr_t base, phys_addr_t size) > +int __init_memblock __memblock_reserve(phys_addr_t base, phys_addr_t size, > + int nid, enum memblock_flags flags) > { > phys_addr_t end = base + size - 1; > > - memblock_dbg("%s: [%pa-%pa] %pS\n", __func__, > - &base, &end, (void *)_RET_IP_); > + memblock_dbg("%s: [%pa-%pa] nid=%d flags=%x %pS\n", __func__, > + &base, &end, nid, flags, (void *)_RET_IP_); > > - return memblock_add_range(&memblock.reserved, base, size, MAX_NUMNODES, 0); Originally `memblock_reserve` calls `memblock_add_range` with `MAX_NUMNODES`, See my comments above. Best, Changyuan