[PATCH 0/3] imx8qxp: PCIe fixes

[PATCH 0/3] imx8qxp: PCIe fixes

[Alexander Stein]

Hi all,

my series at [1] introduced some dtbs_check warnings for imx8qm based platforms,
highlighted by Frank [2]. This series fixes the problem by updating the schema
for allowing an optional DMA interrupt and adding the DMA interrupt for imx8qm.
Also a non-upstream property is removed as well.

Best regards,
Alexander

[1] https://lore.kernel.org/all/20250107140110.982215-1-alexander.stein@ew.tq-group.com/
[2] https://lore.kernel.org/all/Z7yxDRO+ICPCu0I2@lizhi-Precision-Tower-5810/

Alexander Stein (3):
  dt-bindings: PCI: fsl,imx6q-pcie: Add optional DMA interrupt
  arm64: dts: imx8qm-ss-hsio: Wire up DMA IRQ for PCIe
  arm64: dts: mba8xx: Remove invalid propert

 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++
 arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi         | 5 +++--
 arch/arm64/boot/dts/freescale/mba8xx.dtsi                 | 1 -
 3 files changed, 7 insertions(+), 3 deletions(-)

-- 
2.43.0

[PATCH 1/3] dt-bindings: PCI: fsl,imx6q-pcie: Add optional DMA interrupt

[Alexander Stein]

i.MX8QM and i.MX8QXP/DXP have an additional interrupt for DMA.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 4c76cd3f98a9c..ca5f2970f217c 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -47,12 +47,16 @@ properties:
     maxItems: 5
 
   interrupts:
+    minItems: 1
     items:
       - description: builtin MSI controller.
+      - description: builtin DMA controller.
 
   interrupt-names:
+    minItems: 1
     items:
       - const: msi
+      - const: dma
 
   reset-gpio:
     description: Should specify the GPIO for controlling the PCI bus device
-- 
2.43.0

Re: [PATCH 1/3] dt-bindings: PCI: fsl,imx6q-pcie: Add optional DMA interrupt

[Frank Li]

On Tue, Feb 25, 2025 at 11:27:21AM +0100, Alexander Stein wrote:
> i.MX8QM and i.MX8QXP/DXP have an additional interrupt for DMA.

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 4c76cd3f98a9c..ca5f2970f217c 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -47,12 +47,16 @@ properties:
>      maxItems: 5
>
>    interrupts:
> +    minItems: 1
>      items:
>        - description: builtin MSI controller.
> +      - description: builtin DMA controller.
>
>    interrupt-names:
> +    minItems: 1
>      items:
>        - const: msi
> +      - const: dma
>
>    reset-gpio:
>      description: Should specify the GPIO for controlling the PCI bus device
> --
> 2.43.0
>

Re: [PATCH 1/3] dt-bindings: PCI: fsl,imx6q-pcie: Add optional DMA interrupt

[Rob Herring (Arm)]

On Tue, 25 Feb 2025 11:27:21 +0100, Alexander Stein wrote:
> i.MX8QM and i.MX8QXP/DXP have an additional interrupt for DMA.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH 1/3] dt-bindings: PCI: fsl,imx6q-pcie: Add optional DMA interrupt

[Krzysztof Wilczyński]

Hello,

> i.MX8QM and i.MX8QXP/DXP have an additional interrupt for DMA.

Applied to dt-bindings, thank you!

	Krzysztof

[PATCH 2/3] arm64: dts: imx8qm-ss-hsio: Wire up DMA IRQ for PCIe

[Alexander Stein]

IRQ mapping is already present. Add the missing DMA interrupt. This is
similar to commit 9d9c56025e429 ("arm64: dts: imx8-ss-hsio: Wire up DMA
IRQ for PCIe")

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi
index d52609e4fc455..e80f722dbe65f 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi
@@ -69,8 +69,9 @@ pcieb: pcie@5f010000 {
 		ranges = <0x81000000 0 0x00000000 0x8ff80000 0 0x00010000>,
 			 <0x82000000 0 0x80000000 0x80000000 0 0x0ff00000>;
 		#interrupt-cells = <1>;
-		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
-		interrupt-names = "msi";
+		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
+			     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "msi", "dma";
 		#address-cells = <3>;
 		#size-cells = <2>;
 		clocks = <&pcieb_lpcg IMX_LPCG_CLK_6>,
-- 
2.43.0

Re: [PATCH 2/3] arm64: dts: imx8qm-ss-hsio: Wire up DMA IRQ for PCIe

[Frank Li]

On Tue, Feb 25, 2025 at 11:27:22AM +0100, Alexander Stein wrote:
> IRQ mapping is already present. Add the missing DMA interrupt. This is
> similar to commit 9d9c56025e429 ("arm64: dts: imx8-ss-hsio: Wire up DMA
> IRQ for PCIe")

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi
> index d52609e4fc455..e80f722dbe65f 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-hsio.dtsi
> @@ -69,8 +69,9 @@ pcieb: pcie@5f010000 {
>  		ranges = <0x81000000 0 0x00000000 0x8ff80000 0 0x00010000>,
>  			 <0x82000000 0 0x80000000 0x80000000 0 0x0ff00000>;
>  		#interrupt-cells = <1>;
> -		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
> -		interrupt-names = "msi";
> +		interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> +			     <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> +		interrupt-names = "msi", "dma";
>  		#address-cells = <3>;
>  		#size-cells = <2>;
>  		clocks = <&pcieb_lpcg IMX_LPCG_CLK_6>,
> --
> 2.43.0
>

[PATCH 3/3] arm64: dts: mba8xx: Remove invalid propert

[Alexander Stein]

disable-gpio is an (old) downstream kernel property, which slipped into
DT. Remove it.

Fixes: c01a26b8897a ("arm64: dts: mba8xx: Add PCIe support")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/mba8xx.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
index 117f657283191..c4b5663949ade 100644
--- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
@@ -328,7 +328,6 @@ &pcieb {
 	pinctrl-0 = <&pinctrl_pcieb>;
 	pinctrl-names = "default";
 	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
-	disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;
 	vpcie-supply = <&reg_pcie_1v5>;
 	status = "okay";
 };
-- 
2.43.0

Re: [PATCH 3/3] arm64: dts: mba8xx: Remove invalid propert

[Frank Li]

On Tue, Feb 25, 2025 at 11:27:23AM +0100, Alexander Stein wrote:
> disable-gpio is an (old) downstream kernel property, which slipped into
> DT. Remove it.
>
> Fixes: c01a26b8897a ("arm64: dts: mba8xx: Add PCIe support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  arch/arm64/boot/dts/freescale/mba8xx.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> index 117f657283191..c4b5663949ade 100644
> --- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> @@ -328,7 +328,6 @@ &pcieb {
>  	pinctrl-0 = <&pinctrl_pcieb>;
>  	pinctrl-names = "default";
>  	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
> -	disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;
>  	vpcie-supply = <&reg_pcie_1v5>;
>  	status = "okay";
>  };
> --
> 2.43.0
>

Re: [PATCH 3/3] arm64: dts: mba8xx: Remove invalid propert

[Bjorn Helgaas]

Subject line could include 'disable-gpio'

And s/propert/property/

On Tue, Feb 25, 2025 at 11:27:23AM +0100, Alexander Stein wrote:
> disable-gpio is an (old) downstream kernel property, which slipped into
> DT. Remove it.

I guess the implication is that the driver has never used this.

> Fixes: c01a26b8897a ("arm64: dts: mba8xx: Add PCIe support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/mba8xx.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> index 117f657283191..c4b5663949ade 100644
> --- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> @@ -328,7 +328,6 @@ &pcieb {
>  	pinctrl-0 = <&pinctrl_pcieb>;
>  	pinctrl-names = "default";
>  	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
> -	disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;
>  	vpcie-supply = <&reg_pcie_1v5>;
>  	status = "okay";
>  };
> -- 
> 2.43.0
> 

Re: [PATCH 0/3] imx8qxp: PCIe fixes

[Shawn Guo]

On Tue, Feb 25, 2025 at 11:27:20AM +0100, Alexander Stein wrote:
> Alexander Stein (3):
>   dt-bindings: PCI: fsl,imx6q-pcie: Add optional DMA interrupt
>   arm64: dts: imx8qm-ss-hsio: Wire up DMA IRQ for PCIe
>   arm64: dts: mba8xx: Remove invalid propert

s/propert/property as Bjorn suggested, then applied both DTS changes.

Shawn