Re: [PATCH v11 3/4] arm64: topology: Support SMT control on ACPI based system

Dietmar Eggemann
2025-02-28T11:58:20Z

On 18/02/2025 15:10, Yicong Yang wrote:
> From: Yicong Yang <yangyicong@hisilicon.com>

[...]

> @@ -67,6 +108,31 @@ int __init parse_acpi_topology(void)
> cpu_topology[cpu].package_id = topology_id;
> }
>
> + /*
> + * This should be a short loop depending on the number of heterogeneous
^^^^^^

This _is_ a short loop since the number of xArray elements is the number
of heterogeneous CPU clusters.

> + * CPU clusters. Typically on a homogeneous system there's only one
^^^^^^^^^

I would remove 'Typically' here. …