From: Peng Fan <peng.fan@oss.nxp.com>
To: Rob Herring <robh@kernel.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
saravanak@google.com, cristian.marussi@arm.com,
krzk+dt@kernel.org, conor+dt@kernel.org,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Peng Fan <peng.fan@nxp.com>
Subject: Re: [RFC] dt-bindings: firmware: scmi: Introduce compatible string
Date: Mon, 3 Mar 2025 12:35:51 +0800 [thread overview]
Message-ID: <20250303043551.GE13236@nxa18884-linux> (raw)
In-Reply-To: <CAL_JsqLePri5m_dE989poUV4auasAxFvgAiYuXVuZHqLcOBGMg@mail.gmail.com>
Hi Rob,
On Fri, Feb 28, 2025 at 08:17:03AM -0600, Rob Herring wrote:
>On Fri, Feb 28, 2025 at 8:04 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>>
>> On Fri, Feb 28, 2025 at 07:34:09AM -0600, Rob Herring wrote:
>> >
>> > - The parent driver creates child devices. The child devices can
>> > either reuse the parent DT node (i.e. set dev.of_node) or just get it
>> > from the parent device if needed.
>> >
>>
>> This is exactly what I was thinking to deal with the issue since this
>> discussion started. I will give this a go. I believe this must solve
>> the issue, but I didn't want to spit it out loud until I tried to hack
>> and check.
>
>The issue with fw_devlink is that it only checks the dependency of the
>parent which won't be enough. When the parent's probe creates the
>child device, that doesn't mean the child has probed. The child driver
>might not be loaded and/or probe is async. I don't think there's
>anyway for the parent probe to wait for child drivers to be probed and
Please forgive if my understanding is wrong.
Based on device tree, there is fwnode link created using fwnode_link_add,
then in device_add, the fw_devlink_link_device will do the device supplier
and consumer link. It is just device level link, not related to child's probe.
So if child device(work as supplier) is created only when a prarent's probe
done, the consumer of the child device will not have link ready and consumer
device's driver will not probe until the child device created and probe done.
Thanks,
Peng
>ready. I think there's similar issues with the DWC3 wrapper and core
>driver split.
>
>Rob
next prev parent reply other threads:[~2025-03-03 3:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 9:44 [RFC] dt-bindings: firmware: scmi: Introduce compatible string Peng Fan (OSS)
2025-02-26 16:09 ` Rob Herring
2025-02-26 17:19 ` Sudeep Holla
2025-02-27 3:15 ` Peng Fan
2025-02-27 9:12 ` Sudeep Holla
2025-02-27 3:09 ` Peng Fan
2025-02-28 13:34 ` Rob Herring
2025-02-28 14:04 ` Sudeep Holla
2025-02-28 14:17 ` Rob Herring
2025-03-03 4:35 ` Peng Fan [this message]
2025-02-27 11:48 ` Cristian Marussi
2025-03-03 4:27 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250303043551.GE13236@nxa18884-linux \
--to=peng.fan@oss.nxp.com \
--cc=arm-scmi@vger.kernel.org \
--cc=conor+dt@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).