From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5996EC021B8 for ; Tue, 4 Mar 2025 09:29:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VVdgqlh0SzmC+6JtX2Rnms+TFQupvOwx3xiR/mL96FA=; b=xb/FqCVCQT/BxldE5H8y0n3YLW k/GLVHtDYmdXP5TV/sVXwKjgaRTCLhP0Rr/WdwKBZvzOfsVPBcPVjhqUm4NmTBo5BtF7h9UxAOsgh qXpcwHfqpjlqzD4ooPXwx2efL5lkhihalAErTvQ35f+oic6c8fb0MAY75akr9rceJp96EZ9MxRm5L N9LCFI+TZ1XCPvjcSVzKDZChmG5k7aHLdpc0z9a4jSCT+/mCIMY+1DmYDUq3rgrOtWeu1r9R9MQRi Ic4/b8JhXFeQUsmpp9oZszzh/Ef7uyiM6vqREGkqcIflxAn+/FWTnocxDMua6JJghnmRSg1FzJ5ui 9BxhZqqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpOaP-00000003tAD-2Hi2; Tue, 04 Mar 2025 09:29:13 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpOYM-00000003sl9-2LBI for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 09:27:07 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Z6Vb23t4cz6L5Hk; Tue, 4 Mar 2025 17:22:54 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id F17961402C7; Tue, 4 Mar 2025 17:26:56 +0800 (CST) Received: from localhost (10.96.237.92) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 4 Mar 2025 10:26:54 +0100 Date: Tue, 4 Mar 2025 17:26:49 +0800 From: Jonathan Cameron To: Yicong Yang CC: , , , , , , , Subject: Re: [PATCH 2/9] drivers/perf: hisi: Simplify the probe process for each DDRC version Message-ID: <20250304172649.0000189c@huawei.com> In-Reply-To: <20250218092000.41641-3-yangyicong@huawei.com> References: <20250218092000.41641-1-yangyicong@huawei.com> <20250218092000.41641-3-yangyicong@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.96.237.92] X-ClientProxiedBy: lhrpeml500010.china.huawei.com (7.191.174.240) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_012706_741210_103A7B90 X-CRM114-Status: UNSURE ( 9.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 18 Feb 2025 17:19:53 +0800 Yicong Yang wrote: > From: Junhao He > > Version 1 and 2 of DDRC PMU also use different HID. Make use of > struct acpi_device_id::driver_data for version specific information > rather than judge the version register. This will help to > simplify the probe process and also a bit easier for extension. > > Signed-off-by: Junhao He > Signed-off-by: Yicong Yang Looks good to me. Looking at this I can see the check_reg naming is an existing thing so maybe leave that alone for now and consider renaming as a future improvement in readability. Reviewed-by: Jonathan Cameron