From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C993C282D9 for ; Tue, 4 Mar 2025 10:35:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=emGD7/DjavP8gl0VSIRBTfQdgyRXT19xKjqnnN89KNw=; b=QjwlpJPq70c5NxiE1IMEOL/D+q GVFBHHEKxwSrg/Tbza009e+WcRaR0h01f4s9P8PuZsgjzmtSHPS6oZMrfYdrDeb8rBl2IlWxlK2eL eXSyVEpkh6o41bn/ueUa4rHWsAoAijrDpfqJzoE+sAYG5DlUAqYwdBYY4gi0kSWeujn+za5Sgyyrp 0G0ut01DAcXLElYDxyHzaug0lWntOyjW4CswALmX5/L6cWsY1971/nJz3poX0GLkE/EyA98Yzvps7 5Rs/11R5BWhSLf/v3Ph7tOFvFN5P+aJat3I9kkfABMfKWkeYvKXltZtOJK7AiufjKYMDPo9nfb8Mj LdPYuIfA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tpPcX-00000004AsQ-3oVI; Tue, 04 Mar 2025 10:35:29 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tpP5L-000000042zp-01ay for linux-arm-kernel@lists.infradead.org; Tue, 04 Mar 2025 10:01:13 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Z6WLL5yYVz6L4tC; Tue, 4 Mar 2025 17:56:58 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 72CDE1402C7; Tue, 4 Mar 2025 18:01:01 +0800 (CST) Received: from localhost (10.96.237.92) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 4 Mar 2025 11:00:58 +0100 Date: Tue, 4 Mar 2025 18:00:54 +0800 From: Jonathan Cameron To: Yicong Yang CC: , , , , , , , Subject: Re: [PATCH 4/9] drivers/perf: hisi: Use ACPI driver_data to retrieve SLLC PMU information Message-ID: <20250304180054.00001ffc@huawei.com> In-Reply-To: <20250218092000.41641-5-yangyicong@huawei.com> References: <20250218092000.41641-1-yangyicong@huawei.com> <20250218092000.41641-5-yangyicong@huawei.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.96.237.92] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250304_020111_196127_6F418F38 X-CRM114-Status: GOOD ( 13.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 18 Feb 2025 17:19:55 +0800 Yicong Yang wrote: > From: Junhao He > > Make use of struct acpi_device_id::driver_data for version specific > information rather than judge the version register. This will help > to simplify the probe process and also a bit easier for extension. > > Factor out SLLC register definition to struct hisi_sllc_pmu_regs. > No functional changes intended. > > Signed-off-by: Junhao He > Signed-off-by: Yicong Yang > --- > drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c | 191 ++++++++++++------ > 1 file changed, 125 insertions(+), 66 deletions(-) > > diff --git a/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c b/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c > index dbd079016fc4..c1fd60d397c3 100644 > --- a/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c > +++ b/drivers/perf/hisilicon/hisi_uncore_sllc_pmu.c > @@ -36,11 +36,14 @@ > #define SLLC_SRCID_NONE 0x0 > #define SLLC_TGTID_EN BIT(5) > #define SLLC_TGTID_NONE 0x0 > -#define SLLC_TGTID_MIN_SHIFT 1 > -#define SLLC_TGTID_MAX_SHIFT 12 > -#define SLLC_SRCID_CMD_SHIFT 1 > -#define SLLC_SRCID_MSK_SHIFT 12 > +#define SLLC_TGTID_MIN_MSK GENMASK(11, 1) > +#define SLLC_TGTID_MAX_MSK GENMASK(22, 12) > +#define SLLC_SRCID_CMD_MSK GENMASK(11, 1) > +#define SLLC_SRCID_MSK_MSK GENMASK(22, 12) > #define SLLC_NR_EVENTS 0x80 > +#define SLLC_EVENT_CNTn(cnt0, n) ((cnt0) + (n) * 8) > +#define SLLC_FIRST_BIT(_mask) (find_first_bit((const unsigned long *)&(_mask), 32)) If you do end up keeping this, I think there should be no need for outer brackets here. > +#define SLLC_FIELD_PREP(_mask, _val) (_mask & (_val << SLLC_FIRST_BIT(_mask)))