From: Eric Biggers <ebiggers@kernel.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: alim.akhtar@samsung.com, James.Bottomley@hansenpartnership.com,
martin.petersen@oracle.com, krzk@kernel.org,
linux-scsi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, willmcvicker@google.com,
tudor.ambarus@linaro.org, andre.draszik@linaro.org,
bvanassche@acm.org, kernel-team@android.com
Subject: Re: [PATCH 4/6] scsi: ufs: exynos: Enable PRDT pre-fetching with UFSHCD_CAP_CRYPTO
Date: Tue, 4 Mar 2025 18:40:20 -0800 [thread overview]
Message-ID: <20250305024020.GC20133@sol.localdomain> (raw)
In-Reply-To: <20250226220414.343659-5-peter.griffin@linaro.org>
On Wed, Feb 26, 2025 at 10:04:12PM +0000, Peter Griffin wrote:
> PRDT_PREFETCH_ENABLE[31] bit should be set when desctype field of
> fmpsecurity0 register is type2 (double file encryption) or type3
> (file and disk excryption). Setting this bit enables PRDT
> pre-fetching on both TXPRDT and RXPRDT.
>
> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
I assume you mean that desctype 3 provides "support for file and disk
encryption"? The driver does use desctype 3, but it only uses the "file
encryption". So this confused me a bit. (BTW, in FMP terminology, "file
encryption" seems to mean "use the key provided in the I/O request", and "disk
encryption" seems to mean "use some key the firmware provided somehow". They
can be cascaded, and the intended use cases are clearly file and disk encryption
respectively, but they don't necessarily have to be used that way.)
- Eric
next prev parent reply other threads:[~2025-03-05 4:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 22:04 [PATCH 0/6] ufs-exynos fixes for gs101 Peter Griffin
2025-02-26 22:04 ` [PATCH 1/6] scsi: ufs: exynos: ensure pre_link() executes before exynos_ufs_phy_init() Peter Griffin
2025-02-26 22:04 ` [PATCH 2/6] scsi: ufs: exynos: move ufs shareability value to drvdata Peter Griffin
2025-02-26 22:04 ` [PATCH 3/6] scsi: ufs: exynos: ensure consistent phy reference counts Peter Griffin
2025-02-26 22:04 ` [PATCH 4/6] scsi: ufs: exynos: Enable PRDT pre-fetching with UFSHCD_CAP_CRYPTO Peter Griffin
2025-02-28 19:18 ` Bart Van Assche
2025-03-04 11:49 ` Peter Griffin
2025-03-05 2:40 ` Eric Biggers [this message]
2025-03-07 15:10 ` Peter Griffin
2025-02-26 22:04 ` [PATCH 5/6] scsi: ufs: exynos: Move phy calls to .exit() callback Peter Griffin
2025-02-28 19:20 ` Bart Van Assche
2025-03-04 11:10 ` Peter Griffin
2025-02-26 22:04 ` [PATCH 6/6] scsi: ufs: exynos: put ufs device in reset on .exit() and .suspend() Peter Griffin
2025-02-28 19:21 ` Bart Van Assche
2025-03-04 11:37 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305024020.GC20133@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=bvanassche@acm.org \
--cc=kernel-team@android.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=peter.griffin@linaro.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox