From: Jason Gunthorpe <jgg@nvidia.com>
To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@huawei.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>,
"will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"joro@8bytes.org" <joro@8bytes.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 4/4] iommu/arm-smmu-v3-iommufd: Allow a shared s2_parent to allocate vSMMU
Date: Wed, 5 Mar 2025 12:57:43 -0400 [thread overview]
Message-ID: <20250305165743.GA133783@nvidia.com> (raw)
In-Reply-To: <1b51a7f7bfc0419b8941cf7ee0601b70@huawei.com>
On Wed, Mar 05, 2025 at 09:01:40AM +0000, Shameerali Kolothum Thodi wrote:
> > if (!(smmu->features & ARM_SMMU_FEAT_NESTING))
> > return ERR_PTR(-EOPNOTSUPP);
> >
> > - if (s2_parent->smmu != master->smmu)
> > - return ERR_PTR(-EINVAL);
> > -
>
> Not sure we can just relax this like this. What if the two physical SMMUs are different in
> functionality/features? Do we need some kind of sanity check here?
Yes, a function to check if a domain's iopgtbl config is compatible
with the instance is required.
Jason
next prev parent reply other threads:[~2025-03-05 17:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 5:03 [PATCH v1 0/4] iommu/arm-smmu-v3: Allocate vmid per vsmmu instead of s2_parent Nicolin Chen
2025-03-05 5:04 ` [PATCH v1 1/4] iommu/arm-smmu-v3: Pass in vmid to arm_smmu_make_s2_domain_ste() Nicolin Chen
2025-03-05 8:50 ` Shameerali Kolothum Thodi
2025-03-05 17:44 ` Nicolin Chen
2025-04-07 8:37 ` Pranjal Shrivastava
2025-03-05 16:55 ` Jason Gunthorpe
2025-04-07 8:32 ` Pranjal Shrivastava
2025-03-05 5:04 ` [PATCH v1 2/4] iommu/arm-smmu-v3: Share arm_smmu_cmdq_issue_cmd_with_sync() with vsmmu Nicolin Chen
2025-04-07 8:43 ` Pranjal Shrivastava
2025-03-05 5:04 ` [PATCH v1 3/4] iommu/arm-smmu-v3: Decouple vmid from S2 nest_parent domain Nicolin Chen
2025-03-05 17:01 ` Jason Gunthorpe
2025-03-05 18:45 ` Nicolin Chen
2025-04-07 10:51 ` Pranjal Shrivastava
2025-04-07 16:52 ` Jason Gunthorpe
2025-04-08 14:20 ` Pranjal Shrivastava
2025-04-15 0:05 ` Nicolin Chen
2025-03-05 5:04 ` [PATCH v1 4/4] iommu/arm-smmu-v3-iommufd: Allow a shared s2_parent to allocate vSMMU Nicolin Chen
2025-03-05 9:01 ` Shameerali Kolothum Thodi
2025-03-05 16:57 ` Jason Gunthorpe [this message]
2025-03-05 17:49 ` Nicolin Chen
2025-03-05 16:54 ` [PATCH v1 0/4] iommu/arm-smmu-v3: Allocate vmid per vsmmu instead of s2_parent Jason Gunthorpe
2025-03-05 18:23 ` Nicolin Chen
2025-03-05 18:31 ` Jason Gunthorpe
2025-03-05 18:51 ` Nicolin Chen
2025-03-05 19:29 ` Jason Gunthorpe
2025-03-05 19:46 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250305165743.GA133783@nvidia.com \
--to=jgg@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).