From: Jakub Kicinski <kuba@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: claudiu.manoil@nxp.com, vladimir.oltean@nxp.com,
xiaoning.wang@nxp.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
christophe.leroy@csgroup.eu, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 net-next 06/13] net: enetc: add RSS support for i.MX95 ENETC PF
Date: Thu, 6 Mar 2025 14:34:27 -0800 [thread overview]
Message-ID: <20250306143427.2bf83572@kernel.org> (raw)
In-Reply-To: <20250304072201.1332603-7-wei.fang@nxp.com>
On Tue, 4 Mar 2025 15:21:54 +0800 Wei Fang wrote:
> Add Receive side scaling (RSS) support for i.MX95 ENETC PF to improve
> the network performance and balance the CPU loading. The main changes
> are as follows.
>
> 1. Since i.MX95 ENETC (v4) use NTMP 2.0 to manage the RSS table, which
> is different from LS1028A ENETC (v1). In order to reuse some functions
> related to the RSS table, so add .get_rss_table() and .set_rss_table()
> hooks to enetc_si_ops.
>
> 2. Since the offset of the RSS key registers of i.MX95 ENETC is also
> different from that of LS1028A, so add enetc_get_rss_key_base() to get
> the base offset for the different chips, so that enetc_set_rss_key()
> and enetc_get_rss_key() can be reused for this trivial.
Please split this patch into refactoring of existing code and new
additions.
next prev parent reply other threads:[~2025-03-06 22:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 7:21 [PATCH v3 net-next 00/13] Add more feautues for ENETC v4 - round 2 Wei Fang
2025-03-04 7:21 ` [PATCH v3 net-next 01/13] net: enetc: add initial netc-lib driver to support NTMP Wei Fang
2025-03-06 22:28 ` Jakub Kicinski
2025-03-07 1:47 ` Wei Fang
2025-03-08 2:05 ` Wei Fang
2025-03-08 2:59 ` Jakub Kicinski
2025-03-08 6:58 ` Wei Fang
2025-03-04 7:21 ` [PATCH v3 net-next 02/13] net: enetc: add command BD ring support for i.MX95 ENETC Wei Fang
2025-03-04 7:21 ` [PATCH v3 net-next 03/13] net: enetc: move generic MAC filterng interfaces to enetc-core Wei Fang
2025-03-04 7:21 ` [PATCH v3 net-next 04/13] net: enetc: add MAC filter for i.MX95 ENETC PF Wei Fang
2025-03-06 14:29 ` Paolo Abeni
2025-03-07 1:22 ` Wei Fang
2025-03-04 7:21 ` [PATCH v3 net-next 05/13] net: enetc: add debugfs interface to dump MAC filter Wei Fang
2025-03-04 7:21 ` [PATCH v3 net-next 06/13] net: enetc: add RSS support for i.MX95 ENETC PF Wei Fang
2025-03-06 22:34 ` Jakub Kicinski [this message]
2025-03-04 7:21 ` [PATCH v3 net-next 07/13] net: enetc: check if the RSS hfunc is toeplitz Wei Fang
2025-03-06 22:35 ` Jakub Kicinski
2025-03-04 7:21 ` [PATCH v3 net-next 08/13] net: enetc: enable RSS feature by default Wei Fang
2025-03-04 7:21 ` [PATCH v3 net-next 09/13] net: enetc: move generic VLAN filter interfaces to enetc-core Wei Fang
2025-03-04 7:21 ` [PATCH v3 net-next 10/13] net: enetc: move generic VLAN hash filter functions to enetc_pf_common.c Wei Fang
2025-03-04 7:21 ` [PATCH v3 net-next 11/13] net: enetc: add VLAN filtering support for i.MX95 ENETC PF Wei Fang
2025-03-04 7:22 ` [PATCH v3 net-next 12/13] net: enetc: add loopback " Wei Fang
2025-03-04 7:22 ` [PATCH v3 net-next 13/13] MAINTAINERS: add new file ntmp.h to ENETC driver Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250306143427.2bf83572@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).