From: Stefan Wahren <wahrenst@gmx.net>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Umang Jain <umang.jain@ideasonboard.com>,
Ojaswin Mujoo <ojaswin98@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
kernel-list@raspberrypi.com, linux-staging@lists.linux.dev,
Stefan Wahren <wahrenst@gmx.net>
Subject: [PATCH 1/5] staging: vchiq_arm: Register debugfs after cdev
Date: Sun, 9 Mar 2025 13:50:10 +0100 [thread overview]
Message-ID: <20250309125014.37166-2-wahrenst@gmx.net> (raw)
In-Reply-To: <20250309125014.37166-1-wahrenst@gmx.net>
The commit 2a4d15a4ae98 ("staging: vchiq: Refactor vchiq cdev code")
moved the debugfs directory creation before vchiq character device
registration. In case the latter fails, the debugfs directory won't
be cleaned up.
Fixes: 2a4d15a4ae98 ("staging: vchiq: Refactor vchiq cdev code")
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index a4e83e5d619b..e2e80e90b555 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1386,8 +1386,6 @@ static int vchiq_probe(struct platform_device *pdev)
return ret;
}
- vchiq_debugfs_init(&mgmt->state);
-
dev_dbg(&pdev->dev, "arm: platform initialised - version %d (min %d)\n",
VCHIQ_VERSION, VCHIQ_VERSION_MIN);
@@ -1401,6 +1399,8 @@ static int vchiq_probe(struct platform_device *pdev)
return ret;
}
+ vchiq_debugfs_init(&mgmt->state);
+
bcm2835_audio = vchiq_device_register(&pdev->dev, "bcm2835-audio");
bcm2835_camera = vchiq_device_register(&pdev->dev, "bcm2835-camera");
--
2.34.1
next prev parent reply other threads:[~2025-03-09 12:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 12:50 [PATCH 0/5] staging: vchiq_arm: Fix & improve resource handling Stefan Wahren
2025-03-09 12:50 ` Stefan Wahren [this message]
2025-03-09 12:50 ` [PATCH 2/5] staging: vchiq_arm: Fix possible NPR of keep-alive thread Stefan Wahren
2025-03-09 12:50 ` [PATCH 3/5] staging: vchiq_arm: Stop kthreads if vchiq cdev register fails Stefan Wahren
2025-03-09 12:50 ` [PATCH 4/5] staging: vchiq_arm: Create keep-alive thread during probe Stefan Wahren
2025-06-26 18:22 ` Maíra Canal
2025-06-26 20:14 ` Stefan Wahren
2025-06-26 20:30 ` Maíra Canal
2025-06-27 15:18 ` Stefan Wahren
2025-06-27 22:28 ` Maíra Canal
2025-06-28 22:34 ` Stefan Wahren
2025-08-24 18:37 ` MichaIng
2025-08-24 19:58 ` Stefan Wahren
2025-08-24 20:14 ` MichaIng
2025-03-09 12:50 ` [PATCH 5/5] staging: vchiq_arm: Improve initial VCHIQ connect Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250309125014.37166-2-wahrenst@gmx.net \
--to=wahrenst@gmx.net \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.carpenter@linaro.org \
--cc=florian.fainelli@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-list@raspberrypi.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=ojaswin98@gmail.com \
--cc=umang.jain@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox