From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>, Marek Vasut <marex@denx.de>,
Stefan Agner <stefan@agner.ch>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Inki Dae <inki.dae@samsung.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Cc: "Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Anusha Srivatsa" <asrivats@redhat.com>,
"Paul Kocialkowski" <paulk@sys-base.io>,
"Dmitry Baryshkov" <lumag@kernel.org>,
"Hervé Codina" <herve.codina@bootlin.com>,
"Hui Pu" <Hui.Pu@gehealthcare.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>
Subject: [PATCH v7 05/11] drm/bridge: add a cleanup action for scope-based drm_bridge_put() invocation
Date: Fri, 14 Mar 2025 11:31:18 +0100 [thread overview]
Message-ID: <20250314-drm-bridge-refcount-v7-5-152571f8c694@bootlin.com> (raw)
In-Reply-To: <20250314-drm-bridge-refcount-v7-0-152571f8c694@bootlin.com>
Many functions get a drm_bridge pointer, only use it in the function body
(or a smaller scope such as a loop body), and don't store it. In these
cases they always need to drm_bridge_put() it before returning (or exiting
the scope).
Some of those functions have complex code paths with multiple return points
or loop break/continue. This makes adding drm_bridge_put() in the right
places tricky, ugly and error prone in case of future code changes.
Others use the bridge pointer in the return statement and would need to
split the return line to fit the drm_bridge_put, which is a bit annoying:
-return some_thing(bridge);
+ret = some_thing(bridge);
+drm_bridge_put(bridge);
+return ret;
To make it easier for all of them to put the bridge reference correctly
without complicating code, define a scope-based cleanup action to be used
with __free().
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
---
This patch was added in v7.
---
include/drm/drm_bridge.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h
index 5c1e2b9cafb12eb429d1f5d3ef312e6cf9b54f47..a5accd64c364ebb57903ae1e7459034ad9ebf4f3 100644
--- a/include/drm/drm_bridge.h
+++ b/include/drm/drm_bridge.h
@@ -23,6 +23,7 @@
#ifndef __DRM_BRIDGE_H__
#define __DRM_BRIDGE_H__
+#include <linux/cleanup.h>
#include <linux/ctype.h>
#include <linux/list.h>
#include <linux/mutex.h>
@@ -995,6 +996,9 @@ static inline struct drm_bridge *drm_bridge_put(struct drm_bridge *bridge)
return bridge;
}
+/* Cleanup action for use with __free() */
+DEFINE_FREE(drm_bridge_put, struct drm_bridge *, if (_T) drm_bridge_put(_T))
+
void drm_bridge_put_void(void *data);
/**
--
2.48.1
next prev parent reply other threads:[~2025-03-14 10:42 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-14 10:31 [PATCH v7 00/11] drm/bridge: add devm_drm_bridge_alloc() with bridge refcount Luca Ceresoli
2025-03-14 10:31 ` [PATCH v7 01/11] drm/bridge: add devm_drm_bridge_alloc() Luca Ceresoli
2025-03-14 17:58 ` Maxime Ripard
2025-03-14 10:31 ` [PATCH v7 02/11] drm/bridge: add support for refcounting Luca Ceresoli
2025-03-14 18:04 ` Maxime Ripard
2025-03-17 14:56 ` Luca Ceresoli
2025-03-14 10:31 ` [PATCH v7 03/11] drm/bridge: get/put the bridge reference in drm_bridge_add/remove() Luca Ceresoli
2025-03-14 18:04 ` Maxime Ripard
2025-03-14 10:31 ` [PATCH v7 04/11] drm/bridge: get/put the bridge reference in drm_bridge_attach/detach() Luca Ceresoli
2025-03-14 18:05 ` Maxime Ripard
2025-03-14 10:31 ` Luca Ceresoli [this message]
2025-03-14 18:08 ` [PATCH v7 05/11] drm/bridge: add a cleanup action for scope-based drm_bridge_put() invocation Maxime Ripard
2025-03-17 14:57 ` Luca Ceresoli
2025-03-14 10:31 ` [PATCH v7 06/11] drm/bridge: get the bridge returned by drm_bridge_chain_get_first_bridge() Luca Ceresoli
2025-03-14 18:10 ` Maxime Ripard
2025-03-17 14:57 ` Luca Ceresoli
2025-03-14 10:31 ` [PATCH v7 07/11] drm/mxsfb: put " Luca Ceresoli
2025-03-14 18:11 ` Maxime Ripard
2025-03-14 10:31 ` [PATCH v7 08/11] drm/atomic-helper: " Luca Ceresoli
2025-03-14 18:12 ` Maxime Ripard
2025-03-14 10:31 ` [PATCH v7 09/11] drm/probe-helper: " Luca Ceresoli
2025-03-14 18:12 ` Maxime Ripard
2025-03-14 10:31 ` [PATCH v7 10/11] drm/bridge: ti-sn65dsi83: use dynamic lifetime management Luca Ceresoli
2025-03-14 18:17 ` Maxime Ripard
2025-03-14 10:31 ` [PATCH v7 11/11] drm/bridge: samsung-dsim: " Luca Ceresoli
2025-03-14 18:18 ` Maxime Ripard
2025-03-14 18:21 ` [PATCH v7 00/11] drm/bridge: add devm_drm_bridge_alloc() with bridge refcount Maxime Ripard
2025-03-17 14:56 ` Luca Ceresoli
2025-03-19 16:16 ` Maxime Ripard
2025-03-20 7:41 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250314-drm-bridge-refcount-v7-5-152571f8c694@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=Hui.Pu@gehealthcare.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=asrivats@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=imx@lists.linux.dev \
--cc=inki.dae@samsung.com \
--cc=jagan@amarulasolutions.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marex@denx.de \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=paulk@sys-base.io \
--cc=rfoss@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=stefan@agner.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).