* [PATCH] reset: imx: fix incorrect module device table
@ 2025-03-14 15:35 Arnd Bergmann
2025-03-14 16:05 ` Philipp Zabel
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-03-14 15:35 UTC (permalink / raw)
To: Philipp Zabel, Shawn Guo, Sascha Hauer, Frank Li
Cc: Arnd Bergmann, Pengutronix Kernel Team, Fabio Estevam, imx,
linux-arm-kernel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The ID table is for of_device_id, not platform_device_id:
ERROR: modpost: drivers/reset/reset-imx-scu: type mismatch between imx_scu_reset_ids[] and MODULE_DEVICE_TABLE(platform, ...)
Fixes: 6b64fde5c183 ("reset: imx: Add SCU reset driver for i.MX8QXP and i.MX8QM")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/reset/reset-imx-scu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/reset/reset-imx-scu.c b/drivers/reset/reset-imx-scu.c
index d3074eaad4c9..919fc29f944c 100644
--- a/drivers/reset/reset-imx-scu.c
+++ b/drivers/reset/reset-imx-scu.c
@@ -85,7 +85,7 @@ static const struct of_device_id imx_scu_reset_ids[] = {
{ .compatible = "fsl,imx-scu-reset", },
{}
};
-MODULE_DEVICE_TABLE(platform, imx_scu_reset_ids);
+MODULE_DEVICE_TABLE(of, imx_scu_reset_ids);
static struct platform_driver imx_scu_reset_driver = {
.probe = imx_scu_reset_probe,
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] reset: imx: fix incorrect module device table
2025-03-14 15:35 [PATCH] reset: imx: fix incorrect module device table Arnd Bergmann
@ 2025-03-14 16:05 ` Philipp Zabel
0 siblings, 0 replies; 2+ messages in thread
From: Philipp Zabel @ 2025-03-14 16:05 UTC (permalink / raw)
To: Arnd Bergmann, Shawn Guo, Sascha Hauer, Frank Li
Cc: Arnd Bergmann, Pengutronix Kernel Team, Fabio Estevam, imx,
linux-arm-kernel, linux-kernel
On Fr, 2025-03-14 at 16:35 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The ID table is for of_device_id, not platform_device_id:
>
> ERROR: modpost: drivers/reset/reset-imx-scu: type mismatch between imx_scu_reset_ids[] and MODULE_DEVICE_TABLE(platform, ...)
>
> Fixes: 6b64fde5c183 ("reset: imx: Add SCU reset driver for i.MX8QXP and i.MX8QM")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to reset/next, thanks!
[1/1] reset: imx: fix incorrect module device table
https://git.pengutronix.de/cgit/pza/linux/commit/?id=c361baf67200
regards
Philipp
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-03-14 16:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-14 15:35 [PATCH] reset: imx: fix incorrect module device table Arnd Bergmann
2025-03-14 16:05 ` Philipp Zabel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).