From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7FE4C282EC for ; Mon, 17 Mar 2025 22:13:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=Cd2YVIf3qYiOe0Rh/SuiWgEq0K1c1TdKIwXCuKbHvYI=; b=Sdxr8uCSCYn4GU 0EQcIMzFdnAMueezS3/tUD3iBYR0TAKhaR9RE4A10U1c3pnMbOipH0EP1Hv/0OL9Tdasne1JRNb8t y0D/q5Qy3INCJu2hDQlZ/ZqqpYiqEuu7ggE201H1OL9BTQV7PaSc/ty1RaqMJDzXabPRzA41Nq0kH cqzdXwS7RqRBZieUm2Iz+YTkXHik/yRpaG/b191GzTHGgbBT/dTphwv9qoX5ansPzDyA1ac0kAkW6 lFA6T5/0tL9vrN6ZD4JWH+HohugvepXxxHrqrIr86C0RIWC1WjH7u+jyUNJfy/DpBqdMPN2ShLMUA 6gNbK0MEVJQlJGvtbo4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuIiQ-0000000466h-3DAA; Mon, 17 Mar 2025 22:13:46 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tuIgk-000000045tj-2Vq7 for linux-arm-kernel@lists.infradead.org; Mon, 17 Mar 2025 22:12:03 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 242F25C5730; Mon, 17 Mar 2025 22:09:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CCC2C4CEE3; Mon, 17 Mar 2025 22:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742249521; bh=JEdZ8g1iC7LvD0mCARyJ8WNae6kxKED75zVQlYCHfjg=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Zk11OSnmRIHe1gd+qJ9NrAMljHh+/a/ZiBfI7D7Qjd6Sb4UVTyl5AqAOgX1u+yorY 0lP7AxucUDDi9vYR52g1jtp+qhrCJVTD/n3duivvfyuNR4zi4V3ZyatQU67KtkHOwa yM+8fi1hSeGTfUVr2qKob17ces1ehwWrTIfDeQrJN7i8zratTI1tvK0h0+rE0gMplU TwvOB5I4p3GnjJkUotzsf0MNR1tweERRcH+lekiTra0tGkNv0tRDf5M/rQm4ImEpT3 lNzNHfAwZBEHqMXBg7Mvy5LN3lWqD5VkwwCqkR0imtuhLCB+j7ST32TmPizFtD8i6l MVVyg/Le2JilA== Date: Mon, 17 Mar 2025 17:12:00 -0500 From: Bjorn Helgaas To: Frank Li Cc: Rob Herring , Saravana Kannan , Jingoo Han , Manivannan Sadhasivam , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Fabio Estevam , Niklas Cassel , Pengutronix Kernel Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, Bjorn Helgaas Subject: Re: [PATCH v12 00/13] PCI: Use device bus range info to cleanup RC Host/EP pci_fixup_addr() Message-ID: <20250317221200.GA975949@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250315201548.858189-1-helgaas@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250317_151202_745917_4F00FE10 X-CRM114-Status: GOOD ( 16.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Mar 15, 2025 at 03:15:35PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > This is a v12 based on Frank's v11 series. > > v11 https://lore.kernel.org/r/20250313-pci_fixup_addr-v11-0-01d2313502ab@nxp.com > > Changes from v11: > - Call devm_pci_alloc_host_bridge() early in dw_pcie_host_init(), before > any devicetree-related code > - Call devm_pci_epc_create() early in dw_pcie_ep_init(), before any > devicetree-related code > - Consolidate devicetree-related code in dw_pcie_host_get_resources() and > dw_pcie_ep_get_resources() > - Integrate dw_pcie_cfg0_setup() into dw_pcie_host_get_resources() > - Convert dw_pcie_init_parent_bus_offset() to dw_pcie_parent_bus_offset() > which returns the offset rather than setting it internally > - Split the debug comparison of devicetree info with .cpu_addr_fixup() to > separate patch so we can easily revert it later > - Drop "cpu_addr_fixup() usage detected" warning since we always warn > about something in that case anyway > > Any comments welcome. > > > Bjorn Helgaas (3): > PCI: dwc: Consolidate devicetree handling in > dw_pcie_host_get_resources() > PCI: dwc: ep: Call epc_create() early in dw_pcie_ep_init() > PCI: dwc: ep: Consolidate devicetree handling in > dw_pcie_ep_get_resources() > > Frank Li (10): > PCI: dwc: Use resource start as iomap() input in > dw_pcie_pme_turn_off() > PCI: dwc: Rename cpu_addr to parent_bus_addr for ATU configuration > PCI: dwc: Call devm_pci_alloc_host_bridge() early in > dw_pcie_host_init() > PCI: dwc: Add dw_pcie_parent_bus_offset() > PCI: dwc: Add dw_pcie_parent_bus_offset() checking and debug > PCI: dwc: Use devicetree 'reg[config]' to derive CPU -> ATU addr > offset > PCI: dwc: ep: Use devicetree 'reg[addr_space]' to derive CPU -> ATU > addr offset > PCI: dwc: ep: Ensure proper iteration over outbound map windows > PCI: dwc: Use parent_bus_offset to remove need for .cpu_addr_fixup() > PCI: imx6: Remove cpu_addr_fixup() > > drivers/pci/controller/dwc/pci-imx6.c | 18 +--- > .../pci/controller/dwc/pcie-designware-ep.c | 74 +++++++++++------ > .../pci/controller/dwc/pcie-designware-host.c | 57 ++++++++----- > drivers/pci/controller/dwc/pcie-designware.c | 82 ++++++++++++++----- > drivers/pci/controller/dwc/pcie-designware.h | 24 +++++- > 5 files changed, 171 insertions(+), 84 deletions(-) Applied to pci/controller/dwc-cpu-addr-fixup for v6.15. Thank you very much, Frank, for all your hard work on driving this series! I think this is a major improvement.