From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0B79C28B28 for ; Tue, 18 Mar 2025 07:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=XUxU6JIqlPthBK/qLkde7SD61X0GZkgbE6F2VVDgg+Y=; b=lpxGlwXFWCwZ6LDoInz7xXYgCP kgU48WoVStZhduRcTcLf7pTxc//k1/pRQL7OywLbm6iYj+XbfKGV0toVv0A/5ZrSVQKX9JpaIUPj8 6iXBCh4zM9uKmaE89iZIZrUu+zLqjXcdvkZLTzi4wevsBSEJ3tKf6HgmF+JvXRBavwuOIUk9T6D8S yR0MSajmBtSlgTiakkdy6d0N5eJlm1onIh4fgDJCe+KlalEtwZvQI4PpGi9rN4a4KR1MCh/kX7bT5 Pnk+HZFJzTMHa5qBSF6S070dgVksxaEk7EzhdGvEHFt0K0CPiuJX84+LxRcUhAFlej2q8X5Eco90I MdyjSFrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tuRqN-000000053tI-1IKY; Tue, 18 Mar 2025 07:58:35 +0000 Received: from fllvem-ot03.ext.ti.com ([198.47.19.245]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tuRnk-000000053JC-2bbi for linux-arm-kernel@lists.infradead.org; Tue, 18 Mar 2025 07:55:54 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllvem-ot03.ext.ti.com (8.15.2/8.15.2) with ESMTPS id 52I7tXJP2533552 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Mar 2025 02:55:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1742284533; bh=XUxU6JIqlPthBK/qLkde7SD61X0GZkgbE6F2VVDgg+Y=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=QNRcJzBHHj4VsJWRWtyQ8zYYJ9hfBGOYs8A5nrPiYHZU7SkuBzatVCwSRSva7zX1E JBeq6x/+sICyz82/tp01Efn1yDOPU92IolB2tcOMP96Q4BcHDGpwK5cwNLLKGFHXe8 PdmDjs/5Tkl5QYdFb+iwocQH2TS8tBFAf2k5sHg4= Received: from DLEE104.ent.ti.com (dlee104.ent.ti.com [157.170.170.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 52I7tWvk023106 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 18 Mar 2025 02:55:33 -0500 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Tue, 18 Mar 2025 02:55:32 -0500 Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Tue, 18 Mar 2025 02:55:32 -0500 Received: from localhost (uda0492258.dhcp.ti.com [10.24.72.113]) by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 52I7tVjr004880; Tue, 18 Mar 2025 02:55:31 -0500 Date: Tue, 18 Mar 2025 13:25:30 +0530 From: Siddharth Vadapalli To: Manivannan Sadhasivam CC: Siddharth Vadapalli , , , , , , , , , , , , , , , Subject: Re: [PATCH 1/4] PCI: cadence: Add support to build pcie-cadence library as a kernel module Message-ID: <20250318075530.ca663uwlj7uqf2tr@uda0492258> References: <20250307103128.3287497-1-s-vadapalli@ti.com> <20250307103128.3287497-2-s-vadapalli@ti.com> <20250313174416.n3c4srf6hb2l3bvg@thinkpad> <20250314065444.fmvhyqmuefnm4mcq@uda0492258> <20250318074917.inhspuuypxmaioqe@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20250318074917.inhspuuypxmaioqe@thinkpad> X-C2ProcessedOrg: 333ef613-75bf-4e12-a4b1-8e3623f5dcea X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250318_005552_845839_7E6D37EE X-CRM114-Status: GOOD ( 31.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 18, 2025 at 01:19:17PM +0530, Manivannan Sadhasivam wrote: > On Fri, Mar 14, 2025 at 12:24:44PM +0530, Siddharth Vadapalli wrote: > > On Thu, Mar 13, 2025 at 11:14:16PM +0530, Manivannan Sadhasivam wrote: > > > > Hello Mani, > > > > > On Fri, Mar 07, 2025 at 04:01:25PM +0530, Siddharth Vadapalli wrote: > > > > From: Kishon Vijay Abraham I > > > > > > > > Currently, the Cadence PCIe controller driver can be built as a built-in > > > > module only. Since PCIe functionality is not a necessity for booting, add > > > > support to build the Cadence PCIe driver as a loadable module as well. > > > > > > > > Signed-off-by: Kishon Vijay Abraham I > > > > Signed-off-by: Siddharth Vadapalli > > > > > > Reviewed-by: Manivannan Sadhasivam > > > > > > > --- > > > > drivers/pci/controller/cadence/Kconfig | 6 +++--- > > > > drivers/pci/controller/cadence/pcie-cadence-ep.c | 6 ++++++ > > > > drivers/pci/controller/cadence/pcie-cadence-host.c | 9 +++++++++ > > > > drivers/pci/controller/cadence/pcie-cadence.c | 12 ++++++++++++ > > > > drivers/pci/controller/cadence/pcie-cadence.h | 4 ++-- > > > > 5 files changed, 32 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/drivers/pci/controller/cadence/Kconfig b/drivers/pci/controller/cadence/Kconfig > > > > index 8a0044bb3989..82b58096eea0 100644 > > > > --- a/drivers/pci/controller/cadence/Kconfig > > > > +++ b/drivers/pci/controller/cadence/Kconfig > > > > @@ -4,16 +4,16 @@ menu "Cadence-based PCIe controllers" > > > > depends on PCI > > > > > > > > config PCIE_CADENCE > > > > - bool > > > > + tristate > > > > > > > > config PCIE_CADENCE_HOST > > > > - bool > > > > + tristate > > > > depends on OF > > > > select IRQ_DOMAIN > > > > > > Even though this was added earlier, looks like not needed. > > > > Thank you for reviewing this patch. > > > > drivers/pci/controller/cadence/Kconfig has the following: > > ... > > config PCIE_CADENCE_HOST > > bool > > depends on OF > > select IRQ_DOMAIN > > select PCIE_CADENCE > > ... > > config PCI_J721E_HOST > > bool "TI J721E PCIe controller (host mode)" > > depends on ARCH_K3 || COMPILE_TEST > > depends on OF > > select PCIE_CADENCE_HOST > > select PCI_J721E > > ... > > So PCI_J721E_HOST selects PCIE_CADENCE_HOST which in turn selects > > PCIE_CADENCE. As of now, none of these configs are enabled in > > arm64-defconfig, and they also will not be accepted as built-in modules > > as it will bloat the Linux Image for everyone. For that reason, they are > > all being converted to loadable modules, and their configs will eventually > > be enabled in arm64-defconfig as loadable modules. > > > > Please let me know if I misunderstood your comment regarding the quoted > > change not being required. > > > > Yes, you misunderstood indeed :) My earlier comment was about IRQ_DOMAIN symbol > which looked like not needed at all. Thank you for clarifying. I (mis)interpret your comment in the context of the entire "config PCIE_CADENCE_HOST" block and the change made in it :) Regards, Siddharth.