From: Xueqi Zhang <xueqi.zhang@mediatek.com>
To: Yong Wu <yong.wu@mediatek.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: Wendy-st Lin <wendy-st.lin@mediatek.com>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <iommu@lists.linux.dev>,
Xueqi Zhang <xueqi.zhang@mediatek.com>
Subject: [PATCH 2/3] memory: mtk-smi: Add a flag skip_rpm
Date: Thu, 20 Mar 2025 15:36:17 +0800 [thread overview]
Message-ID: <20250320073625.25225-3-xueqi.zhang@mediatek.com> (raw)
In-Reply-To: <20250320073625.25225-1-xueqi.zhang@mediatek.com>
MT8196 SMI commons is backed up/restored by RTFF HW.
It doesn't need SW control the register backup/store
in the runtime callback.Therefore, add a flag skip_rpm
to help skip RPM operations for SMI commons.
Signed-off-by: Xueqi Zhang <xueqi.zhang@mediatek.com>
---
drivers/memory/mtk-smi.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/memory/mtk-smi.c b/drivers/memory/mtk-smi.c
index a8f5467d6b31..b9affa3c3185 100644
--- a/drivers/memory/mtk-smi.c
+++ b/drivers/memory/mtk-smi.c
@@ -123,6 +123,7 @@ static const char * const mtk_smi_common_clks[] = {"apb", "smi", "gals0", "gals1
struct mtk_smi_common_plat {
enum mtk_smi_type type;
bool has_gals;
+ bool skip_rpm;
u32 bus_sel; /* Balance some larbs to enter mmu0 or mmu1 */
const struct mtk_smi_reg_pair *init;
@@ -547,6 +548,9 @@ static int mtk_smi_dts_clk_init(struct device *dev, struct mtk_smi *smi,
{
int i, ret;
+ if (smi->plat->skip_rpm)
+ return 0;
+
for (i = 0; i < clk_nr_required; i++)
smi->clks[i].id = clks[i];
ret = devm_clk_bulk_get(dev, clk_nr_required, smi->clks);
@@ -783,7 +787,7 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
common->dev = dev;
common->plat = of_device_get_match_data(dev);
- if (common->plat->has_gals) {
+ if (!common->plat->skip_rpm && common->plat->has_gals) {
if (common->plat->type == MTK_SMI_GEN2)
clk_required = MTK_SMI_COM_GALS_REQ_CLK_NR;
else if (common->plat->type == MTK_SMI_GEN2_SUB_COMM)
@@ -814,13 +818,14 @@ static int mtk_smi_common_probe(struct platform_device *pdev)
}
/* link its smi-common if this is smi-sub-common */
- if (common->plat->type == MTK_SMI_GEN2_SUB_COMM) {
+ if (common->plat->type == MTK_SMI_GEN2_SUB_COMM && !common->plat->skip_rpm) {
ret = mtk_smi_device_link_common(dev, &common->smi_common_dev);
if (ret < 0)
return ret;
}
- pm_runtime_enable(dev);
+ if (!common->plat->skip_rpm)
+ pm_runtime_enable(dev);
platform_set_drvdata(pdev, common);
return 0;
}
--
2.46.0
next prev parent reply other threads:[~2025-03-20 7:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-20 7:36 [PATCH 0/3] Add mt8196 SMI support Xueqi Zhang
2025-03-20 7:36 ` [PATCH 1/3] dt-bindings: memory: mediatek: Add mt8196 support Xueqi Zhang
2025-03-21 21:50 ` Rob Herring (Arm)
2025-03-20 7:36 ` Xueqi Zhang [this message]
2025-03-20 12:11 ` [PATCH 2/3] memory: mtk-smi: Add a flag skip_rpm AngeloGioacchino Del Regno
2026-05-18 6:42 ` Xueqi Zhang (张雪琦)
2026-05-18 6:51 ` Xueqi Zhang (张雪琦)
2026-05-18 7:13 ` Xueqi Zhang (张雪琦)
2026-05-18 7:16 ` Xueqi Zhang (张雪琦)
2026-05-18 7:18 ` Krzysztof Kozlowski
2026-05-18 7:41 ` Xueqi Zhang (张雪琦)
2026-05-18 10:02 ` AngeloGioacchino Del Regno
2026-05-19 8:40 ` Xueqi Zhang (张雪琦)
2025-03-20 7:36 ` [PATCH 3/3] memory: mtk-smi: mt8196: Add smi support Xueqi Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250320073625.25225-3-xueqi.zhang@mediatek.com \
--to=xueqi.zhang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux.dev \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=wendy-st.lin@mediatek.com \
--cc=yong.wu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox