From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3DA10C28B30 for ; Thu, 20 Mar 2025 23:32:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xP/wBPgQrPgKUTmsFzSczlOv6V7nkKEHtL+ADvSLveg=; b=JVEVU6lGykLSr/V7qRVqYU7ehJ 7Qgx89pXRJI81Gn7yyLp831pcfKswKKjjqZzcdInpTgyrMcI1DtO0jWk7whUjok6vA+h4OSsP+3PX gwrRw4oBwPP0pZ8LwZU8Br/Gut044YTenJoO7yt4eaQBgmSZy4jgAl+tur6M6Ra5CaerNBndL/aDs AXym+gppK9jqYipkZdoD/nBpZLQJyJhkE7M0Oyx83jj4qjYumzVHCCQpK2bMDGso70yoXjb+ogIEO +MyYykDhD6lPzzVIyQuYRk7qo5JElAERqlVziFNsvzwnRIUpcRVKW0DXQOFf5O3IPzvipM9DkxCd2 Cby8vPAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tvPNG-0000000DSyz-1Qjy; Thu, 20 Mar 2025 23:32:30 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tvPLa-0000000DSnX-0tC2 for linux-arm-kernel@bombadil.infradead.org; Thu, 20 Mar 2025 23:30:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Cc:To:From:Subject: Message-ID:References:Mime-Version:In-Reply-To:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xP/wBPgQrPgKUTmsFzSczlOv6V7nkKEHtL+ADvSLveg=; b=VVCpKcwLAy6YBsdeCYATmi31M/ jVJLFz6HUd+n6+CdIPHIxv7FExF5CcpWHwGD5Bz4xIufJDVS0/2gmDJv5Cie+Jak2ZtQsnqR/7WVq eE0m2nmrXjjKpnjIlkjekjPVDP7kBsnQ1bV9V75Ozr6UtqVsq5/+z8lRwcAUCrhn6kdIPtUwyg8n5 TARl11ObYMRfCaNq74pxBFtYTomYHWnBj55liAhI5m6srx90zRajq7w2zQax0IL06UJj92K4F+ap7 EH6fCvVD5d6PNylRKohAVeuKJPYXpPvK8cbRmvThfUqDaPDU+ADEz8HqdEC6EWhLsyrcboDezpVqb Ja+IvU7g==; Received: from mail-pj1-x104a.google.com ([2607:f8b0:4864:20::104a]) by desiato.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tvPLW-00000004FZl-1h4o for linux-arm-kernel@lists.infradead.org; Thu, 20 Mar 2025 23:30:44 +0000 Received: by mail-pj1-x104a.google.com with SMTP id 98e67ed59e1d1-2ff7aecba07so1930596a91.2 for ; Thu, 20 Mar 2025 16:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1742513439; x=1743118239; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=xP/wBPgQrPgKUTmsFzSczlOv6V7nkKEHtL+ADvSLveg=; b=Cs4qAcKrAhY+MCtKGv7AgkFXi0UK/y0p7r3Kl3MG33+SMkRONMXp56IEzGjOtRjh7O 2Qi/tMHRMGS1URar59Zt5yT09R4ped+gMKglgdj71gS4+dNlsUf8vT2j0bk57eDwvRva icnKD1i+A+UEUmOCKceB2KyXGRSocnnaJKb+mrURnl7coac2XMSCSKXwZy85LKfO1M9o eXca+lSgo04MrnNOUO2UYJ6oUMoHqhLjRoA11g3p0Tm7/fNPD3xVcFpNM0lWA/GnyjjF iEuuGZwXwnUwaDu87Zo9jf6YS4TXl21/idbikXHbtmnZqDqNQF03r79sUrR+Vsi8f9YR oZGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742513439; x=1743118239; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xP/wBPgQrPgKUTmsFzSczlOv6V7nkKEHtL+ADvSLveg=; b=rbaxsIHRPMqS61TMUUUbU6hgE/u//kqIgCuCpCc/NF+0ydOJMNIIRNpbCzuVYkYOd/ 2YUTn0s7gQGMgpyzsr7VUPJ8qVfeu9sxZoB6J/3uHfoQ1EqTi1EHeeQyXGjL1PDrYk1z M/X1SkA/JNe4tOu9Ej5mYTY25a1oeZGDJ1mnUZ5K45jpu2yWJ4x1ZAZdU/uva5nci9pX jImQcKkoJYt4auIcqYYexCEgvCqVFpAP8fltuEE/8/kYa2GdwFTN/JPmc1JsEhhQZsO9 MyUYLbDazbbNdZMhWA5itWHvzPReav3kQSapbdX6Ev+a98HkbRjoAsfi3DqrAIiuIXp9 l+ZQ== X-Forwarded-Encrypted: i=1; AJvYcCVTjoIg8wKD9bG0fX1K2eXFG6O4Aw4tE1XT9fv2sBI2no3ULnRgDsM3Jp+/CRws6oGt8tZtEj8+OQ7Pvz/HzFsn@lists.infradead.org X-Gm-Message-State: AOJu0YxAYGe5Df9DUbxBvHSh8csu85kOS6xmUJIV10kYM5DSrFrcXTxa SEhqZ20AikYz+55rCTP9zPyxglfBseDLoXJNFE6CejnKE4RqN95U8rZJy03L1TGSAilG+QgZsuD jTyMJxQ0D6rh0nU1ifw== X-Google-Smtp-Source: AGHT+IGbmtH1MERfzGXAl5vYkqkNbYTkv2EXQg2sVuptsp1X//5UG00UaPWxnKS/ywcODQ4038/Q7eALZzjdmIbU X-Received: from pjbpw15.prod.google.com ([2002:a17:90b:278f:b0:2fc:11a0:c549]) (user=changyuanl job=prod-delivery.src-stubby-dispatcher) by 2002:a17:90b:384c:b0:2fe:7fea:ca34 with SMTP id 98e67ed59e1d1-3030fefe329mr1442133a91.32.1742513439279; Thu, 20 Mar 2025 16:30:39 -0700 (PDT) Date: Thu, 20 Mar 2025 16:29:56 -0700 In-Reply-To: <55a5e3f3-1b3f-469b-bde0-69abfff826e4@kernel.org> Mime-Version: 1.0 References: <55a5e3f3-1b3f-469b-bde0-69abfff826e4@kernel.org> X-Mailer: git-send-email 2.49.0.395.g12beb8f557-goog Message-ID: <20250320232956.327827-1-changyuanl@google.com> Subject: Re: [PATCH v5 12/16] arm64: add KHO support From: Changyuan Lyu To: krzk@kernel.org Cc: akpm@linux-foundation.org, anthony.yznaga@oracle.com, arnd@arndb.de, ashish.kalra@amd.com, benh@kernel.crashing.org, bp@alien8.de, catalin.marinas@arm.com, changyuanl@google.com, corbet@lwn.net, dave.hansen@linux.intel.com, devicetree@vger.kernel.org, dwmw2@infradead.org, ebiederm@xmission.com, graf@amazon.com, hpa@zytor.com, jgowans@amazon.com, kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, luto@kernel.org, mark.rutland@arm.com, mingo@redhat.com, pasha.tatashin@soleen.com, pbonzini@redhat.com, peterz@infradead.org, ptyadav@amazon.de, robh+dt@kernel.org, robh@kernel.org, rostedt@goodmis.org, rppt@kernel.org, saravanak@google.com, skinsburskii@linux.microsoft.com, tglx@linutronix.de, thomas.lendacky@amd.com, will@kernel.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250320_233042_728111_83741B8E X-CRM114-Status: GOOD ( 12.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, Krzysztof On Thu, Mar 20, 2025 at 08:13:24 +0100, Krzysztof Kozlowski wrote: > On 20/03/2025 02:55, Changyuan Lyu wrote: > > > > +/** > > + * early_init_dt_check_kho - Decode info required for kexec handover from DT > > + */ > > +static void __init early_init_dt_check_kho(void) > > +{ > > + unsigned long node = chosen_node_offset; > > + u64 kho_start, scratch_start, scratch_size; > > + const __be32 *p; > > + int l; > > + > > + if (!IS_ENABLED(CONFIG_KEXEC_HANDOVER) || (long)node < 0) > > + return; > > + > > + p = of_get_flat_dt_prop(node, "linux,kho-fdt", &l); > > > You are adding undocumented ABI for OF properties. That's not what was > explained last time. Thanks for the reminder! Sorry I missed [1]. I drafted a PR to add the documentation: https://github.com/devicetree-org/dt-schema/pull/158 . [1] https://lore.kernel.org/all/b1e59928-b2f4-47d4-87b8-424234c52f8d@kernel.org/ Best, Changyuan