Re: [PATCH v8 11/13] arm64: dts: bcm2712: Add external clock for RP1 chipset on Rpi5

Stefan Wahren
2025-04-14T12:04:53Z

Hi Andrea,

Am 19.03.25 um 22:52 schrieb Andrea della Porta:
> The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz.
> Add clk_rp1_xosc node to provide that.
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
i'm fine with the patch content, but I think this is necessary before
Patch 9 is applied?
> ---
> arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> index fbc56309660f..1850a575e708 100644
> --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts
> @@ -16,6 +16,13 @@ chosen: chosen {
> stdout-path = "serial10:115200n8";
> };
>
> + clk_rp1_xosc: clock-50000000 {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-output-names = "rp1-xosc";
> + clock-frequency = <50000000>;
> + };
> +
> /* Will be filled by the bootloader */
> memory@0 {
> device_type = "memory";