From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C104DC3600B for ; Thu, 27 Mar 2025 19:05:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5p5X5RWy4xzhwyE3k98EJjc2avxT6nHq/ST+gps8UT4=; b=PdyqIzch1rNtDLHioMAa2ysYa8 ltZ8AuYCwoTxUokaAN6gmagYtHWlX4kVj6Uo7witQf73DIfi4UCy9m3Q6Tw6dWlfImbyWs1liQP2f sY2vOQ24RNExZLD73BET/UsoagZZlnrSH2HUhCMcZx7KayBJsb8PaSF2xnHLkRinYqQelI95oYsmK tT6/sinPthrgYfgnYHXuWI+q95r/7iXJA3YApaXzLOUlO3ghEldsyZT13fjT+PSKExwuqD1RIN0wa TWtILv5KqaPCueZGPuR5I66IovaN+jt16/umtVyVZCLaYzm/0V8z9IbsskN8L0XPSmJSqcvgtsTW1 FCK+t4SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1txsXj-0000000Bn0m-239I; Thu, 27 Mar 2025 19:05:31 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1txsR3-0000000Bm0b-2MDH for linux-arm-kernel@lists.infradead.org; Thu, 27 Mar 2025 18:58:38 +0000 Received: from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi [81.175.209.231]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 628C2F6; Thu, 27 Mar 2025 19:56:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1743101807; bh=R/uKdU7aA4BfJOc345ybd2WNSZ2vLTa39onAL07P+ZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WckAHETZwTaOAbY4L/obIAwGhwkgdpF6a73wdM6Hqlh/t8yyP+Tk+idQZPHBVpE1x p6oBcYz8mdBa/nMBEEWnn362SP4cj0kZs63Xv9MnEVZJZEJ7HHpDoF52eafEk4k/e/ 34I3l52duhq21Z+bslz0UIIU/0G8+fg63Qqcpt7Y= Date: Thu, 27 Mar 2025 20:58:13 +0200 From: Laurent Pinchart To: Frank Li Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dong Aisheng , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Mauro Carvalho Chehab , Rui Miguel Silva , Martin Kepplinger , Purism Kernel Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Robert Chiras , "Guoniu.zhou" Subject: Re: [PATCH v3 10/12] arm64: dts: imx8qm: add 24MHz clock-xtal24m Message-ID: <20250327185813.GA22659@pendragon.ideasonboard.com> References: <20250210-8qxp_camera-v3-0-324f5105accc@nxp.com> <20250210-8qxp_camera-v3-10-324f5105accc@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250210-8qxp_camera-v3-10-324f5105accc@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250327_115837_735877_970E6FB2 X-CRM114-Status: GOOD ( 16.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Frank, Thank you for the patch. On Mon, Feb 10, 2025 at 03:59:29PM -0500, Frank Li wrote: > Add fixed clock node clock-xtal24m to prepare to add camera support. > > Signed-off-by: Frank Li > --- > change from v1 to v3 > - none > --- > arch/arm64/boot/dts/freescale/imx8qm.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > index c6a17a0d739c5..40cd45cd9f88f 100644 > --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi > @@ -590,6 +590,13 @@ mipi_pll_div2_clk: clock-controller-mipi-div2-pll { > clock-output-names = "mipi_pll_div2_clk"; > }; > > + xtal24m: clock-xtal24m { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <24000000>; > + clock-output-names = "xtal_24MHz"; > + }; This is a clock oscillator mounted on the PCB, isn't it ? It shouldn't be in imx8qm.dtsi, but in board-specific DT sources. > + > vpu_subsys_dsp: bus@55000000 { > compatible = "simple-bus"; > #address-cells = <1>; -- Regards, Laurent Pinchart