linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: Vishal Sagar <vishal.sagar@amd.com>,
	Anatoliy Klymenko <anatoliy.klymenko@amd.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Michal Simek <michal.simek@amd.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v4 11/11] drm: xlnx: zynqmp: Add support for XVUY2101010
Date: Fri, 28 Mar 2025 01:06:19 +0200	[thread overview]
Message-ID: <20250327230619.GF16629@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20250326-xilinx-formats-v4-11-322a300c6d72@ideasonboard.com>

Hi Tomi,

Thank you for the patch.

On Wed, Mar 26, 2025 at 03:22:54PM +0200, Tomi Valkeinen wrote:
> Add support for XVUY2101010 format.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
> ---
>  drivers/gpu/drm/xlnx/zynqmp_disp.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> index ce685dfbf31f..79f58e06f38f 100644
> --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> @@ -322,6 +322,11 @@ static const struct zynqmp_disp_format avbuf_vid_fmts[] = {
>  		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_VID_YV24_10,
>  		.swap		= false,
>  		.sf		= scaling_factors_101010,
> +	}, {
> +		.drm_fmt	= DRM_FORMAT_XVUY2101010,
> +		.buf_fmt	= ZYNQMP_DISP_AV_BUF_FMT_NL_VID_YUV444_10,
> +		.swap		= false,
> +		.sf		= scaling_factors_101010,

I'll have to trust your word on this, the documentation is just too
wrong in too many places to trust it. Assuming you've tested this
format,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  	},
>  };
>  

-- 
Regards,

Laurent Pinchart


      reply	other threads:[~2025-03-27 23:08 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-26 13:22 [PATCH v4 00/11] drm: Add new pixel formats for Xilinx Zynqmp Tomi Valkeinen
2025-03-26 13:22 ` [PATCH v4 01/11] drm/fourcc: Add warning for bad bpp Tomi Valkeinen
2025-03-26 13:22 ` [PATCH v4 02/11] drm/fourcc: Add DRM_FORMAT_XV15/XV20 Tomi Valkeinen
2025-03-27 22:34   ` Laurent Pinchart
2025-03-28 10:05     ` Tomi Valkeinen
2025-03-28 10:27       ` Laurent Pinchart
2025-03-26 13:22 ` [PATCH v4 03/11] drm/fourcc: Add DRM_FORMAT_Y8 Tomi Valkeinen
2025-03-26 13:52   ` Geert Uytterhoeven
2025-03-26 13:55     ` Tomi Valkeinen
2025-03-27  9:20       ` Pekka Paalanen
2025-03-27 14:21         ` Tomi Valkeinen
2025-03-27 15:58           ` Pekka Paalanen
2025-03-27 16:35             ` Geert Uytterhoeven
2025-03-31  7:54               ` Pekka Paalanen
2025-03-31  8:21                 ` Laurent Pinchart
2025-03-31 10:53                   ` Pekka Paalanen
2025-03-31 14:54                     ` Laurent Pinchart
2025-04-01  6:49                       ` Pekka Paalanen
2025-04-01 13:27                     ` Pekka Paalanen
2025-04-16  8:59                       ` Tomi Valkeinen
2025-04-17  8:13                         ` Pekka Paalanen
2025-04-21 14:50                           ` Laurent Pinchart
2025-04-22  9:11                             ` Pekka Paalanen
2025-04-22  9:41                               ` Geert Uytterhoeven
2025-04-22 10:01                                 ` Pekka Paalanen
2025-04-22 10:12                                   ` Geert Uytterhoeven
2025-04-22 11:00                                     ` Pekka Paalanen
2025-04-25  8:38                           ` Tomi Valkeinen
2025-04-25 10:18                             ` Pekka Paalanen
2025-03-26 13:22 ` [PATCH v4 04/11] drm/fourcc: Add DRM_FORMAT_Y10_P32 Tomi Valkeinen
2025-03-27 22:53   ` Laurent Pinchart
2025-03-26 13:22 ` [PATCH v4 05/11] drm/fourcc: Add DRM_FORMAT_X403 Tomi Valkeinen
2025-03-27 22:55   ` Laurent Pinchart
2025-03-26 13:22 ` [PATCH v4 06/11] drm/fourcc: Add DRM_FORMAT_XVUY2101010 Tomi Valkeinen
2025-03-27 23:07   ` Laurent Pinchart
2025-03-26 13:22 ` [PATCH v4 07/11] drm: xlnx: zynqmp: Use drm helpers when calculating buffer sizes Tomi Valkeinen
2025-03-26 13:22 ` [PATCH v4 08/11] drm: xlnx: zynqmp: Add support for XV15 & XV20 Tomi Valkeinen
2025-03-27 22:35   ` Laurent Pinchart
2025-03-26 13:22 ` [PATCH v4 09/11] drm: xlnx: zynqmp: Add support for Y8 and Y10_P32 Tomi Valkeinen
2025-03-27 22:52   ` Laurent Pinchart
2025-03-31 11:37     ` Tomi Valkeinen
2025-03-26 13:22 ` [PATCH v4 10/11] drm: xlnx: zynqmp: Add support for X403 Tomi Valkeinen
2025-03-27 22:59   ` Laurent Pinchart
2025-03-26 13:22 ` [PATCH v4 11/11] drm: xlnx: zynqmp: Add support for XVUY2101010 Tomi Valkeinen
2025-03-27 23:06   ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250327230619.GF16629@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@gmail.com \
    --cc=anatoliy.klymenko@amd.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=michal.simek@amd.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    --cc=vishal.sagar@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).