From: Krzysztof Kozlowski <krzk@kernel.org>
To: justin.chen@broadcom.com
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-phy@lists.infradead.org, rafal@milecki.pl,
alcooperx@gmail.com, bcm-kernel-feedback-list@broadcom.com,
florian.fainelli@broadcom.com, conor+dt@kernel.org,
krzk+dt@kernel.org, robh@kernel.org, kishon@kernel.org,
vkoul@kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: phy: brcmstb-usb-phy: Add support for bcm74110
Date: Fri, 28 Mar 2025 09:23:53 +0100 [thread overview]
Message-ID: <20250328-acrid-pygmy-dogfish-babce2@krzk-bin> (raw)
In-Reply-To: <20250327185623.3047893-3-justin.chen@broadcom.com>
On Thu, Mar 27, 2025 at 11:56:23AM -0700, justin.chen@broadcom.com wrote:
> From: Justin Chen <justin.chen@broadcom.com>
>
> bcm74110 brcmstb usb phy adds further power savings during suspend
> states.
>
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
Please order the patches as stated in DT submitting patches.
> ---
> Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> index 580fbe37b37f..2e668935b454 100644
> --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> @@ -15,6 +15,7 @@ maintainers:
> properties:
> compatible:
> enum:
> + - brcm,bcm74110-usb-phy
> - brcm,bcm4908-usb-phy
> - brcm,bcm7211-usb-phy
> - brcm,bcm7216-usb-phy
That's incomplete. Where are the updates for constraints? Look at entire
file, not just top 10 lines.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-28 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-27 18:56 [PATCH 0/2] phy: usb: add support for bcm74110 justin.chen
2025-03-27 18:56 ` [PATCH 1/2] " justin.chen
2025-03-31 16:56 ` Florian Fainelli
2025-03-27 18:56 ` [PATCH 2/2] dt-bindings: phy: brcmstb-usb-phy: Add " justin.chen
2025-03-28 8:23 ` Krzysztof Kozlowski [this message]
2025-03-31 20:14 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328-acrid-pygmy-dogfish-babce2@krzk-bin \
--to=krzk@kernel.org \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=rafal@milecki.pl \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox