From: Krzysztof Kozlowski <krzk@kernel.org>
To: Lukasz Czechowski <lukasz.czechowski@thaumatec.com>
Cc: Matthias Kaehlcke <mka@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Benjamin Bara <benjamin.bara@skidata.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Klaus Goger <klaus.goger@theobroma-systems.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, quentin.schulz@cherry.de,
stable@vger.kernel.org
Subject: Re: [PATCH 1/5] usb: misc: onboard_usb_dev: fix support for Cypress HX3 hubs
Date: Fri, 28 Mar 2025 09:19:03 +0100 [thread overview]
Message-ID: <20250328-holistic-feathered-guppy-5bac92@krzk-bin> (raw)
In-Reply-To: <20250326-onboard_usb_dev-v1-1-a4b0a5d1b32c@thaumatec.com>
On Wed, Mar 26, 2025 at 05:22:56PM +0100, Lukasz Czechowski wrote:
> diff --git a/drivers/usb/misc/onboard_usb_dev.h b/drivers/usb/misc/onboard_usb_dev.h
> index 317b3eb99c02..17696f7c5e43 100644
> --- a/drivers/usb/misc/onboard_usb_dev.h
> +++ b/drivers/usb/misc/onboard_usb_dev.h
> @@ -104,8 +104,14 @@ static const struct of_device_id onboard_dev_match[] = {
> { .compatible = "usb451,8027", .data = &ti_tusb8020b_data, },
> { .compatible = "usb451,8140", .data = &ti_tusb8041_data, },
> { .compatible = "usb451,8142", .data = &ti_tusb8041_data, },
> + { .compatible = "usb4b4,6500", .data = &cypress_hx3_data, },
> + { .compatible = "usb4b4,6502", .data = &cypress_hx3_data, },
> + { .compatible = "usb4b4,6503", .data = &cypress_hx3_data, },
> { .compatible = "usb4b4,6504", .data = &cypress_hx3_data, },
> { .compatible = "usb4b4,6506", .data = &cypress_hx3_data, },
> + { .compatible = "usb4b4,6507", .data = &cypress_hx3_data, },
> + { .compatible = "usb4b4,6508", .data = &cypress_hx3_data, },
Why are you adding so many entries? Same entry is a strong sign these
are compatible.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-28 8:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 16:22 [PATCH 0/5] Fix onboard USB hub instability on RK3399 Puma SoM Lukasz Czechowski
2025-03-26 16:22 ` [PATCH 1/5] usb: misc: onboard_usb_dev: fix support for Cypress HX3 hubs Lukasz Czechowski
2025-03-28 8:19 ` Krzysztof Kozlowski [this message]
2025-03-26 16:22 ` [PATCH 2/5] dt-bindings: usb: cypress,hx3: Add support for all variants Lukasz Czechowski
2025-03-26 17:58 ` Conor Dooley
2025-04-08 16:36 ` Łukasz Czechowski
2025-04-09 16:18 ` Conor Dooley
2025-04-09 16:26 ` Quentin Schulz
2025-04-09 21:27 ` Conor Dooley
2025-04-10 9:37 ` Quentin Schulz
2025-04-09 14:14 ` Rob Herring (Arm)
2025-03-26 16:22 ` [PATCH 3/5] arm64: dts: rockchip: fix internal USB hub instability on RK3399 Puma Lukasz Czechowski
2025-03-26 16:22 ` [PATCH 4/5] arm64: dts: rockchip: disable unrouted USB controllers and PHY " Lukasz Czechowski
2025-03-26 16:23 ` [PATCH 5/5] arm64: dts: rockchip: disable unrouted USB controllers and PHY on RK3399 Puma with Haikou Lukasz Czechowski
2025-03-26 19:11 ` [PATCH 0/5] Fix onboard USB hub instability on RK3399 Puma SoM Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328-holistic-feathered-guppy-5bac92@krzk-bin \
--to=krzk@kernel.org \
--cc=benjamin.bara@skidata.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=klaus.goger@theobroma-systems.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukasz.czechowski@thaumatec.com \
--cc=mka@chromium.org \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox