From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF511C36010 for ; Fri, 28 Mar 2025 10:40:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MyuTqVvTP1UPCrUbHlnkU12n+jkzkkYz1VOSQfsDbeM=; b=mf4tcH4RP2w5sEj/olbKT7uPcr u7vzMt87kPVzrqKwrerwk89K4kpL77tCJxkD0ff79aXZWESZAeVfWmNtzaqiJP1YewKZqBlh4oV17 gEsplRNYMHrHgGgIup9s5N0TGK63ew1SsKEVqWhd4uJTW2yQcGi5cVfPUNzLYXfq/4zQy/wqNh63j iCVGJfZGYN0xGDW0kobgAiec3WCNzw7m6M9Zl7aGcHLnZgywIonPqAU2Yi0Tkw5f+E2VFMMPFFPIh rcCCq75MYIXvY/wooKNU5NnGYRrAMSaxehGnszryVtuP2ZErmuQEo+RYaXFSrp5/8+7WfViNoGxIV 7Hk/MYEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1ty78U-0000000D9ku-2XLp; Fri, 28 Mar 2025 10:40:26 +0000 Received: from smtp-bc0b.mail.infomaniak.ch ([45.157.188.11]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1ty76j-0000000D9Xr-3THv for linux-arm-kernel@lists.infradead.org; Fri, 28 Mar 2025 10:38:40 +0000 Received: from smtp-4-0000.mail.infomaniak.ch (unknown [IPv6:2001:1600:7:10:40ca:feff:fe05:0]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4ZPH7D4YFjzW2y; Fri, 28 Mar 2025 11:38:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digikod.net; s=20191114; t=1743158312; bh=MyuTqVvTP1UPCrUbHlnkU12n+jkzkkYz1VOSQfsDbeM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ubL6rwRE1GKQDgpoFHHnqtWunMExgXmH9SIOevHevMNsSgJymrB8PqtT7RsLdLH6w LH8BY2mtUo8hpXM7UsTfJgikKEEPrGDHXtD/YG1KBqXB9zjymaqJWWlh2+lJ2/0GBJ hyNRO+Q8o5kFKLuA61PJ1bLsF5hhWu4A3JkuEPzU= Received: from unknown by smtp-4-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4ZPH735RxtzKRX; Fri, 28 Mar 2025 11:38:23 +0100 (CET) Date: Fri, 28 Mar 2025 11:38:23 +0100 From: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= To: Maxime Ripard Cc: Kees Cook , Alessandro Carminati , linux-kselftest@vger.kernel.org, David Airlie , Arnd Bergmann , =?utf-8?B?TWHDrXJh?= Canal , Dan Carpenter , Daniel Diaz , David Gow , Arthur Grillo , Brendan Higgins , Naresh Kamboju , Maarten Lankhorst , Andrew Morton , Ville =?utf-8?B?U3lyasOkbMOk?= , Daniel Vetter , Thomas Zimmermann , Guenter Roeck , Alessandro Carminati , Jani Nikula , dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, loongarch@lists.linux.dev, x86@kernel.org Subject: Re: [PATCH v4 00/14] Add support for suppressing warning backtraces Message-ID: <20250328.sah9oog5ahSh@digikod.net> References: <20250313114329.284104-1-acarmina@redhat.com> <202503131016.5DCEAEC945@keescook> <20250313-abiding-vivid-robin-159dfa@houat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250313-abiding-vivid-robin-159dfa@houat> X-Infomaniak-Routing: alpha X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250328_033837_998690_175092A3 X-CRM114-Status: GOOD ( 19.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Mar 13, 2025 at 06:24:25PM +0100, Maxime Ripard wrote: > Hi, > > On Thu, Mar 13, 2025 at 10:17:49AM -0700, Kees Cook wrote: > > On Thu, Mar 13, 2025 at 11:43:15AM +0000, Alessandro Carminati wrote: > > > Some unit tests intentionally trigger warning backtraces by passing bad > > > parameters to kernel API functions. Such unit tests typically check the > > > return value from such calls, not the existence of the warning backtrace. > > > > Thanks for picking this series back up! I honestly thought this had > > already landed. :) > > > > > With CONFIG_KUNIT enabled, image size increase with this series applied is > > > approximately 1%. The image size increase (and with it the functionality > > > introduced by this series) can be avoided by disabling > > > CONFIG_KUNIT_SUPPRESS_BACKTRACE. > > > > Yeah, as with my prior review, I'm a fan of this. It makes a bunch of my > > very noisy tests much easier to deal with. > > And for the record, we're also affected by this in DRM and would very > much like to get it merged in one shape or another. Here is another case: https://lore.kernel.org/all/20250328.Ahc0thi6CaiJ@digikod.net/ It would be very useful to have this feature merged. Without it, we may need to remove useful tests.