From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E602FC28B20 for ; Fri, 28 Mar 2025 09:47:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DblYywReEGB3Jd3PE0LbE/Jq4cSyUAJYOznikHNbaVU=; b=G0MyB4qrvqIrWuMRG3ybPZ5HtK gR1W0qnqpJDKQWcA76oI3jVrhn/EfZ0M7RH0SKeNA+/gqVv5FtMIJslnuRc89exPnwnqRAJdZQQR+ +CIljK3YiZvKAEWyceIege5trhpAlZ8XxtjMugTwwhnJvm/l47kL9pQrMUQq61IP8szIDqMn+wJXn wbbAPw38JlaU8Iw7Kt6Q6PsQT0hz+srlj8MmXXfcR7uT0jOQzESjAMU7svdWI1S+Y5JHkrraOCZXw cOeQJizWZA9HAjHcgqyQ6j89baUR4fQWDk9L382Wx7K/cm4cS6rHg8BMjbhDkx42LG7lXpVS5mniO CsAj3mLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.1 #2 (Red Hat Linux)) id 1ty6In-0000000D3xG-08Uh; Fri, 28 Mar 2025 09:47:01 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.1 #2 (Red Hat Linux)) id 1ty6H3-0000000D3lX-1bPW for linux-arm-kernel@lists.infradead.org; Fri, 28 Mar 2025 09:45:13 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 7306D614BC; Fri, 28 Mar 2025 09:45:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 246D5C4CEE4; Fri, 28 Mar 2025 09:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1743155112; bh=9h0GJzU6Aief9ThMESTGvq/UEVqXhEwYJGASD6M/NUc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GBHlJRpSIZQn96cJHjJLy3wu05TPyg5mO09E2xVwucYpNQ2bRpIUHBpzp/KLou7S6 x93Lb4VopnCFGlKajP/00wL7cweb1eX+tgaAnKYp5D55b+9Hh4Awo3w4l4CHs1XP7v Xzd+0p2Hl89qgLRU7jCvUGjQfYgIqTuofWqjSS3dV56jvFbIX4FRAxnFBDvQnQ+LD8 398Oipf/KwTJp9fwuyZK3hGwVpxu8FUU9TT3J55/AFdzuBq891qXJxdJ3Rf2bI4z9A 3JOzmGIzsSV5tmFaknlYT9Isj1CG9YOl/OAI6zMqxb4QyPvYUu7w18FQp5sJ1sJq6P koxTGFAHOc9wg== Date: Fri, 28 Mar 2025 09:44:54 +0000 From: Jonathan Cameron To: Krzysztof Kozlowski Cc: Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Coquelin , Alexandre Torgue , Nuno =?UTF-8?B?U8Oh?= , Michael Hennerich , Kim Seer Paller , Anshul Dalal , Ramona Gradinariu , Antoniu Miclaus , Robert Budai , Petre Rodan , Andreas Klinger , Fabrice Gasnier , Matti Vaittinen , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: iio: Correct indentation and style in DTS example Message-ID: <20250328094454.3ec9dd7d@jic23-huawei> In-Reply-To: <20250324125313.82226-1-krzysztof.kozlowski@linaro.org> References: <20250324125313.82226-1-krzysztof.kozlowski@linaro.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.48; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 24 Mar 2025 13:53:12 +0100 Krzysztof Kozlowski wrote: > DTS example in the bindings should be indented with 2- or 4-spaces and > aligned with opening '- |', so correct any differences like 3-spaces or > mixtures 2- and 4-spaces in one binding. > > No functional changes here, but saves some comments during reviews of > new patches built on existing code. > > Signed-off-by: Krzysztof Kozlowski Applied both patches to my testing branch. I'll rebase on rc1 once that is available and push out as togreg. Thanks, Jonathan > --- > .../bindings/iio/adc/st,stm32-adc.yaml | 102 +++++++++--------- > 1 file changed, 51 insertions(+), 51 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml > index ef9dcc365eab..17bb60e18a1c 100644 > --- a/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml > @@ -498,7 +498,7 @@ patternProperties: > examples: > - | > // Example 1: with stm32f429, ADC1, single-ended channel 8 > - adc123: adc@40012000 { > + adc123: adc@40012000 { > compatible = "st,stm32f4-adc-core"; > reg = <0x40012000 0x400>; > interrupts = <18>; > @@ -512,28 +512,28 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > adc@0 { > - compatible = "st,stm32f4-adc"; > - #io-channel-cells = <1>; > - reg = <0x0>; > - clocks = <&rcc 0 168>; > - interrupt-parent = <&adc123>; > - interrupts = <0>; > - st,adc-channels = <8>; > - dmas = <&dma2 0 0 0x400 0x0>; > - dma-names = "rx"; > - assigned-resolution-bits = <8>; > + compatible = "st,stm32f4-adc"; > + #io-channel-cells = <1>; > + reg = <0x0>; > + clocks = <&rcc 0 168>; > + interrupt-parent = <&adc123>; > + interrupts = <0>; > + st,adc-channels = <8>; > + dmas = <&dma2 0 0 0x400 0x0>; > + dma-names = "rx"; > + assigned-resolution-bits = <8>; > }; > // ... > // other adc child nodes follow... > - }; > + }; > > - | > // Example 2: with stm32mp157c to setup ADC1 with: > // - channels 0 & 1 as single-ended > // - channels 2 & 3 as differential (with resp. 6 & 7 negative inputs) > - #include > - #include > - adc12: adc@48003000 { > + #include > + #include > + adc12: adc@48003000 { > compatible = "st,stm32mp1-adc-core"; > reg = <0x48003000 0x400>; > interrupts = , > @@ -550,27 +550,27 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > adc@0 { > - compatible = "st,stm32mp1-adc"; > - #io-channel-cells = <1>; > - reg = <0x0>; > - interrupt-parent = <&adc12>; > - interrupts = <0>; > - st,adc-channels = <0 1>; > - st,adc-diff-channels = <2 6>, <3 7>; > - st,min-sample-time-nsecs = <5000>; > - dmas = <&dmamux1 9 0x400 0x05>; > - dma-names = "rx"; > + compatible = "st,stm32mp1-adc"; > + #io-channel-cells = <1>; > + reg = <0x0>; > + interrupt-parent = <&adc12>; > + interrupts = <0>; > + st,adc-channels = <0 1>; > + st,adc-diff-channels = <2 6>, <3 7>; > + st,min-sample-time-nsecs = <5000>; > + dmas = <&dmamux1 9 0x400 0x05>; > + dma-names = "rx"; > }; > // ... > // other adc child node follow... > - }; > + }; > > - | > // Example 3: with stm32mp157c to setup ADC2 with: > // - internal channels 13, 14, 15. > - #include > - #include > - adc122: adc@48003000 { > + #include > + #include > + adc122: adc@48003000 { > compatible = "st,stm32mp1-adc-core"; > reg = <0x48003000 0x400>; > interrupts = , > @@ -587,28 +587,28 @@ examples: > #address-cells = <1>; > #size-cells = <0>; > adc@100 { > - compatible = "st,stm32mp1-adc"; > - #io-channel-cells = <1>; > - reg = <0x100>; > - interrupts = <1>; > - #address-cells = <1>; > - #size-cells = <0>; > - channel@13 { > - reg = <13>; > - label = "vrefint"; > - st,min-sample-time-ns = <9000>; > - }; > - channel@14 { > - reg = <14>; > - label = "vddcore"; > - st,min-sample-time-ns = <9000>; > - }; > - channel@15 { > - reg = <15>; > - label = "vbat"; > - st,min-sample-time-ns = <9000>; > - }; > + compatible = "st,stm32mp1-adc"; > + #io-channel-cells = <1>; > + reg = <0x100>; > + interrupts = <1>; > + #address-cells = <1>; > + #size-cells = <0>; > + channel@13 { > + reg = <13>; > + label = "vrefint"; > + st,min-sample-time-ns = <9000>; > + }; > + channel@14 { > + reg = <14>; > + label = "vddcore"; > + st,min-sample-time-ns = <9000>; > + }; > + channel@15 { > + reg = <15>; > + label = "vbat"; > + st,min-sample-time-ns = <9000>; > + }; > }; > - }; > + }; > > ...