From: "Krzysztof Wilczyński" <kw@linux.com>
To: Niklas Cassel <cassel@kernel.org>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Rob Herring <robh@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Heiko Stuebner <heiko@sntech.de>,
linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: rockchip-ep: Mark RK3399 as intx_capable
Date: Fri, 28 Mar 2025 21:21:23 +0900 [thread overview]
Message-ID: <20250328122123.GA1187318@rocinante> (raw)
In-Reply-To: <20250326200115.3804380-2-cassel@kernel.org>
Hello,
> RK3399 can raise INTx interrupts, as can be seen by
> rockchip_pcie_ep_send_intx_irq().
>
> This is also in line with the register description of
> PCIE_CLIENT_LEGACY_INT_CTRL, section "17.6.3 PCIe Client Detail Register
> Description" of the RK3399 TRM.
>
> Thus, mark RK3399 as intx_capable.
Replaced the following commit:
e55c67837a8c ("PCI: dw-rockchip: Endpoint mode cannot raise INTx interrupts")
With this one directly on the "endpoint-test" branch. This is per the
conversation at:
https://lore.kernel.org/linux-pci/20250318103330.1840678-6-cassel@kernel.org
Thank you!
Krzysztof
next prev parent reply other threads:[~2025-03-28 12:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-26 20:01 [PATCH] PCI: rockchip-ep: Mark RK3399 as intx_capable Niklas Cassel
2025-03-28 12:21 ` Krzysztof Wilczyński [this message]
2025-03-28 12:36 ` Krzysztof Wilczyński
2025-04-09 8:07 ` Niklas Cassel
2025-04-02 7:50 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250328122123.GA1187318@rocinante \
--to=kw@linux.com \
--cc=bhelgaas@google.com \
--cc=cassel@kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).