public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: Matthew Bystrin <dev.mbstr@gmail.com>
Cc: arm-scmi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sudeep Holla <sudeep.holla@arm.com>,
	Cristian Marussi <cristian.marussi@arm.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] firmware: arm_scmi: add timeout in do_xfer_with_response()
Date: Wed, 2 Apr 2025 11:59:47 +0100	[thread overview]
Message-ID: <20250402-hidden-unyielding-carp-7ee32d@sudeepholla> (raw)
In-Reply-To: <20250402104254.149998-1-dev.mbstr@gmail.com>

On Wed, Apr 02, 2025 at 01:42:54PM +0300, Matthew Bystrin wrote:
> Add timeout argument to do_xfer_with_response() with subsequent changes
> in corresponding drivers. To maintain backward compatibility use
> previous hardcoded timeout value.
> 
> According to SCMI specification [1] there is no defined timeout for
> delayed messages in the interface. While hardcoded 2 seconds timeout
> might be good enough for existing protocol drivers, moving it to the
> function argument may be useful for vendor-specific protocols with
> different timing needs.
> 

Please post this patch along with the vendor specific protocols mentioned
above and with the reasoning as why 2s is not sufficient.

Also instead of churning up existing users/usage, we can explore to had
one with this timeout as alternative if you present and convince the
validity of your use-case and the associated timing requirement.

-- 
Regards,
Sudeep


  reply	other threads:[~2025-04-02 11:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02 10:42 [PATCH] firmware: arm_scmi: add timeout in do_xfer_with_response() Matthew Bystrin
2025-04-02 10:59 ` Sudeep Holla [this message]
2025-04-02 16:05   ` Cristian Marussi
2025-04-03  8:59     ` Sudeep Holla
2025-04-03 19:50     ` Matthew Bystrin
2025-04-08 20:22       ` Matthew Bystrin
2025-04-09 10:52         ` Cristian Marussi
2025-04-09 10:54           ` Cristian Marussi
2025-04-09  0:57       ` Peng Fan
2025-04-09 11:12       ` Sudeep Holla
2025-04-12 10:39         ` Matthew Bystrin
2025-04-14  8:38           ` Cristian Marussi
2025-04-21  5:37             ` Matthew Bystrin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250402-hidden-unyielding-carp-7ee32d@sudeepholla \
    --to=sudeep.holla@arm.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=cristian.marussi@arm.com \
    --cc=dev.mbstr@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=peng.fan@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox