From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54FB3C369A1 for ; Tue, 8 Apr 2025 19:02:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CUlKKPlBNcX+ovv1QVnpgE0TYv5pOjsAO1cQONG28sc=; b=LOqzmyJ/YGFnbx92zgPW4KWyZd SOb9Er7Y9NBNL5f44z5XOpHn290ZE211RZurdn36QV05wf/JAO/HtUN71iEH41c9WvDiISjYT0B9s aKyc+cu+GUwkeR1BleBPEU7Ymte2plfqO0vmfLYKG1hOMql9CIWMjub3N8m3nAhAYz/Z6mN8M0OPj jmRCnZc35WPXqbXDobFML8MbqoPWLLBK1ZNhg7W8ZlkOEQp59YcTfPXzTDu5ew4OzCZpBMvotDj99 nf475VlxsMr4HeqSJKyXyeY8Wobun9jsiAS0zhqwBgNAlsx+iKG4TWL/M2eqnHjfoD+9vBy5+3zXv k2nJM8iA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2ED6-00000005BSv-1mNc; Tue, 08 Apr 2025 19:02:12 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2E8Z-00000005AiV-1W1D; Tue, 08 Apr 2025 18:57:32 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6C808A49124; Tue, 8 Apr 2025 18:52:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6491BC4CEEA; Tue, 8 Apr 2025 18:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744138649; bh=Zq46Qr2znB6f0M/kcECH5HtNBXx3KTiGDsDx+biqMDM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=GxI+86hHJtfLXQhDGT5iJDwd1kK9NkNKGbdjoKj+gBEg8cwlt1HRH0bOs2wjsFSL6 vyflJKROprk1sJBReSSPx1sPx1PUz8vCbXU9+/c1r+CymLUnnLnXOuyfyNCH81xGU4 HfcEsOy3e54nmGckI2o8/amiEWhEGoQ6jKZlOfRN9D/jjVA1jk9cwSsqe36CaUsUMh 3vRb4GuIXAMzor4aQsl9GFvJDYxV/8Yq7sYt5ItfIqQutsAdcWqtoQ51+rkghqQv/a y98nL9s5PkHlrseLMkIafN7+xIBpz/z+XDTXYEvYgnvxNlGLfrnN0Ff49rrFg6WMbo L+yKsHus4UpWw== Date: Tue, 8 Apr 2025 11:57:27 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Michal Kubiak , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next 1/3] net: airoha: Add l2_flows rhashtable Message-ID: <20250408115727.6b7468b3@kernel.org> In-Reply-To: References: <20250407-airoha-flowtable-l2b-v1-0-18777778e568@kernel.org> <20250407-airoha-flowtable-l2b-v1-1-18777778e568@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250408_115731_464317_6822036B X-CRM114-Status: GOOD ( 11.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 8 Apr 2025 18:49:40 +0200 Lorenzo Bianconi wrote: > > I didn't find any usage of L4 flow type in the series. > > Is that reserved for future series? Shouldn't it be added together with > > its usage then? > > FLOW_TYPE_L4 is equal to 0 so it is the default value for > airoha_flow_table_entry type when not set explicitly. > It is done this way to reduce code changes. That seems quite unintuitive. Could you init explicitly for the benefit of people reading this code?