From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93156C36002 for ; Wed, 9 Apr 2025 20:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To:In-Reply-To:References :Message-Id:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=P3fOqZDxBeGvRIRUqcDmtOeRQ71JamkiET0HGj8mn70=; b=pcyG0XspJAR61AJai67Vx6LS5h 9JjCL8d8PXMIc0+6MywX41Yq2035QxfZl7uNN5CUEFO9Ulad5VuUTw77qGQEF7cyYqdvcqq61uryZ 3j5+h0uZrjDQx5Kk/FaCg+VF/5Eyq03Zzq5sH0JLgGSlZT+Kg/nCEWi9OFJ+qyqASZ97FfMBfpzeh akGYxcBz1KVhwLXbF/lxhJXwTT4qJwTDZUIhtV+rEuB8JaIWGk5LyN1I0j+NiSa6DLos5tAsc8/CH ARs++QpitpBGvBxboDbD1RKJK45CITf7ssYTgvlzVqAamRDCDVAFt2cCBcVV1I9mrNcP0kyu5ZfaC kGez/89w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cRf-00000008VU6-0q0K; Wed, 09 Apr 2025 20:54:51 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2cAy-00000008Sbn-1WuY for linux-arm-kernel@lists.infradead.org; Wed, 09 Apr 2025 20:37:37 +0000 Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-5e677f59438so144832a12.2 for ; Wed, 09 Apr 2025 13:37:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744231055; x=1744835855; darn=lists.infradead.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=P3fOqZDxBeGvRIRUqcDmtOeRQ71JamkiET0HGj8mn70=; b=gNODyknTOoTLkrMwFTb/60mywUclYpL48e35HMn8PJF1wHBLDDw4zddenlx1hcqakG 0iEE1+5mFus3la+BvFZt/y8opsGS3QlbwSINRFOPFAARkhcR1IfW6TmnwTUAeEtd1mzd 7pLn4Chf/m+xkqXMGLDbqpcBDkRXOd1t7b+/zVUij4FKZfzjWC+bgzEeNKQd0Onb+Hg6 rjC00V5rRczFxhK1Uyv5MMkL1ksJoVhZwwTOji0PO/gY5ZTvQrAM85WMyOCbWOMy+Tb8 IiKV8OEHnVZzMnFCh0jxAOtvaYe0U8+mpLV6haJyUwTgkrKAE2U0I73jneMhiohHLdR9 9u/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744231055; x=1744835855; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P3fOqZDxBeGvRIRUqcDmtOeRQ71JamkiET0HGj8mn70=; b=OjDMHakP5f7+8rOqCDEc6HtsiLpK5yjAqjsgKTodAydrIa1Ey4QY03I0/DMaMzGiIb DDjJr4UnAWQPvw/aBiiYFog+6Na4+EQT71Tjaorb4FPZApih0ZXsgF7zAhKxA3CPFSFH rfz9gnBGfB1Ngo9rqaWTqFj2lt51YDK9CHYdkYViAvFcTOoe8ck54Na5+jz2jlzPQPiU XETbbbpS9Ze1+hSvl1a6WhwyUyolMBmij0Q9NOpOxYdT361zh2Ok2dCOpY9GX6fdTqJx 2MlFqV03JMKm1EOeYN+MVu63SOe9yqVmoJW16I8+WJrRGWL+HX+gnVYzbDm4uWhaiPAf +XLQ== X-Forwarded-Encrypted: i=1; AJvYcCVauQ2UQb8FBAiqCR8I9fxjsdb8OXrRvpbIBLdDd+mlHE3Ywq0KKqc7TY68c/DiIihjqxAtpqvPzEvay+2iE77G@lists.infradead.org X-Gm-Message-State: AOJu0Yzron2x0MvlAwfThEyxj+uI49VWaiJh01aF38I4D+vTVVg3wIHt bu29RrN/lx6dOitLU6sIkP5F4BNbw8r7gX0uM7mhB0l4Hn1VN35z3o/sneV2YQ4= X-Gm-Gg: ASbGncvzivQ/PldMlmfmQCL6bN2ilP2uIruV3ta1ZfHQBcq8Nb/Nc5goKAhbBMFgM0C tWGRpzzgpIiFXe3rQnPv4a8M60wdzK8soiWlk7df6ddSQpgzE3m4rxPyudTfbRCdtNR/YdUPasL qmPYYhJC2+mLpIZB+cDMOTK/YteCa3jj1RRf85S17RhW9eSXGbWas6Je330i8vW6ftZOgOExdkU iiFEXZ1y74z4lnTgT0egt7kWWSEYbW5F3clAvZV5mycnns7Z3iILw9BIyJJHBjzRujtp6NwVtkh o60XOtQprvk2+8WKE3XkM6XXrNrK1aUbQyzCjYoY4AdCn2wxlC4E6Iz9uHQ8BZyU4HTIAgVwSNR uf2gx9TjEEAOXl0OlcdPWxfmmUN0= X-Google-Smtp-Source: AGHT+IHJuWMraf2Rg5PhLN6Df1HN4IcFp4yjz25Ca2aiIRnrBI5pfymQKmIjo+to0QjALf4ZkpSB8Q== X-Received: by 2002:a17:907:6eab:b0:ac7:d101:2a with SMTP id a640c23a62f3a-acabd3b9653mr8791266b.48.1744231054640; Wed, 09 Apr 2025 13:37:34 -0700 (PDT) Received: from puffmais.c.googlers.com (40.162.204.35.bc.googleusercontent.com. [35.204.162.40]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1ccc001sm145850366b.126.2025.04.09.13.37.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Apr 2025 13:37:34 -0700 (PDT) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Wed, 09 Apr 2025 21:37:31 +0100 Subject: [PATCH v4 10/32] mfd: sec: Merge separate core and irq modules MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20250409-s2mpg10-v4-10-d66d5f39b6bf@linaro.org> References: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> In-Reply-To: <20250409-s2mpg10-v4-0-d66d5f39b6bf@linaro.org> To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250409_133736_401924_CC811113 X-CRM114-Status: GOOD ( 13.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There is no reason to have these two kernel modules separate. Having them merged into one kernel module also slightly reduces memory consumption and module load times a little. mapped size (lsmod): before: after: sec_core 20480 sec_core 24576 sec_irq 16384 ---------------- total 36864 Section sizes (size -A): before: after: sec_core 6780 sec_core 13239 sec_irq 8046 ---------------- Total 14826 Reviewed-by: Krzysztof Kozlowski Signed-off-by: André Draszik --- Checkpatch suggests to update MAINTAINERS, but the new file is covered already due to using a wildcard. --- drivers/mfd/Makefile | 3 ++- drivers/mfd/{sec-core.c => sec-common.c} | 2 ++ drivers/mfd/sec-irq.c | 9 --------- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index b617782eca436e34084a9cd24c309801c5680390..8f315298b32a2a9ee114ed5e49e760bd8f930aee 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -228,7 +228,8 @@ obj-$(CONFIG_MFD_RK8XX) += rk8xx-core.o obj-$(CONFIG_MFD_RK8XX_I2C) += rk8xx-i2c.o obj-$(CONFIG_MFD_RK8XX_SPI) += rk8xx-spi.o obj-$(CONFIG_MFD_RN5T618) += rn5t618.o -obj-$(CONFIG_MFD_SEC_CORE) += sec-core.o sec-irq.o +sec-core-objs := sec-common.o sec-irq.o +obj-$(CONFIG_MFD_SEC_CORE) += sec-core.o obj-$(CONFIG_MFD_SEC_ACPM) += sec-acpm.o obj-$(CONFIG_MFD_SEC_I2C) += sec-i2c.o obj-$(CONFIG_MFD_SYSCON) += syscon.o diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-common.c similarity index 98% rename from drivers/mfd/sec-core.c rename to drivers/mfd/sec-common.c index c4b7abe511090d8f5ff2eb501f325cc8173b9bf5..782dec1956a5fd7bf0dbb2159f9d222ad3fea942 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-common.c @@ -307,6 +307,8 @@ static int sec_pmic_resume(struct device *dev) DEFINE_SIMPLE_DEV_PM_OPS(sec_pmic_pm_ops, sec_pmic_suspend, sec_pmic_resume); EXPORT_SYMBOL_GPL(sec_pmic_pm_ops); +MODULE_AUTHOR("Chanwoo Choi "); +MODULE_AUTHOR("Krzysztof Kozlowski "); MODULE_AUTHOR("Sangbeom Kim "); MODULE_DESCRIPTION("Core driver for the Samsung S5M"); MODULE_LICENSE("GPL"); diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index e9beaa2a53fb42120eeb465a7c19acb4af6a0e59..b75d7fe86253037b4b7256a4d8c089003d58bc44 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -6,7 +6,6 @@ #include #include #include -#include #include #include #include @@ -17,7 +16,6 @@ #include #include #include -#include #include #include "sec-core.h" @@ -510,10 +508,3 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) return 0; } -EXPORT_SYMBOL_GPL(sec_irq_init); - -MODULE_AUTHOR("Sangbeom Kim "); -MODULE_AUTHOR("Chanwoo Choi "); -MODULE_AUTHOR("Krzysztof Kozlowski "); -MODULE_DESCRIPTION("Interrupt support for the S5M MFD"); -MODULE_LICENSE("GPL"); -- 2.49.0.604.gff1f9ca942-goog