From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C95F6C369A5 for ; Wed, 9 Apr 2025 23:39:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NKOMm9lLgvb/F18kqPd+NqbO3iD1QOhWvXonfY0dLd0=; b=Qqq14dEWOK3osXYNcYiu9AsEYX lnO0GnQd28pVMap8LS3IUB8420vJsO+IzxDxV3xX+NKhy7gFycBGaXlusPiQF5FN0yJdlw5ZIKtqO Op3v4vuE3ngiANi+oBu5/6uoeeGvP66/mRVp0y07Fjy8INDMuqP5lQOisOuNpbbHnlRkfVltZOqGh WSlg6LbcZDKVSnXCgBqOnHsrk7GTBU9boUSb6jR7eWKZjyZiwhJyE3Mya+jlyfh9f2GP3okI1tPbK i2pyxxpQmcJWvCBKV7uL7SAaUA1X02FcLH8U4tSILeGDzjAArSJmBzQVNshIB5ikUwyDeNw28aR77 aivPNmjQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2f0z-00000008mVx-0Yg1; Wed, 09 Apr 2025 23:39:29 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u2ezD-00000008mS0-12Oy; Wed, 09 Apr 2025 23:37:39 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id CE7E761127; Wed, 9 Apr 2025 23:37:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 157BBC4CEE2; Wed, 9 Apr 2025 23:37:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744241858; bh=fn3kK6il9AD7bbyhGbo7s4pLFMPkWIgx39JLPgek8Gw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lMHIfp9N9b4AU82PF84cXzGFVf0BQn2dXv8FXhAnXKy5a0Qohkexq7ua9cJJQaN+R qkpnhLZs0cT37kuiyh07Zyti4dkbvQKSDPTkJsWKEd+l6W8ygLXbKqxtbL7r3PubfA sACc7DcndTkjnFvyb/5fy6HFSRx0JKB/ZyBTwWbhSmNvkt+PZn1L3+7IBgDXLkTbL/ 4I0SZhBwBo1iJpDVtNvI7oU2cfj4UmsmypODzhPCwZ6IC/OtGvGi2R0+Z7ST9UJQyr R2QYvEEf60muOa7hVqZ54LGG33k7QQ3aA+kyVuyAQmhNDu0tG2yCCRRbsPUqplPi2N VIoMKhSHZQLSg== Date: Wed, 9 Apr 2025 16:37:37 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, netdev@vger.kernel.org, Davide Caratti Subject: Re: [PATCH net-next v2] net: airoha: Add matchall filter offload support Message-ID: <20250409163737.2b6c13e3@kernel.org> In-Reply-To: <20250409-airoha-hw-rx-ratelimit-v2-1-694e4fda5c91@kernel.org> References: <20250409-airoha-hw-rx-ratelimit-v2-1-694e4fda5c91@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 09 Apr 2025 01:15:32 +0200 Lorenzo Bianconi wrote: > + airoha_fe_wr(eth, REG_PPE_DFT_CPORT0(0), > + FIELD_PREP(DFT_CPORT_MASK(7), FE_PSE_PORT_CDM1) | > + FIELD_PREP(DFT_CPORT_MASK(6), FE_PSE_PORT_CDM1) | > + FIELD_PREP(DFT_CPORT_MASK(5), FE_PSE_PORT_CDM1) | > + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM1) | > + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM1) | Coccicheck spotted that the previous line is duplicated.. > + FIELD_PREP(DFT_CPORT_MASK(3), FE_PSE_PORT_CDM1) | > + FIELD_PREP(DFT_CPORT_MASK(2), FE_PSE_PORT_CDM1) | > + FIELD_PREP(DFT_CPORT_MASK(1), FE_PSE_PORT_CDM1) | > + FIELD_PREP(DFT_CPORT_MASK(0), FE_PSE_PORT_CDM1)); > + airoha_fe_wr(eth, REG_PPE_DFT_CPORT0(1), > + FIELD_PREP(DFT_CPORT_MASK(7), FE_PSE_PORT_CDM2) | > + FIELD_PREP(DFT_CPORT_MASK(6), FE_PSE_PORT_CDM2) | > + FIELD_PREP(DFT_CPORT_MASK(5), FE_PSE_PORT_CDM2) | > + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM2) | > + FIELD_PREP(DFT_CPORT_MASK(4), FE_PSE_PORT_CDM2) | .. and here. > + FIELD_PREP(DFT_CPORT_MASK(3), FE_PSE_PORT_CDM2) | > + FIELD_PREP(DFT_CPORT_MASK(2), FE_PSE_PORT_CDM2) | > + FIELD_PREP(DFT_CPORT_MASK(1), FE_PSE_PORT_CDM2) | > + FIELD_PREP(DFT_CPORT_MASK(0), FE_PSE_PORT_CDM2)); -- pw-bot: cr