Re: [PATCH v2 01/12] dt-bindings: mediatek: Add mediatek, mt8196-jpgdec compatible

Krzysztof Kozlowski
2025-04-12T10:15:41Z

On 11/04/2025 04:54, Kyrie Wu (吴晗) wrote:
> On Thu, 2025-04-10 at 08:39 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On Thu, Apr 10, 2025 at 02:29:54PM GMT, kyrie.wu wrote:
>>> Add mediatek,mt8196-jpgdec compatible to binding document.
>>>
>>> Signed-off-by: kyrie.wu <kyrie.wu@mediatek.com>
>>
>> Usual mediatek comment - looks like copy paste of username. Please
>> reach
>> to your colleagues how to fix it.
>
> Dear Krzysztof,
>
> Do I need to change the username like that: Kyrie Wu <
> kyrie.wu@mediatek.com>?

And what did your colleagues say? Please use Mediatek resources prior
asking community for review.

>
> Thanks.
>>
>>> ---
>>> .../bindings/media/mediatek,mt8195-jpegdec.yaml | 8
>>> ++++++--
>>> 1 file changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> b/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> index e5448c60e3eb..28a9a9bfdbf8 100644
>>> --- a/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> +++ b/Documentation/devicetree/bindings/media/mediatek,mt8195-
>>> jpegdec.yaml
>>> @@ -14,7 +14,9 @@ description:
>>>
>>> properties:
>>> compatible:
>>> - const: mediatek,mt8195-jpgdec
>>> + enum:
>>> + - mediatek,mt8195-jpgdec
>>> + - mediatek,mt8196-jpgdec
>>
>> And devices are not compatible?
>
> Sorry, I don't understand the question exactly. Do you mean using the
> compatible string of MT8195 for both MT8195 and MT8196?

No, expressing compatibility with fallbacks or explaining in commit msg
the hardware, e.g. why these are not compatible.

Best regards,
Krzysztof