From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-crypto@vger.kernel.org
Cc: "Olivia Mackall" <olivia@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
"Sean Wang" <sean.wang@mediatek.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Avi Fishman" <avifishman70@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, openbmc@lists.ozlabs.org
Subject: [PATCH 1/3] hwrng: atmel - Add a local variable for struct device pointer
Date: Thu, 10 Apr 2025 10:06:21 +0300 [thread overview]
Message-ID: <20250410070623.3676647-2-sakari.ailus@linux.intel.com> (raw)
In-Reply-To: <20250410070623.3676647-1-sakari.ailus@linux.intel.com>
Add a local variable for a struct device pointer instead of obtaining the
hwrng priv field and casting it as a struct device pointer whenever it's
needed.
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
drivers/char/hw_random/atmel-rng.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/char/hw_random/atmel-rng.c b/drivers/char/hw_random/atmel-rng.c
index 143406bc6939..5192c39ebaeb 100644
--- a/drivers/char/hw_random/atmel-rng.c
+++ b/drivers/char/hw_random/atmel-rng.c
@@ -56,12 +56,13 @@ static int atmel_trng_read(struct hwrng *rng, void *buf, size_t max,
bool wait)
{
struct atmel_trng *trng = container_of(rng, struct atmel_trng, rng);
+ struct device *dev = (struct device *)trng->rng.priv;
u32 *data = buf;
int ret;
- ret = pm_runtime_get_sync((struct device *)trng->rng.priv);
+ ret = pm_runtime_get_sync(dev);
if (ret < 0) {
- pm_runtime_put_sync((struct device *)trng->rng.priv);
+ pm_runtime_put_sync(dev);
return ret;
}
@@ -79,8 +80,8 @@ static int atmel_trng_read(struct hwrng *rng, void *buf, size_t max,
ret = 4;
out:
- pm_runtime_mark_last_busy((struct device *)trng->rng.priv);
- pm_runtime_put_sync_autosuspend((struct device *)trng->rng.priv);
+ pm_runtime_mark_last_busy(dev);
+ pm_runtime_put_sync_autosuspend(dev);
return ret;
}
--
2.39.5
next prev parent reply other threads:[~2025-04-10 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 7:06 [PATCH 0/3] Use a local device pointer for hwrng drivers instead of casting constantly Sakari Ailus
2025-04-10 7:06 ` Sakari Ailus [this message]
2025-04-10 7:42 ` [PATCH 1/3] hwrng: atmel - Add a local variable for struct device pointer Herbert Xu
2025-04-10 15:15 ` Sakari Ailus
2025-04-10 7:06 ` [PATCH 2/3] hwrng: mtk " Sakari Ailus
2025-04-10 7:06 ` [PATCH 3/3] hwrng: npcm " Sakari Ailus
2025-04-10 9:59 ` kernel test robot
2025-04-10 15:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410070623.3676647-2-sakari.ailus@linux.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=avifishman70@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=nicolas.ferre@microchip.com \
--cc=olivia@selenic.com \
--cc=openbmc@lists.ozlabs.org \
--cc=sean.wang@mediatek.com \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).