From: Nishanth Menon <nm@ti.com>
To: Dominik Haller <D.Haller@phytec.de>
Cc: "robh@kernel.org" <robh@kernel.org>,
"kristo@kernel.org" <kristo@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"m-chawdhry@ti.com" <m-chawdhry@ti.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"upstream@lists.phytec.de" <upstream@lists.phytec.de>
Subject: Re: [PATCH 2/2] arm64: dts: ti: Add basic support for phyBOARD-Izar-AM68x
Date: Mon, 14 Apr 2025 07:11:29 -0500 [thread overview]
Message-ID: <20250414121129.srke66ozlydeceux@widget> (raw)
In-Reply-To: <0f37e6867a057c713f9da7b3bdfac06bdc7f4184.camel@phytec.de>
On 11:28-20250414, Dominik Haller wrote:
> On Fri, 2025-04-11 at 07:29 -0500, Nishanth Menon wrote:
> > Quick look comments below.
> >
> > On 12:10-20250411, Dominik Haller wrote:
> > > The phyCORE-AM68x/TDA4x [1] is a SoM (System on Module) featuring
> > > TI's
> > > AM68x/TDA4x SoC. It can be used in combination with different
> > > carrier
> > > boards. This module can come with different sizes and models for
> > > DDR,
> > > eMMC, SPI NOR Flash and various SoCs from the AM68x/TDA4x (J721S2)
> > > family.
> > >
> > > A reference carrier board design, called phyBOARD-Izar is used for
> > > the
> > > phyCORE-AM68x/TDA4x development kit [2].
> > >
> > > Supported features:
> > > * Debug UART
> > > * 2x SPI NOR Flash
> > > * eMMC
> > > * 2x Ethernet
> > > * Micro SD card
> > > * I2C EEPROM
> > > * I2C RTC
> > > * 2x I2C GPIO Expander
> > > * LEDs
> > > * USB 5 Gbit/s
> > > * PCIe
> >
> > Can we drop the whitespace prefix?
> >
> > >
> > > For more details see the product pages for the SoM and the
> > > development kit:
> > >
> > > [1]
> > > https://www.phytec.eu/en/produkte/system-on-modules/phycore-am68x-tda4x/
> > > [2]
> > > https://www.phytec.eu/en/produkte/development-kits/phyboard-izar/
> > >
> > > Signed-off-by: Dominik Haller <d.haller@phytec.de>
> > > ---
> >
> > Could you share the bootlog in the diffstat along with output of
> > deferred_devices Using the default defconfig -> I want to make sure
> > there are no defconfig updates needed.
> I'll add a bootlog using the default defconfig to the v2 with the style
> fixes.
> deferred_devices is empty.
> PCIe and the TMP102 temperature sensors are not enabled with the
> defconfig as of v6.15-rc1. I plan to send a separate patch with
> CONFIG_SENSORS_TMP102=m but if you can queue that in with the
> devicetree I can simply add that to this series.
you can post it as a single series and I can pick to the correct
branches.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
prev parent reply other threads:[~2025-04-14 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-11 10:10 [PATCH 1/2] dt-bindings: arm: ti: Add bindings for PHYTEC AM68x based hardware Dominik Haller
2025-04-11 10:10 ` [PATCH 2/2] arm64: dts: ti: Add basic support for phyBOARD-Izar-AM68x Dominik Haller
2025-04-11 12:29 ` Nishanth Menon
2025-04-14 11:28 ` Dominik Haller
2025-04-14 12:11 ` Nishanth Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250414121129.srke66ozlydeceux@widget \
--to=nm@ti.com \
--cc=D.Haller@phytec.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=m-chawdhry@ti.com \
--cc=robh@kernel.org \
--cc=upstream@lists.phytec.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).