From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF33FC369AB for ; Tue, 15 Apr 2025 11:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=izSPy9yN5eadW5G0HXPfjkBbOQOu24hDdeaTSQaukE4=; b=aAFE4wUnXC4OQOmnMd6k83nEZl 1tUCpMYKF1sfsQKuSYHwIC7pX5XRg2bevRN59pMJKUWzqV/0asA8J2J4uQI/gRIqemeCCQ9zv0ubK nIIeCE/ST0eEXcQHRHlm4cr8fpjT2TnHtlvcvxbogqxyxNDW3CUe4rgPojwboEJJiHKegSb8K8hz1 0eOyEu03Y32tjO6LPnYX5VzWOjCbs7+iMAMIJipu6CerbzqFLmBHfGHH9x8KmuexgdD4dfYBuSMRB bKBygVfgEoPdLwPfgPMX1v4pB1FY/xs8TW96fSTBQ7zTZ0QqNYrcz2MycJ6RlC7U1fGNuN79/LIb3 N+7as9Pw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4eWA-00000005YXt-41wj; Tue, 15 Apr 2025 11:31:54 +0000 Received: from relay3-d.mail.gandi.net ([217.70.183.195]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4dq2-00000005Oww-14ap for linux-arm-kernel@lists.infradead.org; Tue, 15 Apr 2025 10:48:24 +0000 Received: by mail.gandi.net (Postfix) with ESMTPSA id EE0541FCF2; Tue, 15 Apr 2025 10:48:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1744714099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=izSPy9yN5eadW5G0HXPfjkBbOQOu24hDdeaTSQaukE4=; b=ObcvX56MZ0k9lGklXRSsumGr3d6Q2N9qZNknU+xGzaQEh/9/n7F0JIcgXEseF8HSX0jEiX sR97CSdk8GVNDaWvSeeHJTZw8VtHRHZV/F98Y47kwA2UccLMXi8RAiRNS7Kqw5baAbunRi Od6O+Cs4TZPq13kYRPRTyFGZSjTE6NwkvdtsDV5HzC63NaQHi/KMIdSLCPnfH4I4B9datU /jd+GYFEJ6C9fkglfF5bAPx27cgqEhoRTTg0W2t6blVkMVX6K9z7736NgDavd+IlpuvOA9 zMCnRher3BipFMGTfhXK0PIA9Sp4Zr84gAChBb9zd4O1OfjhijETYNN5tmOlaA== Date: Tue, 15 Apr 2025 12:48:16 +0200 From: Maxime Chevallier To: "Russell King (Oracle)" Cc: Andrew Lunn , Heiner Kallweit , Alexandre Torgue , Andrew Lunn , Chen-Yu Tsai , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jernej Skrabec , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-sunxi@lists.linux.dev, Maxime Coquelin , netdev@vger.kernel.org, Paolo Abeni , Samuel Holland Subject: Re: [PATCH net-next] net: stmmac: sun8i: use stmmac_pltfr_probe() Message-ID: <20250415124816.1a420410@fedora.home> In-Reply-To: References: Organization: Bootlin X-Mailer: Claws Mail 4.3.1 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgddvvdefvdelucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvvefukfgjfhhoofggtgfgsehtjeertdertddvnecuhfhrohhmpeforgigihhmvgcuvehhvghvrghllhhivghruceomhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepgeevledtvdevueehhfevhfelhfekveeftdfgiedufeffieeltddtgfefuefhueeknecukfhppedvrgdtudemtggsudelmeekugegheemgeeltddtmeeiheeikeemvdelsgdumeelvghfheemvgektgejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepvdgrtddumegtsgduleemkegugeehmeegledttdemieehieekmedvlegsudemlegvfhehmegvkegtjedphhgvlhhopehfvgguohhrrgdrhhhomhgvpdhmrghilhhfrhhomhepmhgrgihimhgvrdgthhgvvhgrlhhlihgvrhessghoohhtlhhinhdrtghomhdpnhgspghrtghpthhtohepudejpdhrtghpthhtoheprhhmkhdokhgvrhhnvghlsegrrhhmlhhinhhugidrohhrghdruhhkpdhrtghpthhtoheprghnughrvgifsehluhhnnhdrtghhpdhrtghpthhtohephhhkrghllhifvghithdusehgmhgrihhlrdgto hhmpdhrtghpthhtoheprghlvgigrghnughrvgdrthhorhhguhgvsehfohhsshdrshhtrdgtohhmpdhrtghpthhtoheprghnughrvgifodhnvghtuggvvheslhhunhhnrdgthhdprhgtphhtthhopeifvghnshestghsihgvrdhorhhgpdhrtghpthhtohepuggrvhgvmhesuggrvhgvmhhlohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgtohhm X-GND-Sasl: maxime.chevallier@bootlin.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250415_034822_989337_D81EA43E X-CRM114-Status: UNSURE ( 8.01 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Russell, On Tue, 15 Apr 2025 11:15:53 +0100 "Russell King (Oracle)" wrote: > Using stmmac_pltfr_probe() simplifies the probe function. This will not > only call plat_dat->init (sun8i_dwmac_init), but also plat_dat->exit > (sun8i_dwmac_exit) appropriately if stmmac_dvr_probe() fails. This > results in an overall simplification of the glue driver. > > Signed-off-by: Russell King (Oracle) Reviewed-by: Maxime Chevallier Maxime