From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8E78C369AB for ; Tue, 15 Apr 2025 16:40:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uf3w369MyYUHM4rPlLnZdm1b0aSBV06F/8EqSZNvqJU=; b=dr6RqKnroPYHemJkW3jIQPCJz8 Zup5aOR11TrVfs27IqZp5/YIIe5VjgcPGim6Lo6qXu3sx91LvxLU8SwGHkN8AyMCo6PAM+uudk+xg 44xMl+2yxt9zeVOFsR/Rw4nrtUo7Fwi1osdJtP1k7SW5RC9SnaS1UdQoe2uKzifxB3sK7r2am7huZ WpsQX18d4a+ZWCk/ErVsdLuv2Cmeum6WKlebDxj9GZs2LnnMo40zVDA9UV7spr/jt0Zjqf3Mz8IPB ObZaRFrnYZL1VydDFX7NUDWwzqZvMQMwR3ReNIKRxm+BH3yjghmbL5sKdr1zhPT4cbsdN8kMcLckq +ypWqu5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4jL0-00000006Raw-1adP; Tue, 15 Apr 2025 16:40:42 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u4iw6-00000006Nds-2O1l for linux-arm-kernel@lists.infradead.org; Tue, 15 Apr 2025 16:15:00 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 420CC43C6E; Tue, 15 Apr 2025 16:14:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 743E4C4CEEB; Tue, 15 Apr 2025 16:14:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1744733698; bh=U/rKNYDUD8j6QMOYLJ34Ll3gyPFM6SLKNxk//x2JQP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pztQCA3m4GCim/1wSoY8Mu8F8hiIGUr0WM7lChdgo6fkoAulk7Da+VoWMtvINe60v o0eezdUCv+z2WE8DZF6zM1Ra2I8U+5eiZLlBGNASYIpAQD0Z16N9YYS0vmCWJ1gINx ehq9XyP/8CEQDI9/XyTxr1znYNaP1Pjy2m31UCRc= Date: Tue, 15 Apr 2025 18:14:55 +0200 From: Greg Kroah-Hartman To: Andrea della Porta Cc: Herve Codina , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Manivannan Sadhasivam , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn , Phil Elwell , Dave Stevenson , kernel-list@raspberrypi.com Subject: Re: [PATCH v8 08/13] misc: rp1: RaspberryPi RP1 misc driver Message-ID: <2025041530-random-cheek-125d@gregkh> References: <3fbc487bc0e4b855ffbee8ed62cfb6bf3b0592e8.1742418429.git.andrea.porta@suse.com> <2025041557-masculine-abrasive-c372@gregkh> <20250415165505.0c05bc61@bootlin.com> <2025041531-dubiously-duchess-276a@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250415_091458_642182_4CDB0B28 X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 15, 2025 at 05:41:26PM +0200, Andrea della Porta wrote: > Hi Greg, > > On 17:14 Tue 15 Apr , Greg Kroah-Hartman wrote: > > On Tue, Apr 15, 2025 at 04:55:05PM +0200, Herve Codina wrote: > > > Hi Greg, > > > > > > On Tue, 15 Apr 2025 16:06:43 +0200 > > > Greg Kroah-Hartman wrote: > > > > > > > On Wed, Mar 19, 2025 at 10:52:29PM +0100, Andrea della Porta wrote: > > > > > The RaspberryPi RP1 is a PCI multi function device containing > > > > > peripherals ranging from Ethernet to USB controller, I2C, SPI > > > > > and others. > > > > > > > > So shouldn't this be using the auxbus code? That's designed to "split > > > > up" PCI devices such that you can share them this way. > > > > > > > > Or did that get rejected somewhere previously? > > > > > > > > > > It doesn't use auxbus probably for the exact same reason that the > > > one given for the LAN966x PCI device driver [0] and [1]. > > > > > > Avoid all boiler plate needed with auxbus whereas drivers already exist > > > as platform drivers. Internal devices are handled by those platform drivers. > > > Those devi just need to be described as platform devices and device-tree is > > > fully relevant for that description. > > > > > > [0] https://lore.kernel.org/all/CAL_Jsq+1r3SSaXupdNAcXO-4rcV-_3_hwh0XJaBsB9fuX5nBCQ@mail.gmail.com/ > > > [1] https://lore.kernel.org/all/Y9kuxrL3XaCG+blk@kroah.com/ > > > > I really hate creating platform devices below a PCI device, so I'll keep > > complaining about this every time people try to do it. > > I agree with you, but as Herve has already pointed out this would mean incurring > in significant work to adapt drivers for all the peripherals (there are quite a > few), while with this approach they would be left untouched. We have no problem with reworking existing drivers, especially if they will be doing the correct thing. Don't let that be an excuse, it doesn't work with me, sorry :) greg k-h