From: Srinivas Kandagatla <srini@kernel.org>
To: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc: fnkl.kernel@gmail.com, Sven Peter <sven@svenpeter.dev>,
Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Hector Martin <marcan@marcan.st>
Subject: Re: [PATCH 2/3] nvmem: Add spmi-nvmem driver
Date: Thu, 17 Apr 2025 14:57:02 +0100 [thread overview]
Message-ID: <20250417135702.GA30334@srini-hackbase> (raw)
In-Reply-To: <aAEG6D2hjtVOlhS4@blossom>
On Thu, Apr 17, 2025 at 09:49:28AM -0400, Alyssa Rosenzweig wrote:
> > > +config NVMEM_SPMI
> > > + tristate "Generic SPMI NVMEM"
> > > + default ARCH_APPLE
> > Why default is set to ARCH_APPLE?
> >
> > This will endup with y in arm64 defconfig, means increasing the size of
> > kernel.
>
> I mean, eventually I think we /do/ want M1 properly supported in the
> arm64 defconfig, no? I'm not sure what the criteria is for any other
> driver to be defconfig or not, though.
cat arch/arm64/configs/defconfig | grep APPLE
CONFIG_ARCH_APPLE=y
Criteria for other drivers default should be not selected,
and should be module if they are part of defconfig, rather than
inbuilt. Not sure how most of the ARCH_APPLE drivers ended up using
default ARCH_APPLE.
--srini
next prev parent reply other threads:[~2025-04-17 13:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 21:52 [PATCH 0/3] Generic SPMI NVMEM cell driver Sasha Finkelstein via B4 Relay
2025-04-15 21:52 ` [PATCH 1/3] dt-bindings: spmi: Add generic SPMI NVMEM Sasha Finkelstein via B4 Relay
2025-04-16 0:18 ` Nick Chan
2025-04-16 7:39 ` Sasha Finkelstein
2025-04-15 21:52 ` [PATCH 2/3] nvmem: Add spmi-nvmem driver Sasha Finkelstein via B4 Relay
2025-04-16 1:40 ` Neal Gompa
2025-04-16 18:09 ` Alyssa Rosenzweig
2025-04-17 13:34 ` Srinivas Kandagatla
2025-04-17 13:49 ` Alyssa Rosenzweig
2025-04-17 13:57 ` Srinivas Kandagatla [this message]
2025-04-17 13:59 ` Alyssa Rosenzweig
2025-04-17 14:27 ` Sasha Finkelstein
2025-04-17 14:30 ` Janne Grunau
2025-04-17 14:50 ` Srinivas Kandagatla
2025-04-15 21:52 ` [PATCH 3/3] arm64: dts: apple: Add PMU NVMEM Sasha Finkelstein via B4 Relay
2025-04-16 0:28 ` Nick Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250417135702.GA30334@srini-hackbase \
--to=srini@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fnkl.kernel@gmail.com \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).