From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDCFDC369CA for ; Thu, 17 Apr 2025 17:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3eZBGF+VWpYQsOO3No7qlDnw3UtZvDcd5qZhhh+jPCE=; b=GgKTd/yWVBwiUnknrEPFMUF0X7 3x334//oYtD4Ejmt7fWejPI96BBZOs2knCRVw199myw8ZbJqdyTJqjAtPdmgYpGvZkBDAJKS9AI5D cUYNoDfYc4ZssWzpfABKnN0PfEBqgvbOEKKvhAczJ0GiSbDjmtjVce8FCyERcsIyhZSjCSbWdLG1D NNcftsIfCp1VNBwsCqZFc+sDPh9ZpsO/QU2Gc0GXRXmcEYO+HruZ94E064NxErpiJ5EzhfPjsZLlQ YxxKtJDEUrtxb7cOLeOzWUDQ+06G45xGBk4ZhRwqWkDT5r1tfCY92thwhYzvFLOgiQKRWkAtD32vr GdlcjjzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u5TW3-0000000DwXe-2004; Thu, 17 Apr 2025 17:59:11 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u5T3A-0000000Dqlw-3o4O; Thu, 17 Apr 2025 17:29:22 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4ZdlBd67RWz6K8r4; Fri, 18 Apr 2025 01:24:41 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 71D3D140145; Fri, 18 Apr 2025 01:28:59 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 17 Apr 2025 19:28:58 +0200 Date: Thu, 17 Apr 2025 18:28:57 +0100 From: Jonathan Cameron To: David Lechner CC: Jonathan Cameron , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno , Lars-Peter Clausen , Michael Hennerich , "Cosmin Tanislav" , Tomasz Duszynski , Jean-Baptiste Maneyrol , Andreas Klinger , "Petre Rodan" , , , , Subject: Re: [PATCH 1/8] iio: adc: dln2-adc: use aligned_s64 for timestamp Message-ID: <20250417182857.00002561@huawei.com> In-Reply-To: <20250417-iio-more-timestamp-alignment-v1-1-eafac1e22318@baylibre.com> References: <20250417-iio-more-timestamp-alignment-v1-0-eafac1e22318@baylibre.com> <20250417-iio-more-timestamp-alignment-v1-1-eafac1e22318@baylibre.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500011.china.huawei.com (7.191.174.215) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250417_102921_093064_34FA66C6 X-CRM114-Status: GOOD ( 14.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 17 Apr 2025 11:52:33 -0500 David Lechner wrote: > Follow the pattern of other drivers and use aligned_s64 for the > timestamp. This will ensure the struct itself it also 8-byte aligned. > > Signed-off-by: David Lechner > --- > drivers/iio/adc/dln2-adc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/dln2-adc.c b/drivers/iio/adc/dln2-adc.c > index a1e48a756a7b519105393f77c4aebde1f2f85d50..359e26e3f5bcfe16d723f621bdfc01df2dfcf6a9 100644 > --- a/drivers/iio/adc/dln2-adc.c > +++ b/drivers/iio/adc/dln2-adc.c > @@ -466,7 +466,7 @@ static irqreturn_t dln2_adc_trigger_h(int irq, void *p) > struct iio_dev *indio_dev = pf->indio_dev; > struct { > __le16 values[DLN2_ADC_MAX_CHANNELS]; > - int64_t timestamp_space; > + aligned_s64 timestamp_space; Bug :( So needs a fixes tag ideally. Fine to just reply with one (or I might go digging if I get time). > } data; > struct dln2_adc_get_all_vals dev_data; > struct dln2_adc *dln2 = iio_priv(indio_dev); >