From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D220C369C9 for ; Thu, 17 Apr 2025 18:16:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:CC:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EbZjd+gpzkVwn2hKSssn20fBUWsoEERWHneENP+AQaI=; b=xe74vUYhBmz5NJk595dCSOTxCm rKAKLVzEUCe88B5raq5xAa6yC1MgZUgpeYmzX5KfFKnVXItbnwgooKdbaULd5vJ367GI4aILTiEq5 p8vxJHrynWGzEBsWD3nkU/2XFi59istD404iEFWKfeJbWu+HFy7pIm8afc85/OjSRIT74bGBaCWDT ntlMe5yYdVnPI/M0KQgMMY+OFt0CqEyK/qb3GRmRUNj3cCpikMJ2G+F2xt8Y4Uh+EprNANd/P3mAq iRRlxugCRtd7g5tYRebAHB2jThov4AiVXES94uNt1BiaK9timFAAPm57RlxgVxMyjQe8DFLfil7FQ kr3SARAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1u5TmX-0000000DzOs-3Srb; Thu, 17 Apr 2025 18:16:13 +0000 Received: from frasgout.his.huawei.com ([185.176.79.56]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1u5TMJ-0000000DunO-0Gdc; Thu, 17 Apr 2025 17:49:08 +0000 Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Zdlf45xxcz6M4Mj; Fri, 18 Apr 2025 01:45:00 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 99ED6140145; Fri, 18 Apr 2025 01:49:01 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 17 Apr 2025 19:49:00 +0200 Date: Thu, 17 Apr 2025 18:48:59 +0100 From: Jonathan Cameron To: David Lechner CC: Jonathan Cameron , Nuno =?ISO-8859-1?Q?S=E1?= , Andy Shevchenko , Matthias Brugger , AngeloGioacchino Del Regno , Lars-Peter Clausen , Michael Hennerich , "Cosmin Tanislav" , Tomasz Duszynski , Jean-Baptiste Maneyrol , Andreas Klinger , "Petre Rodan" , , , , Subject: Re: [PATCH 8/8] iio: pressure: mprls0025pa: use aligned_s64 for timestamp Message-ID: <20250417184859.000022a3@huawei.com> In-Reply-To: <20250417-iio-more-timestamp-alignment-v1-8-eafac1e22318@baylibre.com> References: <20250417-iio-more-timestamp-alignment-v1-0-eafac1e22318@baylibre.com> <20250417-iio-more-timestamp-alignment-v1-8-eafac1e22318@baylibre.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.203.177.66] X-ClientProxiedBy: lhrpeml500011.china.huawei.com (7.191.174.215) To frapeml500008.china.huawei.com (7.182.85.71) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250417_104907_253056_9C08624D X-CRM114-Status: GOOD ( 15.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 17 Apr 2025 11:52:40 -0500 David Lechner wrote: > Follow the pattern of other drivers and use aligned_s64 for the > timestamp. This will ensure the struct itself it also 8-byte aligned. > > Signed-off-by: David Lechner > --- > drivers/iio/pressure/mprls0025pa.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/pressure/mprls0025pa.h b/drivers/iio/pressure/mprls0025pa.h > index 9d5c30afa9d69a6a606662aa7906a76347329cef..9fe9eb35e79d992b2a576e5d0af71113c6c47400 100644 > --- a/drivers/iio/pressure/mprls0025pa.h > +++ b/drivers/iio/pressure/mprls0025pa.h > @@ -41,7 +41,7 @@ struct mpr_ops; > */ > struct mpr_chan { > s32 pres; > - s64 ts; > + aligned_s64 ts; > }; Whilst you are here, no point in there being a named type for this. Would you mind just pushing it into the struct mpr_data definition. Might be a bug (I can't be bothered to work out the structure padding to see if we end up with a gap after this) so fixes tag appropriate for this one I think. > > enum mpr_func_id { >