[PATCH v2] dt-bindings: pwm: vt8500-pwm: Convert to YAML

[PATCH v2] dt-bindings: pwm: vt8500-pwm: Convert to YAML

[Alexey Charkov]

Rewrite the textual description for the WonderMedia PWM controller
as YAML schema, and switch the filename to follow the compatible
string.

Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
Split the series from v1 into separate bindings patches so as not to
spam all the subsystems with unrelated changes, per Rob's suggestion

Changes in v2:
- reordered nodes in the example same as in properties (thanks Rob)

Link to v1: https://lore.kernel.org/all/20250416-wmt-updates-v1-5-f9af689cdfc2@gmail.com/
---
 .../devicetree/bindings/pwm/via,vt8500-pwm.yaml    | 43 ++++++++++++++++++++++
 .../devicetree/bindings/pwm/vt8500-pwm.txt         | 18 ---------
 MAINTAINERS                                        |  1 +
 3 files changed, 44 insertions(+), 18 deletions(-)

diff --git a/Documentation/devicetree/bindings/pwm/via,vt8500-pwm.yaml b/Documentation/devicetree/bindings/pwm/via,vt8500-pwm.yaml
new file mode 100644
index 0000000000000000000000000000000000000000..d9146ad715ba74c1f5641c33703ab06577fe80dc
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/via,vt8500-pwm.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/via,vt8500-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: VIA/Wondermedia VT8500/WM8xxx series SoC PWM controller
+
+maintainers:
+  - Alexey Charkov <alchark@gmail.com>
+
+allOf:
+  - $ref: pwm.yaml#
+
+properties:
+  compatible:
+    items:
+      - const: via,vt8500-pwm
+
+  reg:
+    maxItems: 1
+
+  '#pwm-cells':
+    const: 3
+
+  clocks:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - clocks
+
+additionalProperties: false
+
+examples:
+  - |
+    pwm1: pwm@d8220000 {
+        compatible = "via,vt8500-pwm";
+        reg = <0xd8220000 0x1000>;
+        #pwm-cells = <3>;
+        clocks = <&clkpwm>;
+    };
diff --git a/Documentation/devicetree/bindings/pwm/vt8500-pwm.txt b/Documentation/devicetree/bindings/pwm/vt8500-pwm.txt
deleted file mode 100644
index 4fba93ce1985a1e4c5a361423725fafb10eaa339..0000000000000000000000000000000000000000
--- a/Documentation/devicetree/bindings/pwm/vt8500-pwm.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-VIA/Wondermedia VT8500/WM8xxx series SoC PWM controller
-
-Required properties:
-- compatible: should be "via,vt8500-pwm"
-- reg: physical base address and length of the controller's registers
-- #pwm-cells: should be 3. See pwm.yaml in this directory for a description of
-  the cells format. The only third cell flag supported by this binding is
-  PWM_POLARITY_INVERTED.
-- clocks: phandle to the PWM source clock
-
-Example:
-
-pwm1: pwm@d8220000 {
-	#pwm-cells = <3>;
-	compatible = "via,vt8500-pwm";
-	reg = <0xd8220000 0x1000>;
-	clocks = <&clkpwm>;
-};
diff --git a/MAINTAINERS b/MAINTAINERS
index 96b82704950184bd71623ff41fc4df31e4c7fe87..b4a7e04e586bc0fa2913dc97b99ade0680510bf3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3428,6 +3428,7 @@ M:	Krzysztof Kozlowski <krzk@kernel.org>
 L:	linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:	Odd Fixes
 F:	Documentation/devicetree/bindings/i2c/i2c-wmt.txt
+F:	Documentation/devicetree/bindings/pwm/via,vt8500-pwm.yaml
 F:	arch/arm/boot/dts/vt8500/
 F:	arch/arm/mach-vt8500/
 F:	drivers/clocksource/timer-vt8500.c

---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250418-via_pwm_binding-32f7c4e5ede1

Best regards,
-- 
Alexey Charkov <alchark@gmail.com>

Re: [PATCH v2] dt-bindings: pwm: vt8500-pwm: Convert to YAML

[Rob Herring (Arm)]

On Fri, 18 Apr 2025 18:55:07 +0400, Alexey Charkov wrote:
> Rewrite the textual description for the WonderMedia PWM controller
> as YAML schema, and switch the filename to follow the compatible
> string.
> 
> Signed-off-by: Alexey Charkov <alchark@gmail.com>
> ---
> Split the series from v1 into separate bindings patches so as not to
> spam all the subsystems with unrelated changes, per Rob's suggestion
> 
> Changes in v2:
> - reordered nodes in the example same as in properties (thanks Rob)
> 
> Link to v1: https://lore.kernel.org/all/20250416-wmt-updates-v1-5-f9af689cdfc2@gmail.com/
> ---
>  .../devicetree/bindings/pwm/via,vt8500-pwm.yaml    | 43 ++++++++++++++++++++++
>  .../devicetree/bindings/pwm/vt8500-pwm.txt         | 18 ---------
>  MAINTAINERS                                        |  1 +
>  3 files changed, 44 insertions(+), 18 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH v2] dt-bindings: pwm: vt8500-pwm: Convert to YAML

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1103 bytes --]

On Fri, Apr 18, 2025 at 06:55:07PM +0400, Alexey Charkov wrote:
> Rewrite the textual description for the WonderMedia PWM controller
> as YAML schema, and switch the filename to follow the compatible
> string.
> 
> Signed-off-by: Alexey Charkov <alchark@gmail.com>
> ---
> Split the series from v1 into separate bindings patches so as not to
> spam all the subsystems with unrelated changes, per Rob's suggestion

That's a good suggestion.

Applied with Rob's R-b tag to
https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next
.

I saw you signed your patch using PGP, which is great. However I didn't
find your key. I recommend to make it available on keys.openpgp.org like
this:

	gpg --export alchark@gmail.com | curl -T - https://keys.openpgp.org

and then verify your identities using the link in the output of this
command. Still better, (additionally) add your key to the kernel keyring
(which however requires you to be in Linus Torvalds WoT, see
https://korg.docs.kernel.org/pgpkeys.html for the details).

Thanks for your contribution,
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2] dt-bindings: pwm: vt8500-pwm: Convert to YAML

[Alexey Charkov]

On Thu, Apr 24, 2025 at 10:35 AM Uwe Kleine-König <ukleinek@kernel.org> wrote:
>
> On Fri, Apr 18, 2025 at 06:55:07PM +0400, Alexey Charkov wrote:
> > Rewrite the textual description for the WonderMedia PWM controller
> > as YAML schema, and switch the filename to follow the compatible
> > string.
> >
> > Signed-off-by: Alexey Charkov <alchark@gmail.com>
> > ---
> > Split the series from v1 into separate bindings patches so as not to
> > spam all the subsystems with unrelated changes, per Rob's suggestion
>
> That's a good suggestion.
>
> Applied with Rob's R-b tag to
> https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git pwm/for-next

Thanks a lot!

> I saw you signed your patch using PGP, which is great. However I didn't
> find your key. I recommend to make it available on keys.openpgp.org like
> this:
>
>         gpg --export alchark@gmail.com | curl -T - https://keys.openpgp.org
>
> and then verify your identities using the link in the output of this
> command. Still better, (additionally) add your key to the kernel keyring
> (which however requires you to be in Linus Torvalds WoT, see
> https://korg.docs.kernel.org/pgpkeys.html for the details).

Hmm, I used b4's built-in patatt functionality with a dedicated
ed25519 key, not a gpg managed one. Looks like keys.openpgp.org
doesn't understand those directly, or am I missing something?

Best regards,
Alexey

Re: [PATCH v2] dt-bindings: pwm: vt8500-pwm: Convert to YAML

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 1261 bytes --]

Hello Alexey,

On Thu, Apr 24, 2025 at 12:07:03PM +0400, Alexey Charkov wrote:
> On Thu, Apr 24, 2025 at 10:35 AM Uwe Kleine-König <ukleinek@kernel.org> wrote:
> > I saw you signed your patch using PGP, which is great. However I didn't
> > find your key. I recommend to make it available on keys.openpgp.org like
> > this:
> >
> >         gpg --export alchark@gmail.com | curl -T - https://keys.openpgp.org
> >
> > and then verify your identities using the link in the output of this
> > command. Still better, (additionally) add your key to the kernel keyring
> > (which however requires you to be in Linus Torvalds WoT, see
> > https://korg.docs.kernel.org/pgpkeys.html for the details).
> 
> Hmm, I used b4's built-in patatt functionality with a dedicated
> ed25519 key, not a gpg managed one. Looks like keys.openpgp.org
> doesn't understand those directly, or am I missing something?

No, I wasn't aware that patatt also uses signature algos other than PGP.
Without your key known, using ed25519 is kind of useless because it
cannot be verified. I would recommend switching to PGP because for that
the key distribution is a (somewhat) solved problem.

Nevertheless I'll play a bit with patatt and your key.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2] dt-bindings: pwm: vt8500-pwm: Convert to YAML

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

On Thu, Apr 24, 2025 at 02:32:33PM +0200, Uwe Kleine-König wrote:
> Nevertheless I'll play a bit with patatt and your key.

FTR, it wasn't complicated:

	$ keyringdir=~/.local/share/patatt/public
	$ mkdir "$keyringdir"
	$ git config --global set --append patatt.keyringsrc "$keyringsrc"
	$ mkdir -p "$keyringdir/ed25519/gmail.com/alchark
	$ echo "ltKbQzKLTJPiDgPtcHxdo+dzFthCCMtC3V9qf7+0rkc=" > "$keyringdir/ed25519/gmail.com/alchark/20250416"

After that `b4 am` told me:

	✓ Signed: ed25519/alchark@gmail.com

for your patch \o/

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2] dt-bindings: pwm: vt8500-pwm: Convert to YAML

[Alexey Charkov]

On Thu, Apr 24, 2025 at 4:48 PM Uwe Kleine-König <ukleinek@kernel.org> wrote:
>
> On Thu, Apr 24, 2025 at 02:32:33PM +0200, Uwe Kleine-König wrote:
> > Nevertheless I'll play a bit with patatt and your key.
>
> FTR, it wasn't complicated:
>
>         $ keyringdir=~/.local/share/patatt/public
>         $ mkdir "$keyringdir"
>         $ git config --global set --append patatt.keyringsrc "$keyringsrc"
>         $ mkdir -p "$keyringdir/ed25519/gmail.com/alchark
>         $ echo "ltKbQzKLTJPiDgPtcHxdo+dzFthCCMtC3V9qf7+0rkc=" > "$keyringdir/ed25519/gmail.com/alchark/20250416"

I believe b4 can make this even a bit shorter:
https://b4.docs.kernel.org/en/latest/maintainer/kr.html#b4-kr-show-keys

> After that `b4 am` told me:
>
>         ✓ Signed: ed25519/alchark@gmail.com
>
> for your patch \o/

Great that it works! Thanks a lot!

Best regards,
Alexey