From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, "Andrew Lunn" <andrew@lunn.ch>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
linux-arm-kernel@lists.infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Simon Horman" <horms@kernel.org>,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Piergiorgio Beruto" <piergiorgio.beruto@gmail.com>
Subject: Re: [PATCH net-next v6 1/2] net: ethtool: Introduce per-PHY DUMP operations
Date: Fri, 18 Apr 2025 09:00:16 +0200 [thread overview]
Message-ID: <20250418090016.01900035@fedora.home> (raw)
In-Reply-To: <564ca4ac-661e-4126-a65a-106d3c28a47e@redhat.com>
Hi Paolo,
On Thu, 17 Apr 2025 12:03:43 +0200
Paolo Abeni <pabeni@redhat.com> wrote:
> On 4/15/25 10:51 AM, Maxime Chevallier wrote:
> > +static int ethnl_perphy_dump_all_dev(struct sk_buff *skb,
> > + struct ethnl_perphy_dump_ctx *ctx,
> > + const struct genl_info *info)
> > +{
> > + struct ethnl_dump_ctx *ethnl_ctx = &ctx->ethnl_ctx;
> > + struct net *net = sock_net(skb->sk);
> > + struct net_device *dev;
> > + int ret = 0;
> > +
> > + rcu_read_lock();
> > + for_each_netdev_dump(net, dev, ethnl_ctx->pos_ifindex) {
> > + dev_hold(dev);
>
> Minor nit: please use netdev_hold() instead.
Will do, I didn't see the notice about using netdev_hold instead in the
doc, I merely used the current ethnl_default_dumpit() as a reference,
and it uses dev_hold() as well.
should I convert it to netdev_hold() along the way in v3 ?
Maxime
next prev parent reply other threads:[~2025-04-18 7:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 8:51 [PATCH net-next v6 0/2] net: ethtool: Introduce ethnl dump helpers Maxime Chevallier
2025-04-15 8:51 ` [PATCH net-next v6 1/2] net: ethtool: Introduce per-PHY DUMP operations Maxime Chevallier
2025-04-17 10:03 ` Paolo Abeni
2025-04-18 7:00 ` Maxime Chevallier [this message]
2025-04-15 8:51 ` [PATCH net-next v6 2/2] net: ethtool: phy: Convert the PHY_GET command to generic phy dump Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250418090016.01900035@fedora.home \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox