From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Tinghan Shen <tinghan.shen@mediatek.com>,
Olivia Wen <olivia.wen@mediatek.com>
Cc: kernel@collabora.com, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Nícolas F. R. A. Prado" <nfraprado@collabora.com>
Subject: [PATCH v2 2/5] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP
Date: Mon, 21 Apr 2025 16:49:05 -0400 [thread overview]
Message-ID: <20250421-scp-dual-core-mt8390-v2-2-c84117a959a9@collabora.com> (raw)
In-Reply-To: <20250421-scp-dual-core-mt8390-v2-0-c84117a959a9@collabora.com>
The SCP present on MT8188 does not have an L1TCM memory region, but the
binding incorrectly requires one for the dual-core description of the
MT8188 SCP. Remove that requirement. Also update the minimum number of
reg and reg-names to 1, since as this is a multi-core SCP with no
L1TCM memory, only the CFG memory region is present in the parent node.
Fixes: 91e0d560b9fd ("dt-bindings: remoteproc: mediatek: Support MT8188 dual-core SCP")
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
---
.../devicetree/bindings/remoteproc/mtk,scp.yaml | 19 ++++++++++++++++---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
index ee33c233e44f3d51f0851b35697a24208c87f68a..04348cfcb0424dc78ff1ddd77665285a052925e9 100644
--- a/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml
@@ -28,11 +28,11 @@ properties:
description:
Should contain the address ranges for memory regions SRAM, CFG, and,
on some platforms, L1TCM.
- minItems: 2
+ minItems: 1
maxItems: 3
reg-names:
- minItems: 2
+ minItems: 1
maxItems: 3
clocks:
@@ -171,6 +171,7 @@ allOf:
then:
properties:
reg:
+ minItems: 2
maxItems: 2
reg-names:
items:
@@ -196,16 +197,28 @@ allOf:
properties:
compatible:
enum:
- - mediatek,mt8188-scp-dual
- mediatek,mt8195-scp-dual
then:
properties:
reg:
+ minItems: 2
maxItems: 2
reg-names:
items:
- const: cfg
- const: l1tcm
+ - if:
+ properties:
+ compatible:
+ enum:
+ - mediatek,mt8188-scp-dual
+ then:
+ properties:
+ reg:
+ maxItems: 1
+ reg-names:
+ items:
+ - const: cfg
additionalProperties: false
--
2.49.0
next prev parent reply other threads:[~2025-04-21 20:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 20:49 [PATCH v2 0/5] Describe MT8188's SCP as dual-core Nícolas F. R. A. Prado
2025-04-21 20:49 ` [PATCH v2 1/5] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195 Nícolas F. R. A. Prado
2025-04-22 13:44 ` AngeloGioacchino Del Regno
2025-04-23 15:49 ` Rob Herring
2025-04-21 20:49 ` Nícolas F. R. A. Prado [this message]
2025-04-21 20:49 ` [PATCH v2 3/5] dt-bindings: remoteproc: mediatek: Drop redundant maxItems for mt8192/95 Nícolas F. R. A. Prado
2025-04-23 15:51 ` Rob Herring
2025-04-21 20:49 ` [PATCH v2 4/5] arm64: dts: mediatek: mt8188: Describe SCP as a cluster with two cores Nícolas F. R. A. Prado
2025-04-21 20:49 ` [PATCH v2 5/5] arm64: dts: mediatek: mt8390-genio-common: Add firmware-name for scp0 Nícolas F. R. A. Prado
2025-04-22 13:47 ` (subset) [PATCH v2 0/5] Describe MT8188's SCP as dual-core AngeloGioacchino Del Regno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421-scp-dual-core-mt8390-v2-2-c84117a959a9@collabora.com \
--to=nfraprado@collabora.com \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=olivia.wen@mediatek.com \
--cc=robh@kernel.org \
--cc=tinghan.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).