From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, netdev@vger.kernel.org,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next v2] net: airoha: Add missing filed to ppe_mbox_data struct
Date: Mon, 21 Apr 2025 18:36:10 -0700 [thread overview]
Message-ID: <20250421183610.7bad877c@kernel.org> (raw)
In-Reply-To: <20250417-airoha-en7581-fix-ppe_mbox_data-v2-1-43433cfbe874@kernel.org>
On Thu, 17 Apr 2025 11:30:47 +0200 Lorenzo Bianconi wrote:
> The official Airoha EN7581 firmware requires adding max_packet filed in
> ppe_mbox_data struct while the unofficial one used to develop the Airoha
> EN7581 flowtable support does not require this field.
> This patch does not introduce any real backwards compatible issue since
> EN7581 fw is not publicly available in linux-firmware or other
> repositories (e.g. OpenWrt) yet and the official fw version will use this
> new layout. For this reason this change needs to be backported.
>
> Fixes: 23290c7bc190d ("net: airoha: Introduce Airoha NPU support")
I'm not sure I agree with this fixes tag. The fixes tag should point
to the earliest commit where any problem may be visible. IIUC you're
targeting net-next because the structure is not used in net. So the
Fixes tag should also point to some commit in net-next...
If we leave it as is after the merge window stable bot will pull this
commit into 6.15 for no good reason.
--
pw-bot: cr
next prev parent reply other threads:[~2025-04-22 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-17 9:30 [PATCH net-next v2] net: airoha: Add missing filed to ppe_mbox_data struct Lorenzo Bianconi
2025-04-22 1:36 ` Jakub Kicinski [this message]
2025-04-22 14:06 ` Lorenzo Bianconi
2025-04-22 14:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250421183610.7bad877c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).