[PATCH net-next v2] net: airoha: Add missing filed to ppe_mbox_data struct

[PATCH net-next v2] net: airoha: Add missing filed to ppe_mbox_data struct

[Lorenzo Bianconi]

The official Airoha EN7581 firmware requires adding max_packet filed in
ppe_mbox_data struct while the unofficial one used to develop the Airoha
EN7581 flowtable support does not require this field.
This patch does not introduce any real backwards compatible issue since
EN7581 fw is not publicly available in linux-firmware or other
repositories (e.g. OpenWrt) yet and the official fw version will use this
new layout. For this reason this change needs to be backported.

Fixes: 23290c7bc190d ("net: airoha: Introduce Airoha NPU support")
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
Changes in v2:
- Add more details to commit log
- Link to v1: https://lore.kernel.org/r/20250415-airoha-en7581-fix-ppe_mbox_data-v1-1-4408c60ba964@kernel.org
---
 drivers/net/ethernet/airoha/airoha_npu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/airoha/airoha_npu.c b/drivers/net/ethernet/airoha/airoha_npu.c
index 7a5710f9ccf6a4a4f555ab63d67cb6b318de9b52..16201b5ce9f27866896226c3611b4a154d19bc2c 100644
--- a/drivers/net/ethernet/airoha/airoha_npu.c
+++ b/drivers/net/ethernet/airoha/airoha_npu.c
@@ -104,6 +104,7 @@ struct ppe_mbox_data {
 			u8 xpon_hal_api;
 			u8 wan_xsi;
 			u8 ct_joyme4;
+			u8 max_packet;
 			int ppe_type;
 			int wan_mode;
 			int wan_sel;

---
base-commit: df8398fb7bb7a0e509200af56b79343aa133b7d6
change-id: 20250414-airoha-en7581-fix-ppe_mbox_data-2f1880f7486c

Best regards,
-- 
Lorenzo Bianconi <lorenzo@kernel.org>

Re: [PATCH net-next v2] net: airoha: Add missing filed to ppe_mbox_data struct

[Jakub Kicinski]

On Thu, 17 Apr 2025 11:30:47 +0200 Lorenzo Bianconi wrote:
> The official Airoha EN7581 firmware requires adding max_packet filed in
> ppe_mbox_data struct while the unofficial one used to develop the Airoha
> EN7581 flowtable support does not require this field.
> This patch does not introduce any real backwards compatible issue since
> EN7581 fw is not publicly available in linux-firmware or other
> repositories (e.g. OpenWrt) yet and the official fw version will use this
> new layout. For this reason this change needs to be backported.
> 
> Fixes: 23290c7bc190d ("net: airoha: Introduce Airoha NPU support")

I'm not sure I agree with this fixes tag. The fixes tag should point 
to the earliest commit where any problem may be visible. IIUC you're
targeting net-next because the structure is not used in net. So the
Fixes tag should also point to some commit in net-next...
If we leave it as is after the merge window stable bot will pull this
commit into 6.15 for no good reason.
-- 
pw-bot: cr

Re: [PATCH net-next v2] net: airoha: Add missing filed to ppe_mbox_data struct

[Lorenzo Bianconi]

[-- Attachment #1: Type: text/plain, Size: 2310 bytes --]

> On Thu, 17 Apr 2025 11:30:47 +0200 Lorenzo Bianconi wrote:
> > The official Airoha EN7581 firmware requires adding max_packet filed in
> > ppe_mbox_data struct while the unofficial one used to develop the Airoha
> > EN7581 flowtable support does not require this field.
> > This patch does not introduce any real backwards compatible issue since
> > EN7581 fw is not publicly available in linux-firmware or other
> > repositories (e.g. OpenWrt) yet and the official fw version will use this
> > new layout. For this reason this change needs to be backported.
> > 
> > Fixes: 23290c7bc190d ("net: airoha: Introduce Airoha NPU support")
> 
> I'm not sure I agree with this fixes tag. The fixes tag should point 
> to the earliest commit where any problem may be visible. IIUC you're
> targeting net-next because the structure is not used in net. So the
> Fixes tag should also point to some commit in net-next...
> If we leave it as is after the merge window stable bot will pull this
> commit into 6.15 for no good reason.

Hi Jakub,

actually the commit below is even present in the net tree. Since this is
required to work with the official airoha firmware, I guess I should repost
targeting net with the same Fixes tag. Agree?

Regards,
Lorenzo

commit 23290c7bc190def4e1ca61610992d9b7c32e33f3
Author: Lorenzo Bianconi <lorenzo@kernel.org>
Date:   Fri Feb 28 11:54:20 2025 +0100

    net: airoha: Introduce Airoha NPU support

    Packet Processor Engine (PPE) module available on EN7581 SoC populates
    the PPE table with 5-tuples flower rules learned from traffic forwarded
    between the GDM ports connected to the Packet Switch Engine (PSE) module.
    The airoha_eth driver can enable hw acceleration of learned 5-tuples
    rules if the user configure them in netfilter flowtable (netfilter
    flowtable support will be added with subsequent patches).
    airoha_eth driver configures and collects data from the PPE module via a
    Network Processor Unit (NPU) RISC-V module available on the EN7581 SoC.
    Introduce basic support for Airoha NPU module.
    
    Tested-by: Sayantan Nandy <sayantan.nandy@airoha.com>
    Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
    Signed-off-by: Paolo Abeni <pabeni@redhat.com>

> -- 
> pw-bot: cr

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH net-next v2] net: airoha: Add missing filed to ppe_mbox_data struct

[Jakub Kicinski]

On Tue, 22 Apr 2025 16:06:24 +0200 Lorenzo Bianconi wrote:
> actually the commit below is even present in the net tree. Since this is
> required to work with the official airoha firmware, I guess I should repost
> targeting net with the same Fixes tag. Agree?

Agree! I must have mis-grep'ed it